From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Breno Rodrigues Alves <breno3011alves@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: Fix three real issues
Date: Fri, 23 Oct 2026 08:08:35 +0200 [thread overview]
Message-ID: <2026102337-headroom-shun-9d45@gregkh> (raw)
In-Reply-To: <20261022215349.87471-1-breno3011alves@gmail.com>
On Thu, Oct 22, 2026 at 06:53:49PM -0300, Breno Rodrigues Alves wrote:
> Fix three issues in the Xilinx AXI-Stream FIFO driver:
>
> 1. axis_fifo_debugfs_init() did not check the return value of
> debugfs_create_dir(). When CONFIG_DEBUG_FS=n, the function
> returns ERR_PTR(-ENODEV); passing it as a parent to
> debugfs_create_file() triggers a WARN in the kernel debugfs
> core. Bail out early if the directory was not created.
This is not a real issue, you should NEVER be checking the return value
of any debugfs file, and no WARN will ever fire (if so, please show me
where as that should not be happening.)
What tool told you this? Please fix it.
thanks,
greg k-h
next prev parent reply other threads:[~2026-10-23 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 21:53 Breno Rodrigues Alves
2026-10-23 6:08 ` Greg Kroah-Hartman [this message]
2026-10-23 8:52 ` Breno Rodrigues Alves
2026-10-23 9:27 ` Dan Carpenter
2026-10-23 10:39 ` [PATCH v2] staging: axis-fifo: remove unused r_mem local variable Breno Rodrigues Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026102337-headroom-shun-9d45@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=breno3011alves@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®