From: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: atanas.filipov@oss.qualcomm.com,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Gjorgji Rosikopulos <gjorgji.rosikopulos@oss.qualcomm.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 6/6] media: qcom: camss: sm8250: set the camera NoC AXI rate from the VFE
Date: Sat, 24 Oct 2026 12:40:27 +0300 [thread overview]
Message-ID: <20261024094027.3095475-7-atanas.filipov@oss.qualcomm.com> (raw)
In-Reply-To: <20261024094027.3095475-1-atanas.filipov@oss.qualcomm.com>
The SM8250 VFE resources list both the camera NoC AXI RCG,
camnoc_axi_src, and its camnoc_axi branch. The camnoc_axi_src levels
are never applied, since vfe_match_clock_names() does not match that
name, and they list 480 MHz, which the RCG does not support. The
camnoc_axi branch has no rates, so the camera NoC runs from XO and two
concurrent streams stall.
Drop camnoc_axi_src, as the camnoc_axi branch keeps it enabled through
its parent, and list the 300 and 400 MHz camera NoC AXI rates for the
camnoc_axi branch, whose rate the VFE sets through the parent. The four
VFEs share its source through a clock domain, so it runs at the highest
rate requested by the running VFEs.
Signed-off-by: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
---
drivers/media/platform/qcom/camss/camss.c | 28 ++++++++++-------------
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 100612d97fa7..9bfb634ee9f7 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -2120,13 +2120,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = {
/* VFE0 */
{
.regulators = {},
- .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
+ .clock = { "slow_ahb_src", "cpas_ahb",
"camnoc_axi", "vfe0_ahb", "vfe0_areg", "vfe0",
"vfe0_axi", "cam_hf_axi" },
- .clock_rate = { { 19200000, 300000000, 400000000, 480000000 },
- { 19200000, 80000000 },
+ .clock_rate = { { 19200000, 80000000 },
{ 19200000 },
- { 0 },
+ { 300000000, 400000000 },
{ 0 },
{ 100000000, 200000000, 300000000, 400000000 },
{ 350000000, 475000000, 576000000, 720000000 },
@@ -2146,13 +2145,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = {
/* VFE1 */
{
.regulators = {},
- .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
+ .clock = { "slow_ahb_src", "cpas_ahb",
"camnoc_axi", "vfe1_ahb", "vfe1_areg", "vfe1",
"vfe1_axi", "cam_hf_axi" },
- .clock_rate = { { 19200000, 300000000, 400000000, 480000000 },
- { 19200000, 80000000 },
+ .clock_rate = { { 19200000, 80000000 },
{ 19200000 },
- { 0 },
+ { 300000000, 400000000 },
{ 0 },
{ 100000000, 200000000, 300000000, 400000000 },
{ 350000000, 475000000, 576000000, 720000000 },
@@ -2172,13 +2170,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = {
/* VFE2 (lite) */
{
.regulators = {},
- .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
+ .clock = { "slow_ahb_src", "cpas_ahb",
"camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi",
"vfe_lite", "cam_hf_axi" },
- .clock_rate = { { 19200000, 300000000, 400000000, 480000000 },
- { 19200000, 80000000 },
+ .clock_rate = { { 19200000, 80000000 },
{ 19200000 },
- { 0 },
+ { 300000000, 400000000 },
{ 0 },
{ 0 },
{ 400000000, 480000000 },
@@ -2196,13 +2193,12 @@ static const struct camss_subdev_resources vfe_res_8250[] = {
/* VFE3 (lite) */
{
.regulators = {},
- .clock = { "camnoc_axi_src", "slow_ahb_src", "cpas_ahb",
+ .clock = { "slow_ahb_src", "cpas_ahb",
"camnoc_axi", "vfe_lite_ahb", "vfe_lite_axi",
"vfe_lite", "cam_hf_axi" },
- .clock_rate = { { 19200000, 300000000, 400000000, 480000000 },
- { 19200000, 80000000 },
+ .clock_rate = { { 19200000, 80000000 },
{ 19200000 },
- { 0 },
+ { 300000000, 400000000 },
{ 0 },
{ 0 },
{ 400000000, 480000000 },
--
2.34.1
next prev parent reply other threads:[~2026-10-24 9:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 9:40 [PATCH v2 0/6] media: qcom: camss: share VFE clock sources on SM8250 Atanas Filipov
2026-10-24 9:40 ` [PATCH v2 1/6] media: qcom: camss: factor out the VFE minimum clock rate Atanas Filipov
2026-10-26 9:07 ` Bryan O'Donoghue
2026-10-24 9:40 ` [PATCH v2 2/6] media: qcom: camss: clamp VFE clock rates to the highest level Atanas Filipov
2026-10-26 9:08 ` Bryan O'Donoghue
2026-10-26 9:28 ` Loic Poulain
2026-10-26 13:18 ` Atanas Filipov
2026-10-24 9:40 ` [PATCH v2 3/6] media: qcom: camss: sm8250: do not set VFE core clock rates from CSID Atanas Filipov
2026-10-26 9:08 ` Bryan O'Donoghue
2026-10-24 9:40 ` [PATCH v2 4/6] media: qcom: camss: share VFE clock sources by the highest rate Atanas Filipov
2026-10-26 9:13 ` Bryan O'Donoghue
2026-10-26 13:18 ` Atanas Filipov
2026-10-24 9:40 ` [PATCH v2 5/6] media: qcom: camss: sm8250: set the VFE AREG clock rate from the VFE Atanas Filipov
2026-10-26 9:22 ` Bryan O'Donoghue
2026-10-26 13:18 ` Atanas Filipov
2026-10-24 9:40 ` Atanas Filipov [this message]
2026-10-26 9:25 ` [PATCH v2 6/6] media: qcom: camss: sm8250: set the camera NoC AXI " Bryan O'Donoghue
2026-10-26 13:18 ` Atanas Filipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024094027.3095475-7-atanas.filipov@oss.qualcomm.com \
--to=atanas.filipov@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®