mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Fernando Rimoli <fernandorimoli11@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>,
	Peter Marshall <pm@petermarshall.ca>,
	George Neacsu <geocausa@gmail.com>,
	"D . Manresa" <dmanresa@gmail.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator
Date: Sun, 25 Oct 2026 17:23:03 +0000	[thread overview]
Message-ID: <20261025172251.19293-1-lsa.uz@pm.me> (raw)
In-Reply-To: <20261025154743.39801-1-fernandorimoli11@gmail.com>

Hi Fernando,

On 25/10/2026 15:47, Fernando Rimoli wrote:
> The property entry keeps pointers to both its name and its values, and
> here both point into the module image: the "st,leds" literal and the
> static const surface_pro_11_ir_gpios[].

You are right, thank you. The only other name there that does not come
from the per-sensor prop_names copy is "lens-focus", which D. Manresa's
v4 moves as well. So v2 will do what your a20c843c9bc4 and his v4 do:
"st,leds" goes into struct ipu_property_names, and the GPIO numbers are
copied into struct ipu_sensor.

> Manresa's v4 1/2 changes this same line to use names->lens_focus, so
> whichever of the two lands second will need a rebase.

Noted; v2 will say so below the ---.

> The Surface Pro 9 needs an entry too. Its VD55G0 drives the illuminator
> from GPIO 1, as on your machine.

v2 will add it, matching the sys_vendor and product_name you give
exactly, as for the Surface Pro 11. I will Cc you; a run of v2 as posted
on the Surface Pro 9 would be welcome.

Sergey


  reply	other threads:[~2026-10-25 17:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:27 [PATCH 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-10-19 16:27 ` [PATCH 1/4] dt-bindings: media: i2c: Add ST VD55G0 camera sensor Sergey Lebedev
2026-10-20  8:27   ` Krzysztof Kozlowski
2026-10-20  9:08     ` Sergey Lebedev
2026-10-19 16:27 ` [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-10-19 18:24   ` George Neacsu
2026-10-19 19:34     ` Sergey Lebedev
2026-10-20  6:44       ` George Neacsu
2026-10-20  8:52         ` Sergey Lebedev
2026-10-20 12:25           ` Benjamin Mugnier
2026-10-20 14:26             ` Sergey Lebedev
2026-10-20 18:10               ` George Neacsu
2026-10-20 18:14                 ` Sergey Lebedev
2026-10-21  9:02                   ` Benjamin Mugnier
2026-10-21  9:04                     ` Benjamin Mugnier
2026-10-21  9:06                     ` Sergey Lebedev
2026-10-19 16:28 ` [PATCH 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-10-19 16:28 ` [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator Sergey Lebedev
2026-10-25 15:47   ` Fernando Rimoli
2026-10-25 17:23     ` Sergey Lebedev [this message]
2026-10-25 15:51 ` [PATCH 0/4] media: Add the ST VD55G0 global shutter sensor Fernando Rimoli
2026-10-25 17:38   ` Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261025172251.19293-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=dmanresa@gmail.com \
    --cc=fernandorimoli11@gmail.com \
    --cc=geocausa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®