mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: SJ Park <sj@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aveline Noir <jm5905938@gmail.com>
Subject: Re: [PATCH] mm/damon/reclaim: improve grammar and style
Date: Mon, 26 Oct 2026 17:11:39 -0700	[thread overview]
Message-ID: <20261027001140.156967-1-sj@kernel.org> (raw)
In-Reply-To: <72437017a038310cad48a5ff488377a9f8eb89f1.camel@mailbox.org>

On Mon, 26 Oct 2026 18:51:40 +0100 Manuel Ebner <manuelebnerli@mailbox.org> wrote:

> Hi,
> 
> took me some time to respond because of the procrastinations.

No worry!

> 
> On Sat, 2026-10-17 at 09:27 -0700, SJ Park wrote:
> > On Sat, 17 Oct 2026 11:18:34 +0200 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> > 
> > > Hi SJ,
> > > 
> > > On Thu, 2026-10-15 at 07:01 -0700, SJ Park wrote:
> > > > On Thu, 15 Oct 2026 10:06:23 +0200 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> > > > 
> > > > > Fix tenses. Replace 'set as' with 'set to'.
> > > > > Rewrite complex sentences.
> > > > 
> > > > Let's put two sentences in one line, while breaking it for the 75 column limit.
> > > 
> > > Will do.
> > > > 
> > > > [...]
> > > > > @@ -113,8 +113,8 @@ quota_sz
> > > > >  
> > > > >  Limit of size of memory for the reclamation in bytes.
> > > > >  
> > > > > -DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
> > > > > -window (quota_reset_interval_ms) and makes no more than this limit is tried.
> > > > > +DAMON_RECLAIM recordes the amount of memory which it tried to reclaim within a time
> > > > 
> > > > s/recordes/charges/  or s/recordes/records/ ?
> > > 
> > > For me charge is such a weird word exepct in 'charge a battery' or 'charge a fee'. And
> > > 'recordes' is a typo. Does this work:
> > 
> > 'charge' in this sentence is somewhat like 'charge a fee'.  I personally don't
> > feel it is weird.  But 'record' also work for me.
> 
> I will keep 'charge' at the later mention in the file.

Thank you for accepting my humble suggestion.

[...]
> > Sounds good.  But let's finish the discussion about use of the term, 'charge'
> > before posting v2.
> 
> Then I'll head to [v2] and make it a 2 part series.

Looking forward to v2!


Thanks,
SJ

[...]

  reply	other threads:[~2026-10-27  0:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  8:06 Manuel Ebner
2026-10-15 14:01 ` SJ Park
2026-10-17  9:18   ` Manuel Ebner
2026-10-17 16:27     ` SJ Park
2026-10-26 17:51       ` Manuel Ebner
2026-10-27  0:11         ` SJ Park [this message]
2026-10-16 12:34 ` Aveline Noir
2026-10-16 14:29   ` SJ Park
2026-10-16 16:45     ` Aveline Noir
2026-10-17  0:00       ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027001140.156967-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=jm5905938@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=manuelebnerli@mailbox.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®