mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: quentin.schulz@cherry.de
Cc: HystericalDragons@proton.me, amadeus@jmu.edu.cn,
	conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
	hrushirajg23@gmail.com, krzk+dt@kernel.org, krzk@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	liujianfeng1994@gmail.com, macromorgan@hotmail.com,
	michael.opdenacker@rootcommit.com, naoki@radxa.com,
	robh@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s
Date: Wed, 28 Oct 2026 09:50:58 +0800	[thread overview]
Message-ID: <20261028015058.11163-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <2a1c33c9-8971-4054-a463-60f3ceddd627@cherry.de>

Hi Quentin,

On Tue, 27 Oct 2026 17:03:02 +0100, Quentin Schulz wrote:
> From U-Boot's perspective, I would have preferred there be a simple 
>difference we can detect at runtime and based on that decide which 
>device tree to load between coolpi-4b and armsom-sige7s.

Maybe we can ask ArmSom to write some OEM strings into the OTP of SoC.
So we can use one defconfig for two boards. I will check this method
with ArmSoM and current OTP support in u-boot.

>I don't know Heiko's or Krzysztof's opinion here, but I think it would 
>better reflect the actual context to NOT use a dtsi and simply have 
>arch/arm64/boot/dts/rockchip/rk3588s-armsom-sige7s.dts include 
>arch/arm64/boot/dts/rockchip/rk3588s-coolpi-4b.dts and update the model 
>and compatible properties.

Thanks for the suggestion. I checked the existing mainline DTS files and
found similar examples, such as stm32mp157c-ev1.dts including
stm32mp157c-ed1.dts directly, and the ARM Juno SCMI variants including
their base board DTS files.

I agree that directly including rk3588s-coolpi-4b.dts would better reflect
the relationship between the two boards and avoid unnecessary changes to
the existing CoolPi DTS.

I'll use this approach in v2 unless Heiko prefers otherwise.

Best regards,
Jianfeng

  reply	other threads:[~2026-10-28  1:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 12:52 [PATCH 0/3] arm64: dts: rockchip: Add ArmSoM Sige7s support Jianfeng Liu
2026-10-22 12:52 ` [PATCH 1/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7s Jianfeng Liu
2026-10-26  7:08   ` Krzysztof Kozlowski
2026-10-26  7:59     ` Jianfeng Liu
2026-10-26 11:43       ` Heiko Stuebner
2026-10-27  2:28         ` Jianfeng Liu
2026-10-27  7:48           ` Krzysztof Kozlowski
2026-10-27  8:56             ` Jianfeng Liu
2026-10-27  9:56               ` Krzysztof Kozlowski
2026-10-28  1:42                 ` Jianfeng Liu
2026-10-27 16:03           ` Quentin Schulz
2026-10-28  1:50             ` Jianfeng Liu [this message]
2026-10-22 12:52 ` [PATCH 2/3] arm64: dts: rockchip: Extract common CoolPi 4B board description Jianfeng Liu
2026-10-22 12:52 ` [PATCH 3/3] arm64: dts: rockchip: Add ArmSoM Sige7s board Jianfeng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028015058.11163-1-liujianfeng1994@gmail.com \
    --to=liujianfeng1994@gmail.com \
    --cc=HystericalDragons@proton.me \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hrushirajg23@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=michael.opdenacker@rootcommit.com \
    --cc=naoki@radxa.com \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®