Re: [PATCH v4 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2377 bytes --]

On Thu, Nov 05, 2026 at 10:57:58AM +0100, H. Nikolaus Schaller wrote:
> Hi Olivier, Conor,
> 
> > Am 02.11.2026 um 21:48 schrieb Conor Dooley <conor@kernel.org>:
> > 
> > On Mon, Nov 02, 2026 at 09:11:54PM +0100, Olivier Louvignes wrote:
> >> The X1600's SAR ADC has four auxiliary channels and none of the
> >> touchscreen or battery engines of the JZ47xx ADCs in ingenic,adc.yaml,
> >> so it gets a binding of its own.
> >> 
> >> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> >> ---
> >> .../bindings/iio/adc/ingenic,x1600-adc.yaml   | 53 +++++++++++++++++++
> >> MAINTAINERS                                   |  5 ++
> >> 2 files changed, 58 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> >> 
> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml b/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> >> new file mode 100644
> >> index 000000000000..f6356ea97980
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/adc/ingenic,x1600-adc.yaml
> >> @@ -0,0 +1,53 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/iio/adc/ingenic,x1600-adc.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Ingenic X1600 ADC
> >> +
> >> +maintainers:
> >> +  - Olivier Louvignes <olivier@mgcrea.io>
> >> +
> >> +description:
> >> +  The SAR ADC of the Ingenic X1600 SoC, with four auxiliary input channels
> >> +  measured against a 3.3 V reference.
> > 
> > The wording here makes me wonder if a 3v3 supply is missing here? Or is
> > this some internal supply on the soc?
> 
> It is an external SADC_VREFP input pin (ball P12) which is usually connected to
> the 3v3 supply. But it is specified to be min=0V .. typical=3.3V ... max=VADC
> voltage levels.
> 
> VADC is indeed the power supply for the SADC on a separate ball. It must
> be in the range of 2.97V .. 3.3V .. 3.63V so that it is extremely likely to be
> connected to the system 3.3V rail.

Probably there should be at least an optional supply then, in case it
has a dedicated one for $reasons.
pw-bot: changes-requested

Thanks,
Conor.

> 
> Therefore I do not see a necessity to require a separate regulator reference here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]