From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
To: "Oded Gabbay" <ogabbay@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ekansh Gupta" <ekansh.gupta@oss.qualcomm.com>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Philipp Stanner" <phasta@kernel.org>,
dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org,
krzk@kernel.org, rob.clark@oss.qualcomm.com, jgg@ziepe.ca
Cc: lingtong@qti.qualcomm.com, cacar@qti.qualcomm.com,
sandheep@qti.qualcomm.com,
Bharath Kumar <bkumar@qti.qualcomm.com>,
Chenna Kesava Raju <chennak@qti.qualcomm.com>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
Bharath Kumar <quic_bkumar@quicinc.com>,
Chenna Kesava Raju <quic_chennak@quicinc.com>,
Ekansh Gupta <ekangupt@qti.qualcomm.com>
Subject: [PATCH v4 25/25] accel/qda: Add poll mode for invocation completion
Date: Mon, 02 Nov 2026 03:51:38 +0530 [thread overview]
Message-ID: <20261102-v4-v4-25-88f2f24a5f0b@qti.qualcomm.com> (raw)
In-Reply-To: <20261102-v4-v4-0-88f2f24a5f0b@qti.qualcomm.com>
From: Ekansh Gupta <ekangupt@qti.qualcomm.com>
Let a session opt in to completion polling for dynamically loaded
module invocations in a user PD via a new DRM_IOCTL_QDA_SET_OPTION
ioctl (and the equivalent legacy FASTRPC_IOCTL_SET_OPTION), mirroring
drivers/misc/fastrpc.c's FASTRPC_POLL_MODE.
A poll word is reserved at the end of every invocation's metadata
region. When polling is enabled, in use, and the invocation targets a
dynamically loaded handle in a user PD, the driver busy-waits on that
word for QDA_FASTRPC_POLL_RESPONSE instead of immediately blocking on
the rpmsg response, trading CPU cycles for lower round-trip latency.
If the DSP has not answered by the time the poll loop times out, the
driver falls back to waiting for the interrupt-based rpmsg response as
usual; the two paths share an is_work_done flag so whichever notices
completion first wins without racing the other.
Only SoCs whose DSP firmware actually implements this are allowed to
enable it: qda_soc_data gets a poll_mode_supported flag, set for
Kaanapali, and a closed list of older platforms using the generic
default_soc_data is checked as a fallback.
Signed-off-by: Ekansh Gupta <ekangupt@qti.qualcomm.com>
---
drivers/accel/qda/qda_drv.c | 1 +
drivers/accel/qda/qda_drv.h | 8 +++++
drivers/accel/qda/qda_fastrpc.c | 67 +++++++++++++++++++++++++++++++++---
drivers/accel/qda/qda_fastrpc.h | 15 ++++++++
drivers/accel/qda/qda_fastrpc_shim.c | 30 ++++++++++++++++
drivers/accel/qda/qda_ioctl.c | 45 ++++++++++++++++++++++++
drivers/accel/qda/qda_ioctl.h | 2 ++
drivers/accel/qda/qda_legacy_ops.c | 1 +
drivers/accel/qda/qda_legacy_ops.h | 2 ++
drivers/accel/qda/qda_rpmsg.c | 3 ++
drivers/accel/qda/qda_soc.c | 33 ++++++++++++++++++
drivers/accel/qda/qda_soc.h | 3 ++
include/uapi/drm/qda_accel.h | 27 +++++++++++++++
13 files changed, 233 insertions(+), 4 deletions(-)
diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c
index 51d8ef10c6c1..912dcb2b593d 100644
--- a/drivers/accel/qda/qda_drv.c
+++ b/drivers/accel/qda/qda_drv.c
@@ -128,6 +128,7 @@ static const struct drm_ioctl_desc qda_ioctls[] = {
DRM_IOCTL_DEF_DRV(QDA_REMOTE_MMAP, qda_ioctl_mmap, 0),
DRM_IOCTL_DEF_DRV(QDA_REMOTE_MUNMAP, qda_ioctl_munmap, 0),
DRM_IOCTL_DEF_DRV(QDA_REMOTE_SESSION_ATTACH, qda_ioctl_attach, 0),
+ DRM_IOCTL_DEF_DRV(QDA_SET_OPTION, qda_ioctl_set_option, 0),
};
static const struct drm_driver qda_drm_driver = {
diff --git a/drivers/accel/qda/qda_drv.h b/drivers/accel/qda/qda_drv.h
index cbb580d03e0b..ff58bac77319 100644
--- a/drivers/accel/qda/qda_drv.h
+++ b/drivers/accel/qda/qda_drv.h
@@ -71,6 +71,12 @@ struct qda_session {
* ioctls on one file can run concurrently.
*/
struct qda_gem_obj *init_mem_gem_obj;
+ /**
+ * @poll_mode: Poll for completion of invocations on dynamically loaded
+ * modules in a user PD. Set through the set-option ioctl, which can run
+ * concurrently with invocations on the same file.
+ */
+ bool poll_mode;
/**
* @msg_buf_pool: Invoke header buffers this session is done with,
* kept for its later invocations to reuse.
@@ -146,6 +152,8 @@ struct qda_dev {
struct mutex remote_heap_lock;
/** @audio_init_mem: True once the DSP has been given the remote heap */
bool audio_init_mem;
+ /** @poll_mode_supported: Sessions may opt in to invocation completion polling */
+ bool poll_mode_supported;
};
/**
diff --git a/drivers/accel/qda/qda_fastrpc.c b/drivers/accel/qda/qda_fastrpc.c
index 6044cfad53e9..0617bb4842b5 100644
--- a/drivers/accel/qda/qda_fastrpc.c
+++ b/drivers/accel/qda/qda_fastrpc.c
@@ -3,6 +3,7 @@
#include <linux/bitfield.h>
#include <linux/capability.h>
#include <linux/dma-mapping.h>
+#include <linux/iopoll.h>
#include <linux/limits.h>
#include <linux/mm.h>
#include <linux/sched.h>
@@ -89,8 +90,8 @@ static u64 calculate_page_aligned_size(u64 addr, u64 len)
* import time unless they are. So the metadata region needs exactly one
* qda_remote_buf, one qda_invoke_buf and one qda_phy_page per scalar; unlike
* drivers/misc/fastrpc.c, which supports multi-page buffers and so may need
- * several qda_phy_page entries per scalar. It ends with the handle list and
- * the CRC list.
+ * several qda_phy_page entries per scalar. It ends with the handle list, the
+ * CRC list and the poll word.
*/
static size_t qda_fastrpc_get_meta_size(struct qda_fastrpc_invoke_ctx *ctx)
{
@@ -98,7 +99,8 @@ static size_t qda_fastrpc_get_meta_size(struct qda_fastrpc_invoke_ctx *ctx)
sizeof(struct qda_invoke_buf) +
sizeof(struct qda_phy_page)) * ctx->nscalars +
sizeof(u64) * QDA_FASTRPC_MAX_HANDLELIST +
- sizeof(u32) * QDA_FASTRPC_MAX_CRCLIST;
+ sizeof(u32) * QDA_FASTRPC_MAX_CRCLIST +
+ sizeof(u32);
}
/**
@@ -518,6 +520,10 @@ static int qda_fastrpc_get_args(struct qda_fastrpc_invoke_ctx *ctx, struct qda_m
pages = (struct qda_phy_page *)&list[ctx->nscalars];
/* Kept so the handle list, which follows the pages, can be found later */
ctx->pages = pages;
+ /* The poll word follows the handle list and the CRC list */
+ ctx->poll_addr = (u32 *)((u8 *)(pages + ctx->nscalars) +
+ sizeof(u64) * QDA_FASTRPC_MAX_HANDLELIST +
+ sizeof(u32) * QDA_FASTRPC_MAX_CRCLIST);
for (i = 0; i < ctx->nbufs; ++i) {
rpra[i].buf.addr = 0;
@@ -598,6 +604,54 @@ int qda_fastrpc_invoke_pack(struct qda_fastrpc_invoke_ctx *ctx, struct qda_msg *
return 0;
}
+static u32 qda_fastrpc_read_poll_addr(struct qda_fastrpc_invoke_ctx *ctx)
+{
+ dma_rmb();
+
+ return READ_ONCE(*ctx->poll_addr);
+}
+
+/*
+ * Busy-wait for the DSP to write QDA_FASTRPC_POLL_RESPONSE into the poll word,
+ * which saves the interrupt and scheduling latency of waiting for the rpmsg
+ * response. The response still arrives afterwards and drops the reference
+ * qda_rpmsg_send_msg() took for it as usual.
+ *
+ * Return: 0 if the invocation completed, negative error code if it has not
+ * answered within QDA_FASTRPC_POLL_MAX_TIMEOUT_US
+ */
+static int qda_fastrpc_poll_for_rsp(struct qda_fastrpc_invoke_ctx *ctx)
+{
+ u32 val;
+ int err;
+
+ err = read_poll_timeout_atomic(qda_fastrpc_read_poll_addr, val,
+ val == QDA_FASTRPC_POLL_RESPONSE ||
+ READ_ONCE(ctx->is_work_done),
+ 1, QDA_FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx);
+ if (err)
+ return err;
+
+ /* The rpmsg path records its own status, so only the poll path's is set here */
+ if (val == QDA_FASTRPC_POLL_RESPONSE) {
+ WRITE_ONCE(ctx->is_work_done, true);
+ ctx->retval = 0;
+ }
+
+ return 0;
+}
+
+static int qda_fastrpc_wait_for_completion(struct qda_fastrpc_invoke_ctx *ctx)
+{
+ if (ctx->is_polled && !qda_fastrpc_poll_for_rsp(ctx))
+ return 0;
+
+ /* Polling timed out, so fall back to waiting for the rpmsg response */
+ ctx->is_polled = false;
+
+ return qda_rpmsg_wait_for_rsp(ctx);
+}
+
/**
* qda_fastrpc_flush_pending() - Fail every invocation still in flight
* @qdev: Device whose invocations should be failed
@@ -617,6 +671,7 @@ void qda_fastrpc_flush_pending(struct qda_dev *qdev)
xa_for_each(&qdev->ctx_xa, idx, ctx) {
ctx->retval = -EPIPE;
+ WRITE_ONCE(ctx->is_work_done, true);
complete(&ctx->work);
kref_put(&ctx->refcount, qda_fastrpc_context_free);
}
@@ -680,11 +735,15 @@ int qda_fastrpc_invoke_common(struct qda_dev *qdev, struct qda_fastrpc_invoke_ct
if (err)
return err;
+ /* Only invocations of a dynamically loaded module in a user PD are polled */
+ ctx->is_polled = READ_ONCE(ctx->session->poll_mode) && ctx->pd == QDA_USER_PD &&
+ ctx->handle > QDA_FASTRPC_MAX_STATIC_HANDLE;
+
err = qda_rpmsg_send_msg(qdev, &msg);
if (err)
return err;
- err = qda_rpmsg_wait_for_rsp(ctx);
+ err = qda_fastrpc_wait_for_completion(ctx);
if (err)
return err;
diff --git a/drivers/accel/qda/qda_fastrpc.h b/drivers/accel/qda/qda_fastrpc.h
index 7d5cd04943a3..2e01d126addc 100644
--- a/drivers/accel/qda/qda_fastrpc.h
+++ b/drivers/accel/qda/qda_fastrpc.h
@@ -75,6 +75,15 @@ struct qda_session;
#define QDA_USER_PD 1
#define QDA_SENSORS_PD 2
+/* Handles up to this value name static DSP services, not loaded modules */
+#define QDA_FASTRPC_MAX_STATIC_HANDLE 20
+
+/* Value the DSP writes to the poll word once a polled invocation completes */
+#define QDA_FASTRPC_POLL_RESPONSE 0xdecaf
+
+/* How long to poll before falling back to waiting for the rpmsg response */
+#define QDA_FASTRPC_POLL_MAX_TIMEOUT_US 10000
+
/* Largest ELF image a process may be created from */
#define QDA_FASTRPC_INIT_FILELEN_MAX (4 * 1024 * 1024)
@@ -342,6 +351,12 @@ struct qda_fastrpc_invoke_ctx {
struct drm_gem_object *map_obj;
/** @pages: Array of physical page descriptors inside the payload */
struct qda_phy_page *pages;
+ /** @poll_addr: Poll word at the end of the payload, written by the DSP */
+ u32 *poll_addr;
+ /** @is_polled: Wait for completion by polling @poll_addr first */
+ bool is_polled;
+ /** @is_work_done: Set once either the poll or the rpmsg path saw completion */
+ bool is_work_done;
/** @work: Completed once the DSP has answered */
struct completion work;
/**
diff --git a/drivers/accel/qda/qda_fastrpc_shim.c b/drivers/accel/qda/qda_fastrpc_shim.c
index 2be1dd116ef7..acd1b1b2f2b7 100644
--- a/drivers/accel/qda/qda_fastrpc_shim.c
+++ b/drivers/accel/qda/qda_fastrpc_shim.c
@@ -463,6 +463,34 @@ static long qda_shim_mem_unmap(struct qda_shim_file *sf, void __user *argp)
return 0;
}
+/*
+ * The legacy request IDs and values match the accel ones, but they are
+ * translated rather than passed through, so the two ABIs stay independent.
+ */
+static long qda_shim_set_option(struct qda_shim_file *sf, void __user *argp)
+{
+ struct fastrpc_ioctl_set_option args;
+ int i;
+
+ if (copy_from_user(&args, argp, sizeof(args)))
+ return -EFAULT;
+
+ for (i = 0; i < ARRAY_SIZE(args.reserved); i++)
+ if (args.reserved[i])
+ return -EINVAL;
+
+ if (args.request_id != FASTRPC_POLL_MODE)
+ return -EINVAL;
+
+ if (args.value != FASTRPC_POLL_MODE_ENABLE &&
+ args.value != FASTRPC_POLL_MODE_DISABLE)
+ return -EINVAL;
+
+ return qda_legacy_ops_table.set_option(sf->session, QDA_SET_OPTION_POLL_MODE,
+ args.value == FASTRPC_POLL_MODE_ENABLE ?
+ QDA_POLL_MODE_ENABLE : QDA_POLL_MODE_DISABLE);
+}
+
static long qda_shim_get_dsp_info(struct qda_shim_file *sf, void __user *argp)
{
struct fastrpc_ioctl_capability args;
@@ -570,6 +598,8 @@ static long qda_shim_dispatch(struct qda_shim_file *sf, unsigned int cmd, void _
return qda_shim_invoke(sf, argp);
case FASTRPC_IOCTL_GET_DSP_INFO:
return qda_shim_get_dsp_info(sf, argp);
+ case FASTRPC_IOCTL_SET_OPTION:
+ return qda_shim_set_option(sf, argp);
default:
/*
* Includes FASTRPC_IOCTL_FREE_DMA_BUFF, which the driver this
diff --git a/drivers/accel/qda/qda_ioctl.c b/drivers/accel/qda/qda_ioctl.c
index c784defd0f70..f43fae60059d 100644
--- a/drivers/accel/qda/qda_ioctl.c
+++ b/drivers/accel/qda/qda_ioctl.c
@@ -413,3 +413,48 @@ int qda_ioctl_invoke(struct drm_device *dev, void *data, struct drm_file *file_p
{
return qda_fastrpc_invoke(QDA_FASTRPC_RMID_INVOKE_DYNAMIC, data, file_priv->driver_priv);
}
+
+/**
+ * qda_session_set_option() - Set a per-session option
+ * @session: Session to update
+ * @request_id: Option to set (QDA_SET_OPTION_*)
+ * @value: Request-specific value
+ *
+ * Shared by the accel UAPI and the legacy shim's FASTRPC_IOCTL_SET_OPTION.
+ *
+ * Return: 0 on success, negative error code on failure
+ */
+int qda_session_set_option(struct qda_session *session, u32 request_id, u32 value)
+{
+ switch (request_id) {
+ case QDA_SET_OPTION_POLL_MODE:
+ if (!session->qda_dev->poll_mode_supported)
+ return -EOPNOTSUPP;
+
+ if (value == QDA_POLL_MODE_ENABLE)
+ WRITE_ONCE(session->poll_mode, true);
+ else if (value == QDA_POLL_MODE_DISABLE)
+ WRITE_ONCE(session->poll_mode, false);
+ else
+ return -EINVAL;
+
+ return 0;
+ default:
+ return -EINVAL;
+ }
+}
+
+/**
+ * qda_ioctl_set_option() - Set a per-session option
+ * @dev: DRM device structure
+ * @data: User-space data (struct drm_qda_set_option)
+ * @file_priv: DRM file private data
+ *
+ * Return: 0 on success, negative error code on failure
+ */
+int qda_ioctl_set_option(struct drm_device *dev, void *data, struct drm_file *file_priv)
+{
+ struct drm_qda_set_option *args = data;
+
+ return qda_session_set_option(file_priv->driver_priv, args->request_id, args->value);
+}
diff --git a/drivers/accel/qda/qda_ioctl.h b/drivers/accel/qda/qda_ioctl.h
index 329f3809c8ce..277c16742196 100644
--- a/drivers/accel/qda/qda_ioctl.h
+++ b/drivers/accel/qda/qda_ioctl.h
@@ -20,6 +20,8 @@ int qda_ioctl_init_create(struct drm_device *dev, void *data, struct drm_file *f
int qda_ioctl_mmap(struct drm_device *dev, void *data, struct drm_file *file_priv);
int qda_ioctl_munmap(struct drm_device *dev, void *data, struct drm_file *file_priv);
int qda_ioctl_attach(struct drm_device *dev, void *data, struct drm_file *file_priv);
+int qda_ioctl_set_option(struct drm_device *dev, void *data, struct drm_file *file_priv);
+int qda_session_set_option(struct qda_session *session, u32 request_id, u32 value);
int qda_session_init_create(struct qda_session *session, struct qda_init_create_args *create);
int qda_session_attach(struct qda_session *session, u32 pd_type, const char __user *name,
u32 namelen);
diff --git a/drivers/accel/qda/qda_legacy_ops.c b/drivers/accel/qda/qda_legacy_ops.c
index 8d9d597c76c2..18c17d5a9d2b 100644
--- a/drivers/accel/qda/qda_legacy_ops.c
+++ b/drivers/accel/qda/qda_legacy_ops.c
@@ -198,6 +198,7 @@ const struct qda_legacy_ops qda_legacy_ops_table = {
.session_destroy = legacy_session_destroy,
.init_create = legacy_init_create,
.attach = qda_session_attach,
+ .set_option = qda_session_set_option,
.release = legacy_release,
.mmap = legacy_mmap,
.mem_map = legacy_mem_map,
diff --git a/drivers/accel/qda/qda_legacy_ops.h b/drivers/accel/qda/qda_legacy_ops.h
index c79003021fc1..ffb3ebd9b1c5 100644
--- a/drivers/accel/qda/qda_legacy_ops.h
+++ b/drivers/accel/qda/qda_legacy_ops.h
@@ -36,6 +36,8 @@ struct qda_legacy_ops {
/** @attach: Attach the session to a DSP-resident protection domain */
int (*attach)(struct qda_session *session, u32 pd_type, const char __user *name,
u32 namelen);
+ /** @set_option: Set a per-session option */
+ int (*set_option)(struct qda_session *session, u32 request_id, u32 value);
/** @release: Release the session's DSP process, if it has one */
int (*release)(struct qda_session *session);
/** @mmap: Map a buffer into the DSP's address space */
diff --git a/drivers/accel/qda/qda_rpmsg.c b/drivers/accel/qda/qda_rpmsg.c
index b93e906b5793..c2a6798cb50d 100644
--- a/drivers/accel/qda/qda_rpmsg.c
+++ b/drivers/accel/qda/qda_rpmsg.c
@@ -132,6 +132,7 @@ static int qda_rpmsg_cb(struct rpmsg_device *rpdev, void *data, int len,
}
ctx->retval = resp_msg->retval;
+ WRITE_ONCE(ctx->is_work_done, true);
complete(&ctx->work);
/*
@@ -267,6 +268,8 @@ static int qda_rpmsg_probe(struct rpmsg_device *rpdev)
if (!qdev->soc_data)
return -ENODEV;
+ qdev->poll_mode_supported = qda_soc_poll_mode_supported(qdev->soc_data);
+
ret = of_property_read_string(rpdev->dev.of_node, "label", &qdev->dsp_name);
if (ret) {
dev_err(&rpdev->dev, "Missing 'label' property in DT node: %d\n", ret);
diff --git a/drivers/accel/qda/qda_soc.c b/drivers/accel/qda/qda_soc.c
index fb316b74103d..c670f747e1f5 100644
--- a/drivers/accel/qda/qda_soc.c
+++ b/drivers/accel/qda/qda_soc.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+#include <linux/of.h>
#include <linux/string.h>
#include "qda_drv.h"
#include "qda_soc.h"
@@ -8,6 +9,7 @@ const struct qda_soc_data kaanapali_soc_data = {
.sid_pos = 56,
.dma_addr_bits_cdsp = 34,
.dma_addr_bits_default = 32,
+ .poll_mode_supported = true,
};
const struct qda_soc_data default_soc_data = {
@@ -16,6 +18,37 @@ const struct qda_soc_data default_soc_data = {
.dma_addr_bits_default = 32,
};
+/*
+ * Platforms that share default_soc_data but whose DSP firmware does implement
+ * invocation completion polling. The list is closed: new SoCs advertise
+ * polling support through their own qda_soc_data instead.
+ */
+static const struct of_device_id qda_poll_mode_machines[] = {
+ { .compatible = "qcom,milos" },
+ { .compatible = "qcom,qcs8300" },
+ { .compatible = "qcom,sa8775p" },
+ { .compatible = "qcom,sar2130p" },
+ { .compatible = "qcom,sm8450" },
+ { .compatible = "qcom,sm8550" },
+ { .compatible = "qcom,sm8650" },
+ { .compatible = "qcom,sm8750" },
+ { .compatible = "qcom,x1e80100" },
+ { .compatible = "qcom,x1p42100" },
+ { }
+};
+
+/**
+ * qda_soc_poll_mode_supported() - Whether the DSP supports completion polling
+ * @soc_data: SoC parameters of the device
+ *
+ * Return: true if invocations on this SoC may use poll mode
+ */
+bool qda_soc_poll_mode_supported(const struct qda_soc_data *soc_data)
+{
+ return soc_data->poll_mode_supported ||
+ of_machine_get_match(qda_poll_mode_machines);
+}
+
/**
* qda_soc_dma_addr_bits() - DMA address width of a device's context banks
* @qdev: QDA device
diff --git a/drivers/accel/qda/qda_soc.h b/drivers/accel/qda/qda_soc.h
index fb5b786d0928..db8f10a30f7b 100644
--- a/drivers/accel/qda/qda_soc.h
+++ b/drivers/accel/qda/qda_soc.h
@@ -24,11 +24,14 @@ struct qda_soc_data {
u32 dma_addr_bits_cdsp;
/** @dma_addr_bits_default: DMA address width of all other context banks */
u32 dma_addr_bits_default;
+ /** @poll_mode_supported: DSP firmware supports invocation completion polling */
+ bool poll_mode_supported;
};
extern const struct qda_soc_data kaanapali_soc_data;
extern const struct qda_soc_data default_soc_data;
+bool qda_soc_poll_mode_supported(const struct qda_soc_data *soc_data);
u32 qda_soc_dma_addr_bits(const struct qda_dev *qdev);
/**
diff --git a/include/uapi/drm/qda_accel.h b/include/uapi/drm/qda_accel.h
index 07b943a3c822..816f2c10accf 100644
--- a/include/uapi/drm/qda_accel.h
+++ b/include/uapi/drm/qda_accel.h
@@ -20,6 +20,7 @@ extern "C" {
#define DRM_QDA_REMOTE_MMAP 0x05
#define DRM_QDA_REMOTE_MUNMAP 0x06
#define DRM_QDA_REMOTE_SESSION_ATTACH 0x07
+#define DRM_QDA_SET_OPTION 0x08
#define DRM_IOCTL_QDA_QUERY DRM_IOWR(DRM_COMMAND_BASE + DRM_QDA_QUERY, \
struct drm_qda_query)
@@ -39,6 +40,8 @@ extern "C" {
#define DRM_IOCTL_QDA_REMOTE_SESSION_ATTACH \
DRM_IOW(DRM_COMMAND_BASE + DRM_QDA_REMOTE_SESSION_ATTACH, \
struct drm_qda_remote_attach)
+#define DRM_IOCTL_QDA_SET_OPTION DRM_IOW(DRM_COMMAND_BASE + DRM_QDA_SET_OPTION, \
+ struct drm_qda_set_option)
/* Request types for drm_qda_mem_map.request */
#define QDA_REQUEST_MMAP 1 /* Map a whole buffer */
@@ -248,6 +251,30 @@ struct drm_qda_remote_attach {
__u64 name;
};
+/* Request IDs for drm_qda_set_option.request_id */
+#define QDA_SET_OPTION_POLL_MODE 1
+
+/* Values for drm_qda_set_option.value with QDA_SET_OPTION_POLL_MODE */
+#define QDA_POLL_MODE_DISABLE 0
+#define QDA_POLL_MODE_ENABLE 1
+
+/**
+ * struct drm_qda_set_option - Set a per-session option
+ * @request_id: Option to set (QDA_SET_OPTION_*)
+ * @value: Request-specific value
+ *
+ * For QDA_SET_OPTION_POLL_MODE, @value is QDA_POLL_MODE_ENABLE or
+ * QDA_POLL_MODE_DISABLE. Enabling poll mode lets the driver poll shared
+ * memory for completion of a dynamically loaded module's invocations in a
+ * user PD instead of waiting for an interrupt-based response, trading CPU
+ * cycles for lower round-trip latency. DSPs that do not support it reject
+ * the request with EOPNOTSUPP.
+ */
+struct drm_qda_set_option {
+ __u32 request_id;
+ __u32 value;
+};
+
#if defined(__cplusplus)
}
#endif
--
2.34.1
next prev parent reply other threads:[~2026-11-01 22:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 22:21 [PATCH v4 00/25] accel/qda: Qualcomm DSP Accelerator driver Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 01/25] accel/qda: Add QDA driver documentation Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 02/25] accel/qda: Add initial QDA DRM accelerator driver Ekansh Gupta
2026-11-02 8:42 ` Krzysztof Kozlowski
2026-11-01 22:21 ` [PATCH v4 03/25] accel/qda: Add compute context bank devices Ekansh Gupta
2026-11-02 8:43 ` Krzysztof Kozlowski
2026-11-01 22:21 ` [PATCH v4 04/25] accel/qda: Assign a context bank to each session Ekansh Gupta
2026-11-02 8:45 ` Krzysztof Kozlowski
2026-11-01 22:21 ` [PATCH v4 05/25] accel/qda: Add UAPI header and DSP query ioctl Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 06/25] accel/qda: Add buffer allocation for the DSP Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 07/25] accel/qda: Add DMA-BUF import Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 08/25] accel/qda: Add legacy ops base and auxiliary device Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 09/25] accel/qda: Add legacy FastRPC shim skeleton Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 10/25] accel/qda: Add FastRPC invocation contexts Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 11/25] accel/qda: Add RPMsg send and response dispatch Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 12/25] accel/qda: Add invocation argument validation and packing Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 13/25] accel/qda: Add the invocation ioctl and teardown on unplug Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 14/25] accel/qda: Add invocation through the legacy FastRPC shim Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 15/25] accel/qda: Add DSP process creation and release Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 16/25] accel/qda: Add DSP process creation and release to the legacy shim Ekansh Gupta
2026-11-02 8:47 ` Krzysztof Kozlowski
2026-11-01 22:21 ` [PATCH v4 17/25] accel/qda: Add remote memory mapping to the DSP address space Ekansh Gupta
2026-11-02 9:24 ` Konrad Dybcio
2026-11-01 22:21 ` [PATCH v4 18/25] accel/qda: Add remote memory unmapping from " Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 19/25] accel/qda: Add remote memory map and unmap to the legacy shim Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 20/25] accel/qda: Add remote attach to root and sensors protection domains Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 21/25] accel/qda: Add Audio protection domain attach and its remote heap Ekansh Gupta
2026-11-02 8:43 ` Arnd Bergmann
2026-11-02 8:50 ` Krzysztof Kozlowski
2026-11-01 22:21 ` [PATCH v4 22/25] accel/qda: Add remote session attach to the legacy shim Ekansh Gupta
2026-11-01 22:21 ` [PATCH v4 23/25] accel/qda: Add DSP capability query Ekansh Gupta
2026-11-02 8:46 ` Arnd Bergmann
2026-11-01 22:21 ` [PATCH v4 24/25] accel/qda: Add legacy shim support for " Ekansh Gupta
2026-11-01 22:21 ` Ekansh Gupta [this message]
2026-11-02 8:53 ` [PATCH v4 00/25] accel/qda: Qualcomm DSP Accelerator driver Krzysztof Kozlowski
2026-11-02 10:08 ` Ekansh Gupta
2026-11-02 10:12 ` Krzysztof Kozlowski
2026-11-02 10:52 ` Ekansh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102-v4-v4-25-88f2f24a5f0b@qti.qualcomm.com \
--to=ekansh.gupta@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bkumar@qti.qualcomm.com \
--cc=cacar@qti.qualcomm.com \
--cc=chennak@qti.qualcomm.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekangupt@qti.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=krzk@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=lingtong@qti.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=phasta@kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=rob.clark@oss.qualcomm.com \
--cc=sandheep@qti.qualcomm.com \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=srini@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®