Re: [PATCH v4 02/25] accel/qda: Add initial QDA DRM accelerator driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/11/2026 23:21, Ekansh Gupta wrote:
> +
> +#include "qda_drv.h"
> +
> +/*
> + * Both compatibles the binding defines are matched here. The glymur, hawi,
> + * maili and nord nodes name "qcom,kaanapali-fastrpc" as their fallback
> + * compatible and so are matched by that entry. Per-SoC DSP parameters are
> + * attached as match data by a later patch, once there is something that

So you add empty or non-working code. No, add these once you actually
have complete and working table.

> + * consumes them.
> + */

Drop comment, redundant. Referencing future patches makes no sense in
source code, because there is no "patch" when looking at the code.

> +static const struct of_device_id qda_rpmsg_of_match[] = {
> +	{ .compatible = "qcom,kaanapali-fastrpc" },
> +	{ .compatible = "qcom,fastrpc" },
> +	{ }




Best regards,
Krzysztof