Re: [PATCH 2/9] dt-bindings: phy: bcm-ns-usb3-phy: Describe the NSP variant

[Rob Herring <robh@kernel.org>]

On Fri, Oct 30, 2026 at 12:14:52PM -0700, Florian Fainelli wrote:
> On 10/30/26 11:21, Rob Herring wrote:
> > On Wed, Oct 21, 2026 at 10:28:11AM -0700, Florian Fainelli wrote:
> > > Northstar Plus uses the Northstar Bx PHY register sequence but also
> > > requires coordinated USB2 and USB3 core resets and a USB2 IDM interface
> > > clock enable.
> > > 
> > > Add an NSP compatible with a required USB2 DMP phandle. Describe the
> > > shared PHY relationship with EHCI, OHCI and xHCI so initialization
> > > finishes before any host starts operating.
> > > 
> > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> > > ---
> > >   .../bindings/phy/bcm-ns-usb3-phy.yaml         | 23 +++++++++++++++++++
> > >   1 file changed, 23 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> > > index 7fd419db45d0..00d69b86cbff 100644
> > > --- a/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/bcm-ns-usb3-phy.yaml
> > > @@ -14,6 +14,9 @@ description: |
> > >     Known B1: BCM4707 rev 6
> > >     Known C0: BCM47094 rev 0
> > > +  Northstar Plus uses the Bx programming sequence, with coordinated USB2 and
> > > +  USB3 resets. Its PHY is shared by the EHCI, OHCI and xHCI controllers.
> > > +
> > >   maintainers:
> > >     - Rafał Miłecki <rafal@milecki.pl>
> > > @@ -22,6 +25,7 @@ properties:
> > >       enum:
> > >         - brcm,ns-ax-usb3-phy
> > >         - brcm,ns-bx-usb3-phy
> > > +      - brcm,nsp-usb3-phy
> > >     reg:
> > >       description: address of MDIO bus device
> > > @@ -32,6 +36,13 @@ properties:
> > >       description:
> > >         Phandle to the DMP (Device Management Plugin) syscon
> > > +  usb2-dmp-syscon:
> > 
> > brcm,usb2-dmp
> 
> That would be inconsistent with the usb3-dmp-syscon property that is
> pre-existing, hence the name chosen here.

I'm not sure consistency is really better here, but okay.

Rob