From: Borislav Petkov <bp@alien8.de>
To: "Kalra, Ashish" <ashish.kalra@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
tglx@kernel.org, mingo@redhat.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, seanjc@google.com,
peterz@infradead.org, herbert@gondor.apana.org.au,
davem@davemloft.net, ardb@kernel.org, pbonzini@redhat.com,
aik@amd.com, Michael.Roth@amd.com, Tycho.Andersen@amd.com,
Nathan.Fontenot@amd.com, ackerleytng@google.com,
jackyli@google.com, pgonda@google.com, rientjes@google.com,
jacobhxu@google.com, xin@zytor.com,
pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com,
dyoung@redhat.com, nikunj@amd.com, darwi@linutronix.de,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
kvm@vger.kernel.org, linux-coco@lists.linux.dev
Subject: Re: [PATCH v4 1/2] x86/sev: Clear RMPOPT when segmented RMP is disabled by firmware
Date: Mon, 2 Nov 2026 16:22:08 -0800 [thread overview]
Message-ID: <20261103002208.GGaukpMICaKwIgoeRe@fat_crate.local> (raw)
In-Reply-To: <5c80e556-cdb8-46fd-9bee-c54732377236@amd.com>
On Mon, Nov 02, 2026 at 02:21:28PM -0600, Kalra, Ashish wrote:
> As i mentioned above, the cpuid-dep only fires when the SEV_SNP CPUID
> bit is cleared though, and the IOMMU "can't enable SNP" path clears only
> CC_ATTR_HOST_SEV_SNP, not the CPUID bit.
I believe the IOMMU path is too late in the boot for the CPUID bit anyway.
> So we still need the rmpopt_init() (in patch 2 of this series) move into
> snp_rmptable_init() to avoid announcing RMPOPT / allocating the workqueue on
> a host where the IOMMU turned SNP off — this dep doesn't cover that case.
Sure.
Lemme put everything into a proper patch now.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-11-03 0:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 19:48 [PATCH v4 0/2] x86/sev: Fix RMPOPT enablement on non-RMPOPT configs Ashish Kalra
2026-10-28 19:49 ` [PATCH v4 1/2] x86/sev: Clear RMPOPT when segmented RMP is disabled by firmware Ashish Kalra
2026-10-28 21:51 ` Pankaj Gupta
2026-11-02 5:28 ` Borislav Petkov
2026-11-02 6:12 ` K Prateek Nayak
2026-11-02 7:01 ` Borislav Petkov
2026-11-02 14:12 ` Tom Lendacky
2026-11-02 14:48 ` Borislav Petkov
2026-11-02 15:50 ` Kalra, Ashish
2026-11-02 19:31 ` Borislav Petkov
2026-11-02 20:21 ` Kalra, Ashish
2026-11-03 0:22 ` Borislav Petkov [this message]
2026-11-02 21:25 ` Tom Lendacky
2026-11-02 21:43 ` Borislav Petkov
2026-11-03 0:07 ` Kalra, Ashish
2026-11-03 0:45 ` Borislav Petkov
2026-11-03 2:58 ` K Prateek Nayak
2026-10-28 19:49 ` [PATCH v4 2/2] x86/sev: Set up RMPOPT only on an active SNP host Ashish Kalra
2026-10-28 22:00 ` Gupta, Pankaj
2026-10-29 15:33 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103002208.GGaukpMICaKwIgoeRe@fat_crate.local \
--to=bp@alien8.de \
--cc=Michael.Roth@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Tycho.Andersen@amd.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=babu.moger@amd.com \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jackyli@google.com \
--cc=jacobhxu@google.com \
--cc=kprateek.nayak@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®