From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Borislav Petkov <bp@alien8.de>, "Kalra, Ashish" <ashish.kalra@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>, <tglx@kernel.org>,
<mingo@redhat.com>, <dave.hansen@linux.intel.com>,
<x86@kernel.org>, <hpa@zytor.com>, <seanjc@google.com>,
<peterz@infradead.org>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <ardb@kernel.org>, <pbonzini@redhat.com>,
<aik@amd.com>, <Michael.Roth@amd.com>, <Tycho.Andersen@amd.com>,
<Nathan.Fontenot@amd.com>, <ackerleytng@google.com>,
<jackyli@google.com>, <pgonda@google.com>, <rientjes@google.com>,
<jacobhxu@google.com>, <xin@zytor.com>,
<pawan.kumar.gupta@linux.intel.com>, <babu.moger@amd.com>,
<dyoung@redhat.com>, <nikunj@amd.com>, <darwi@linutronix.de>,
<linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<kvm@vger.kernel.org>, <linux-coco@lists.linux.dev>
Subject: Re: [PATCH v4 1/2] x86/sev: Clear RMPOPT when segmented RMP is disabled by firmware
Date: Tue, 3 Nov 2026 08:28:07 +0530 [thread overview]
Message-ID: <4543f87c-cd29-4d5c-be8f-eb6b5477f4a1@amd.com> (raw)
In-Reply-To: <20261103004531.GEaukuq9sXbCs_PjfL@fat_crate.local>
On 11/3/2026 6:15 AM, Borislav Petkov wrote:
> diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c
> index bd70c4d0b774..417e6a41ac60 100644
> --- a/arch/x86/virt/svm/sev.c
> +++ b/arch/x86/virt/svm/sev.c
> @@ -669,10 +669,10 @@ void snp_enable_rmpopt(void)
> u64 base;
> int cpu;
>
> - if (!cpu_feature_enabled(X86_FEATURE_RMPOPT))
> + if (!cc_platform_has(CC_ATTR_HOST_SEV_SNP))
> return;
nit. We should check CC_ATTR_HOST_SEV_SNP in rmpopt_init() too
now to prevent an unnecessary workqueue allocation if
probe_segmented_rmptable_info() failed early.
Since it doesn't change anything functionally, maybe Ashish
can do it as a part of his mutil-node optimization series.
>
> - if (!cc_platform_has(CC_ATTR_HOST_SEV_SNP))
> + if (!cpu_feature_enabled(X86_FEATURE_RMPOPT))
> return;
>
> if (!rmpopt_soft_init)
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-11-03 2:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 19:48 [PATCH v4 0/2] x86/sev: Fix RMPOPT enablement on non-RMPOPT configs Ashish Kalra
2026-10-28 19:49 ` [PATCH v4 1/2] x86/sev: Clear RMPOPT when segmented RMP is disabled by firmware Ashish Kalra
2026-10-28 21:51 ` Pankaj Gupta
2026-11-02 5:28 ` Borislav Petkov
2026-11-02 6:12 ` K Prateek Nayak
2026-11-02 7:01 ` Borislav Petkov
2026-11-02 14:12 ` Tom Lendacky
2026-11-02 14:48 ` Borislav Petkov
2026-11-02 15:50 ` Kalra, Ashish
2026-11-02 19:31 ` Borislav Petkov
2026-11-02 20:21 ` Kalra, Ashish
2026-11-03 0:22 ` Borislav Petkov
2026-11-02 21:25 ` Tom Lendacky
2026-11-02 21:43 ` Borislav Petkov
2026-11-03 0:07 ` Kalra, Ashish
2026-11-03 0:45 ` Borislav Petkov
2026-11-03 2:58 ` K Prateek Nayak [this message]
2026-10-28 19:49 ` [PATCH v4 2/2] x86/sev: Set up RMPOPT only on an active SNP host Ashish Kalra
2026-10-28 22:00 ` Gupta, Pankaj
2026-10-29 15:33 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4543f87c-cd29-4d5c-be8f-eb6b5477f4a1@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Michael.Roth@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Tycho.Andersen@amd.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=ardb@kernel.org \
--cc=ashish.kalra@amd.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=jackyli@google.com \
--cc=jacobhxu@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®