* [PATCH] nvmet: fix arbitration burst field mask
@ 2026-10-30 19:18 James Fantin-Hardesty
2026-11-03 5:12 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: James Fantin-Hardesty @ 2026-10-30 19:18 UTC (permalink / raw)
To: linux-nvme
Cc: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni,
Damien Le Moal, linux-kernel, James Fantin-Hardesty
The Arbitration Burst (AB) field of the Arbitration feature is
CDW11 bits 2:0 (NVMe Base Specification 2.1, Feature 01h), but
nvmet incorrectly masks it with 0x3. Use 0x7 for both set and get.
Fixes: a0ed77d4c9a7 ("nvmet: Implement arbitration feature support")
Signed-off-by: James Fantin-Hardesty <james.fantin-hardesty@seagate.com>
---
drivers/nvme/target/admin-cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 26028be8fe4d..6cb59a4f233c 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -1326,7 +1326,7 @@ static u16 nvmet_set_feat_arbitration(struct nvmet_req *req)
.hpw = (cdw11 >> 24) & 0xff,
.mpw = (cdw11 >> 16) & 0xff,
.lpw = (cdw11 >> 8) & 0xff,
- .ab = cdw11 & 0x3,
+ .ab = cdw11 & 0x7,
};
if (!ctrl->ops->set_feature) {
@@ -1481,7 +1481,7 @@ static u16 nvmet_get_feat_arbitration(struct nvmet_req *req)
((u32)arb.hpw << 24) |
((u32)arb.mpw << 16) |
((u32)arb.lpw << 8) |
- (arb.ab & 0x3));
+ (arb.ab & 0x7));
return NVME_SC_SUCCESS;
}
--
2.56.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: fix arbitration burst field mask
2026-10-30 19:18 [PATCH] nvmet: fix arbitration burst field mask James Fantin-Hardesty
@ 2026-11-03 5:12 ` Damien Le Moal
2026-11-03 5:34 ` Christoph Hellwig
2026-11-03 15:35 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2026-11-03 5:12 UTC (permalink / raw)
To: James Fantin-Hardesty, linux-nvme
Cc: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, linux-kernel
On 10/31/26 04:18, James Fantin-Hardesty wrote:
> The Arbitration Burst (AB) field of the Arbitration feature is
> CDW11 bits 2:0 (NVMe Base Specification 2.1, Feature 01h), but
> nvmet incorrectly masks it with 0x3. Use 0x7 for both set and get.
>
> Fixes: a0ed77d4c9a7 ("nvmet: Implement arbitration feature support")
> Signed-off-by: James Fantin-Hardesty <james.fantin-hardesty@seagate.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: fix arbitration burst field mask
2026-10-30 19:18 [PATCH] nvmet: fix arbitration burst field mask James Fantin-Hardesty
2026-11-03 5:12 ` Damien Le Moal
@ 2026-11-03 5:34 ` Christoph Hellwig
2026-11-03 15:35 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2026-11-03 5:34 UTC (permalink / raw)
To: James Fantin-Hardesty
Cc: linux-nvme, Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni,
Damien Le Moal, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: fix arbitration burst field mask
2026-10-30 19:18 [PATCH] nvmet: fix arbitration burst field mask James Fantin-Hardesty
2026-11-03 5:12 ` Damien Le Moal
2026-11-03 5:34 ` Christoph Hellwig
@ 2026-11-03 15:35 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2026-11-03 15:35 UTC (permalink / raw)
To: James Fantin-Hardesty
Cc: linux-nvme, Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni,
Damien Le Moal, linux-kernel
On Fri, Oct 30, 2026 at 01:18:53PM -0600, James Fantin-Hardesty wrote:
> The Arbitration Burst (AB) field of the Arbitration feature is
> CDW11 bits 2:0 (NVMe Base Specification 2.1, Feature 01h), but
> nvmet incorrectly masks it with 0x3. Use 0x7 for both set and get.
Thanks, applied to nvme-7.4.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-03 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-30 19:18 [PATCH] nvmet: fix arbitration burst field mask James Fantin-Hardesty
2026-11-03 5:12 ` Damien Le Moal
2026-11-03 5:34 ` Christoph Hellwig
2026-11-03 15:35 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®