Re: [PATCH 1/2] dt-bindings: pinctrl: Add Siflower SF19A2890 pin controller

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4548 bytes --]

On Wed, Nov 04, 2026 at 02:21:17AM -0500, Joseph Telaak via B4 Relay wrote:
> From: Joseph Telaak <joseph@telaak.dev>
> 
> The pin controller of the Siflower SF19A2890 selects the function of
> each of its 49 pins and sets their bias, input enable, Schmitt trigger
> and drive strength. Each pin has a register pair of its own, and each
> pin state node holds subnodes that set some of its pins.
> 
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>
> ---
>  .../pinctrl/siflower,sf19a2890-pinctrl.yaml        | 113 +++++++++++++++++++++
>  1 file changed, 113 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/siflower,sf19a2890-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/siflower,sf19a2890-pinctrl.yaml
> new file mode 100644
> index 000000000..8b52d3175
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/siflower,sf19a2890-pinctrl.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/siflower,sf19a2890-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Siflower SF19A2890 pin controller
> +
> +maintainers:
> +  - Joseph Telaak <joseph@telaak.dev>
> +
> +description:
> +  The pin controller of the Siflower SF19A2890 selects the function of
> +  each of its 49 pins and sets their bias, input enable, Schmitt trigger
> +  and drive strength. The GPIO function is selected through the GPIO
> +  controller, which maps its lines onto these pins with gpio-ranges.
> +
> +properties:
> +  compatible:
> +    const: siflower,sf19a2890-pinctrl
> +
> +  reg:
> +    maxItems: 1
> +
> +patternProperties:
> +  '-pins$':
> +    type: object
> +    description:
> +      A pin state. Each subnode sets the function and configuration of
> +      some of its pins.
> +
> +    patternProperties:
> +      '^pins(-[a-z0-9]+)*$':
> +        type: object

> +        $ref: /schemas/pinctrl/pincfg-node.yaml#
> +        allOf:
> +          - $ref: /schemas/pinctrl/pinmux-node.yaml#

Same format should be used for both of these.

> +        properties:
> +          pins:
> +            items:
> +              enum: [JTAG_TDO, JTAG_TDI, JTAG_TMS, JTAG_TCK, JTAG_RST,
> +                     SPI_TXD, SPI_RXD, SPI_CLK, SPI_CSN, UART_TX, UART_RX,
> +                     I2C_DAT, I2C_CLK, RGMII_GTX_CLK, RGMII_TXCLK,
> +                     RGMII_TXD0, RGMII_TXD1, RGMII_TXD2, RGMII_TXD3,
> +                     RGMII_TXCTL, RGMII_RXCLK, RGMII_RXD0, RGMII_RXD1,
> +                     RGMII_RXD2, RGMII_RXD3, RGMII_RXCTL, RGMII_COL,
> +                     RGMII_CRS, RGMII_MDC, RGMII_MDIO, HB0_PA_EN,
> +                     HB0_LNA_EN, HB0_SW_CTRL0, HB0_SW_CTRL1, HB1_PA_EN,
> +                     HB1_LNA_EN, HB1_SW_CTRL0, HB1_SW_CTRL1, LB0_PA_EN,
> +                     LB0_LNA_EN, LB0_SW_CTRL0, LB0_SW_CTRL1, LB1_PA_EN,
> +                     LB1_LNA_EN, LB1_SW_CTRL0, LB1_SW_CTRL1, CLK_OUT,
> +                     EXT_CLK_IN, DRVVBUS0]
> +            minItems: 1
> +            maxItems: 49
> +
> +          function:
> +            enum: [i2c0, jtag, mdio, pwm0, pwm1, rgmii, spi, uart0, uart1,
> +                   uart2, wlan]
> +
> +          bias-disable: true
> +
> +          bias-pull-up: true
> +
> +          bias-pull-down: true
> +
> +          input-enable: true
> +
> +          input-schmitt-enable: true
> +
> +          input-schmitt-disable: true
> +
> +          drive-strength:
> +            description: Output drive strength in mA.
> +            enum: [6, 9, 12, 15, 18, 21, 24, 27]
> +
> +        required:
> +          - pins
> +
> +        additionalProperties: false
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: pinctrl.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pinctrl@19e3fc00 {
> +        compatible = "siflower,sf19a2890-pinctrl";
> +        reg = <0x19e3fc00 0x400>;
> +
> +        uart0-pins {
> +            pins-tx {
> +                pins = "UART_TX";
> +                function = "uart0";
> +                bias-pull-up;
> +            };
> +
> +            pins-rx {
> +                pins = "UART_RX";
> +                function = "uart0";
> +                input-enable;
> +                bias-pull-up;
> +            };
> +        };
> +    };
> 
> -- 
> Git-155)
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]