From: Conor Dooley <conor@kernel.org>
To: Joseph Telaak <joseph@telaak.dev>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver
Date: Thu, 5 Nov 2026 01:35:10 +0000 [thread overview]
Message-ID: <20261105-cilantro-neglector-a4cdaf9bfb2d@spud> (raw)
In-Reply-To: <CAPY4CJ5pBrypa1PKaKRPxb9uvaJBor+FzUXY0+gxLHOUy7W-Ow@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, Nov 04, 2026 at 07:54:25PM -0500, Joseph Telaak wrote:
> > Can you just use pinctrl_generic_pins_function_dt_node_to_map here and
> > dynamically create the groups at runtime (and also make use of the
> > generic get_groups_* implementations)?
>
> Yes, I'll switch to them in v2. One consequence first: the helper reads
> "pins" as pin numbers, so the binding's pins would change from names
> like "UART_TX" to numbers, as in microchip,mpfs-pinctrl-mssio. The
> function names stay as they are. Is that change fine with you?
huh, I totally forgot about that. I guess you don't have to do this if
you don't want to so. I think all the generic stuff expects pins to be
numeric.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-11-05 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:21 [PATCH 0/2] pinctrl: Add the Siflower SF19A2890 pin controller Joseph Telaak via B4 Relay
2026-11-04 7:21 ` [PATCH 1/2] dt-bindings: pinctrl: Add " Joseph Telaak via B4 Relay
2026-11-04 23:49 ` Conor Dooley
2026-11-05 0:45 ` Joseph Telaak
2026-11-04 7:21 ` [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver Joseph Telaak via B4 Relay
2026-11-04 23:54 ` Conor Dooley
2026-11-05 0:54 ` Joseph Telaak
2026-11-05 1:35 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105-cilantro-neglector-a4cdaf9bfb2d@spud \
--to=conor@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®