* [PATCH] staging: sm750fb: make g_fbmode constant array
@ 2026-11-05 21:13 Francesco Giandinoto
2026-11-06 0:21 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Francesco Giandinoto @ 2026-11-05 21:13 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Francesco Giandinoto, Teddy Wang, Greg Kroah-Hartman,
open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER,
open list:STAGING SUBSYSTEM, open list
The g_fbmode variable is used as an array of constant string pointers. Add the missing const qualifier to clean up the source code and adhere to kernel coding standards
Signed-off-by: Francesco Giandinoto <testata.nucleare13@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 21e310274..47d2917cc 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -12,7 +12,7 @@
static int g_hwcursor = 1;
static int g_noaccel __ro_after_init;
static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char * const g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview __ro_after_init;
--
2.56.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: make g_fbmode constant array
2026-11-05 21:13 [PATCH] staging: sm750fb: make g_fbmode constant array Francesco Giandinoto
@ 2026-11-06 0:21 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-11-06 0:21 UTC (permalink / raw)
To: Francesco Giandinoto, Sudip Mukherjee
Cc: Teddy Wang, Greg Kroah-Hartman,
open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER,
open list:STAGING SUBSYSTEM, open list
On Thu Nov 5, 2026 at 3:13 PM CST, Francesco Giandinoto wrote:
> The g_fbmode variable is used as an array of constant string pointers. Add the missing const qualifier to clean up the source code and adhere to kernel coding standards
This doesn't compile. Also, please keep log messages at 75 characters
per line.
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-06 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-05 21:13 [PATCH] staging: sm750fb: make g_fbmode constant array Francesco Giandinoto
2026-11-06 0:21 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®