Re: [PATCH 13/25] dt-bindings: usb: dwc2: add Metanoia MT2824

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Nov 06, 2026 at 10:30:10AM +0100, Benoît Monin wrote:
> Document the metanoia,mt2824-usb compatible, which falls back to the
> generic snps,dwc2 binding, so that the DWC2 USB controller on the Metanoia
> MT2824 SoC can be described in device trees.

This is completely redundant commit msg. You repeat subject and diff, so
obvious things, while completely skipping non-obvious part - why do you
thing they are compatible.

> 
> Originally-by: Jun Chang <jun.chang@metanoia-comm.com>

Please drop (or read submitting patches if you need other tags)

> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 6c3a10991b8b..898c83e57843 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -55,6 +55,7 @@ properties:
>                - amlogic,meson-g12a-usb
>                - amlogic,meson-a1-usb
>                - intel,socfpga-agilex-hsotg
> +              - metanoia,mt2824-usb
>            - const: snps,dwc2

Is it then compatible with DWC2? Your driver code suggests not.

>        - const: amcc,dwc-otg
>        - const: apm,apm82181-dwc-otg
> 
> -- 
> 2.56.0
>