* [PATCH ath-next 1/2] wifi: ath12k: Fix HE BA mode configuration for AP mode
2026-11-06 4:57 [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Rameshkumar Sundaram
@ 2026-11-06 4:57 ` Rameshkumar Sundaram
2026-11-06 4:57 ` [PATCH ath-next 2/2] wifi: ath12k: Extend BA buffer size to 1024 for EHT capable links Rameshkumar Sundaram
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Rameshkumar Sundaram @ 2026-11-06 4:57 UTC (permalink / raw)
To: Jeff Johnson, Vasanthakumar Thiagarajan, Baochen Qiang
Cc: linux-wireless, ath12k, linux-kernel, Rameshkumar Sundaram
WMI_VDEV_PARAM_BA_MODE is currently configured inside the he_oper.params
check. However, mac80211 does not populate he_oper.params for AP mode,
causing the BA mode configuration to be skipped for HE AP operation.
Move the BA mode configuration outside the he_oper.params check so that
it is applied whenever HE support is enabled.
Without this change, firmware defaults to a BA buffer size of 64
(legacy mode) for HE associations.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 4f16c78b52a8..711acb32a6ca 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -4888,8 +4888,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar,
}
ath12k_control_beaconing(arvif, info);
- if (arvif->is_up && info->he_support &&
- info->he_oper.params) {
+ if (arvif->is_up && info->he_support) {
/* TODO: Extend to support 1024 BA Bitmap size */
ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
WMI_VDEV_PARAM_BA_MODE,
@@ -4899,17 +4898,21 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar,
"failed to set BA BUFFER SIZE 256 for vdev: %d\n",
arvif->vdev_id);
- param_id = WMI_VDEV_PARAM_HEOPS_0_31;
- param_value = info->he_oper.params;
- ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
- param_id, param_value);
- ath12k_dbg(ar->ab, ATH12K_DBG_MAC,
- "he oper param: %x set for VDEV: %d\n",
- param_value, arvif->vdev_id);
+ if (info->he_oper.params) {
+ param_id = WMI_VDEV_PARAM_HEOPS_0_31;
+ param_value = info->he_oper.params;
- if (ret)
- ath12k_warn(ar->ab, "Failed to set he oper params %x for VDEV %d: %i\n",
- param_value, arvif->vdev_id, ret);
+ ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
+ param_id,
+ param_value);
+ ath12k_dbg(ar->ab, ATH12K_DBG_MAC,
+ "he oper param: %x set for VDEV: %d\n",
+ param_value, arvif->vdev_id);
+
+ if (ret)
+ ath12k_warn(ar->ab, "Failed to set he oper params %x for VDEV %d: %i\n",
+ param_value, arvif->vdev_id, ret);
+ }
}
}
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH ath-next 2/2] wifi: ath12k: Extend BA buffer size to 1024 for EHT capable links
2026-11-06 4:57 [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Rameshkumar Sundaram
2026-11-06 4:57 ` [PATCH ath-next 1/2] wifi: ath12k: Fix HE BA mode configuration for AP mode Rameshkumar Sundaram
@ 2026-11-06 4:57 ` Rameshkumar Sundaram
2026-11-06 5:20 ` [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Baochen Qiang
2026-11-06 5:27 ` Vasanthakumar Thiagarajan
3 siblings, 0 replies; 5+ messages in thread
From: Rameshkumar Sundaram @ 2026-11-06 4:57 UTC (permalink / raw)
To: Jeff Johnson, Vasanthakumar Thiagarajan, Baochen Qiang
Cc: linux-wireless, ath12k, linux-kernel, Rameshkumar Sundaram,
Paulson Raja L
From: Paulson Raja L <lraja@qti.qualcomm.com>
IEEE 802.11be (EHT) extends the maximum BA buffer size from 256 MPDUs
(HE) to 1024 MPDUs. EHT-capable links are currently limited to the
HE maximum of 256.
Add WMI_BA_MODE_BUFFER_SIZE_1024 and select the buffer size based on
the negotiated mode: 1024 for EHT-capable links, 256 for HE-only.
Also include the return code when reporting BA mode configuration
failure to aid debugging.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Signed-off-by: Paulson Raja L <lraja@qti.qualcomm.com>
Signed-off-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 14 +++++++++-----
drivers/net/wireless/ath/ath12k/wmi.h | 1 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 711acb32a6ca..0ad019fd4918 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -4889,14 +4889,18 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar,
ath12k_control_beaconing(arvif, info);
if (arvif->is_up && info->he_support) {
- /* TODO: Extend to support 1024 BA Bitmap size */
+ param_id = WMI_VDEV_PARAM_BA_MODE;
+ param_value = info->eht_support ?
+ WMI_BA_MODE_BUFFER_SIZE_1024 :
+ WMI_BA_MODE_BUFFER_SIZE_256;
+
ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id,
- WMI_VDEV_PARAM_BA_MODE,
- WMI_BA_MODE_BUFFER_SIZE_256);
+ param_id, param_value);
if (ret)
ath12k_warn(ar->ab,
- "failed to set BA BUFFER SIZE 256 for vdev: %d\n",
- arvif->vdev_id);
+ "failed to set BA BUFFER SIZE %u for vdev %d: %d\n",
+ info->eht_support ? 1024 : 256,
+ arvif->vdev_id, ret);
if (info->he_oper.params) {
param_id = WMI_VDEV_PARAM_HEOPS_0_31;
diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index 5d0afbf0bd0c..78f1ceaaf5ff 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -171,6 +171,7 @@ struct wmi_tlv {
#define WMI_APPEND_TO_EXISTING_CHAN_LIST_FLAG 1
#define WMI_BA_MODE_BUFFER_SIZE_256 3
+#define WMI_BA_MODE_BUFFER_SIZE_1024 6
/* HW mode config type replicated from FW header
* @WMI_HOST_HW_MODE_SINGLE: Only one PHY is active.
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT
2026-11-06 4:57 [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Rameshkumar Sundaram
2026-11-06 4:57 ` [PATCH ath-next 1/2] wifi: ath12k: Fix HE BA mode configuration for AP mode Rameshkumar Sundaram
2026-11-06 4:57 ` [PATCH ath-next 2/2] wifi: ath12k: Extend BA buffer size to 1024 for EHT capable links Rameshkumar Sundaram
@ 2026-11-06 5:20 ` Baochen Qiang
2026-11-06 5:27 ` Vasanthakumar Thiagarajan
3 siblings, 0 replies; 5+ messages in thread
From: Baochen Qiang @ 2026-11-06 5:20 UTC (permalink / raw)
To: Rameshkumar Sundaram, Jeff Johnson, Vasanthakumar Thiagarajan
Cc: linux-wireless, ath12k, linux-kernel, Paulson Raja L
On 11/6/2026 12:57 PM, Rameshkumar Sundaram wrote:
> This series addresses two related issues with Block Acknowledgement (BA)
> configuration for HE and EHT capable links.
>
> Patch 1 fixes a bug where WMI_VDEV_PARAM_BA_MODE was never configured
> for HE in AP mode. The existing code placed the BA mode configuration
> inside the he_oper.params check, but mac80211 does not populate
> he_oper.params for AP mode, so HE AP links never had BA mode set.
>
> Patch 2 builds on the fix by enabling 1024-entry BA buffers for EHT
> capable links. IEEE 802.11be extends the maximum BA buffer size from 256
> (HE) to 1024 MPDUs; without this patch, EHT-capable links were limited
> to 256.
>
> Signed-off-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
> ---
> Paulson Raja L (1):
> wifi: ath12k: Extend BA buffer size to 1024 for EHT capable links
>
> Rameshkumar Sundaram (1):
> wifi: ath12k: Fix HE BA mode configuration for AP mode
>
> drivers/net/wireless/ath/ath12k/mac.c | 41 ++++++++++++++++++++---------------
> drivers/net/wireless/ath/ath12k/wmi.h | 1 +
> 2 files changed, 25 insertions(+), 17 deletions(-)
> ---
> base-commit: b9acb873d035fccc8824164246535ea6fc95c71a
> change-id: 20261106-eht-ba-window-5c2df1a8e910
>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT
2026-11-06 4:57 [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Rameshkumar Sundaram
` (2 preceding siblings ...)
2026-11-06 5:20 ` [PATCH ath-next 0/2] wifi: ath12k: Fix HE BA mode and extend buffer size for EHT Baochen Qiang
@ 2026-11-06 5:27 ` Vasanthakumar Thiagarajan
3 siblings, 0 replies; 5+ messages in thread
From: Vasanthakumar Thiagarajan @ 2026-11-06 5:27 UTC (permalink / raw)
To: Rameshkumar Sundaram, Jeff Johnson, Baochen Qiang
Cc: linux-wireless, ath12k, linux-kernel, Paulson Raja L
On 06-11-2026 10:27, Rameshkumar Sundaram wrote:
> This series addresses two related issues with Block Acknowledgement (BA)
> configuration for HE and EHT capable links.
>
> Patch 1 fixes a bug where WMI_VDEV_PARAM_BA_MODE was never configured
> for HE in AP mode. The existing code placed the BA mode configuration
> inside the he_oper.params check, but mac80211 does not populate
> he_oper.params for AP mode, so HE AP links never had BA mode set.
>
> Patch 2 builds on the fix by enabling 1024-entry BA buffers for EHT
> capable links. IEEE 802.11be extends the maximum BA buffer size from 256
> (HE) to 1024 MPDUs; without this patch, EHT-capable links were limited
> to 256.
>
> Signed-off-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
> ---
> Paulson Raja L (1):
> wifi: ath12k: Extend BA buffer size to 1024 for EHT capable links
>
> Rameshkumar Sundaram (1):
> wifi: ath12k: Fix HE BA mode configuration for AP mode
>
> drivers/net/wireless/ath/ath12k/mac.c | 41 ++++++++++++++++++++---------------
> drivers/net/wireless/ath/ath12k/wmi.h | 1 +
> 2 files changed, 25 insertions(+), 17 deletions(-)
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread