mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomasz Bojanowski <tomasz@bojanowski.me>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: Add driver for MSI Mystic Light controller voltage sensors
Date: Sat,  7 Nov 2026 22:47:38 +0100	[thread overview]
Message-ID: <20261107214738.439967-1-tomasz@bojanowski.me> (raw)
In-Reply-To: <81c1e042-b06c-4a13-9251-a967532e21cd@roeck-us.net>

Hi Guenter,

On 11/7/26 13:06, Guenter Roeck wrote:
> Either case, do you have evidence that this is even needed in the
> first place ?

No. On the MS-7E61 it is not needed: the controller does not support
remote wakeup, and while hid_hw_open() holds the device open, it does
not autosuspend (runtime_status stayed active with power/control set
to auto). I added it in v2 only as a precaution, in case the device
autosuspends while the feature report is requested, without evidence
that this can happen. I think it can be dropped.

> That makes me wonder if the vendor software is buggy. I have
> two of those boards, and they both show similar values.

My follow-up crossed with your mail: the vendor software only lists
CPU VDDP on the MS-7C94 with an APU. Do your boards have CPUs without
integrated graphics?

Thanks,
Tomasz

  reply	other threads:[~2026-11-07 21:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  8:28 Tomasz Bojanowski
2026-11-07 15:56 ` Guenter Roeck
2026-11-07 16:12   ` Tomasz Bojanowski
2026-11-07 18:02     ` Guenter Roeck
2026-11-07 18:15       ` Tomasz Bojanowski
2026-11-07 19:40         ` Guenter Roeck
2026-11-07 20:33           ` Tomasz Bojanowski
2026-11-07 20:54             ` Tomasz Bojanowski
2026-11-07 21:06             ` Guenter Roeck
2026-11-07 21:47               ` Tomasz Bojanowski [this message]
2026-11-07 22:05                 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107214738.439967-1-tomasz@bojanowski.me \
    --to=tomasz@bojanowski.me \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®