From: Guenter Roeck <linux@roeck-us.net>
To: Tomasz Bojanowski <tomasz@bojanowski.me>
Cc: linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: Add driver for MSI Mystic Light controller voltage sensors
Date: Sat, 7 Nov 2026 14:05:46 -0800 [thread overview]
Message-ID: <6870d51e-8d71-4cd7-bf43-3e3a1ea89ef3@roeck-us.net> (raw)
In-Reply-To: <20261107214738.439967-1-tomasz@bojanowski.me>
On 11/7/26 13:47, Tomasz Bojanowski wrote:
> Hi Guenter,
>
> On 11/7/26 13:06, Guenter Roeck wrote:
>> Either case, do you have evidence that this is even needed in the
>> first place ?
>
> No. On the MS-7E61 it is not needed: the controller does not support
> remote wakeup, and while hid_hw_open() holds the device open, it does
> not autosuspend (runtime_status stayed active with power/control set
> to auto). I added it in v2 only as a precaution, in case the device
> autosuspends while the feature report is requested, without evidence
> that this can happen. I think it can be dropped.
>
Ok, I'll do that.
>> That makes me wonder if the vendor software is buggy. I have
>> two of those boards, and they both show similar values.
>
> My follow-up crossed with your mail: the vendor software only lists
> CPU VDDP on the MS-7C94 with an APU. Do your boards have CPUs without
> integrated graphics?
>
Interesting. Yes, the CPUs on those boards don't have integrated graphics.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-07 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 8:28 Tomasz Bojanowski
2026-11-07 15:56 ` Guenter Roeck
2026-11-07 16:12 ` Tomasz Bojanowski
2026-11-07 18:02 ` Guenter Roeck
2026-11-07 18:15 ` Tomasz Bojanowski
2026-11-07 19:40 ` Guenter Roeck
2026-11-07 20:33 ` Tomasz Bojanowski
2026-11-07 20:54 ` Tomasz Bojanowski
2026-11-07 21:06 ` Guenter Roeck
2026-11-07 21:47 ` Tomasz Bojanowski
2026-11-07 22:05 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6870d51e-8d71-4cd7-bf43-3e3a1ea89ef3@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tomasz@bojanowski.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®