mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Tomasz Bojanowski <tomasz@bojanowski.me>
Cc: linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: Add driver for MSI Mystic Light controller voltage sensors
Date: Sat, 7 Nov 2026 13:06:55 -0800	[thread overview]
Message-ID: <81c1e042-b06c-4a13-9251-a967532e21cd@roeck-us.net> (raw)
In-Reply-To: <20261107203300.427273-1-tomasz@bojanowski.me>

On 11/7/26 12:33, Tomasz Bojanowski wrote:
> Hi Guenter,
> 
> On 11/7/26 11:40, Guenter Roeck wrote:
>> Please let me know if the code still works for you.
> 
> It does. With commit 64e4888, the MS-7E61 reads the same as with v2
> (CPU 1P8 1.79 V, CHIP Core 1.04 V, VDD MISC 1.10 V).
> 
>> Offset 11 does not seem to show a valid voltage. On the other side,
>> offset 15 would reflect a value that at least makes sense.
> 
> The vendor software reads CPU VDDP from offset 11 on the MS-7C94 and
> does not use offset 15. It would show the same 0.002 V, so I cannot
> tell what offset 15 is.
> 

That makes me wonder if the vendor software is buggy. I have
two of those boards, and they both show similar values. If we can't
figure that out, I am inclined to drop support for that board:
It is not worth the trouble with people complaining that it does
not work.

> One small thing: if the read fails, msi_ml_read_report() returns
> without hid_hw_power(..., PM_HINT_NORMAL).
> 

Good point. I wonder what the best way to handle this might be:
Push it back into the device specific read function, or always
call it from the common read function. Or maybe only keep it for
the 7e61 board and assume that it isn't needed for the older boards
since they are expected to send raw events. Any thoughts ?

Either case, do you have evidence that this is even needed in the
first place ? The call is rarely used elsewhere in the kernel,
and none of the other HID hwmon drivers uses it.

Thanks,
Guenter


  parent reply	other threads:[~2026-11-07 21:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  8:28 Tomasz Bojanowski
2026-11-07 15:56 ` Guenter Roeck
2026-11-07 16:12   ` Tomasz Bojanowski
2026-11-07 18:02     ` Guenter Roeck
2026-11-07 18:15       ` Tomasz Bojanowski
2026-11-07 19:40         ` Guenter Roeck
2026-11-07 20:33           ` Tomasz Bojanowski
2026-11-07 20:54             ` Tomasz Bojanowski
2026-11-07 21:06             ` Guenter Roeck [this message]
2026-11-07 21:47               ` Tomasz Bojanowski
2026-11-07 22:05                 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81c1e042-b06c-4a13-9251-a967532e21cd@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tomasz@bojanowski.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®