mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	perex@perex.cz, tiwai@suse.com, tiwai@suse.de
Subject: Re: [PATCH v5] ALSA: control: Fix parsing of numeric fields
Date: Tue, 10 Nov 2026 11:27:40 +0100	[thread overview]
Message-ID: <871p8tvv4z.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261109163531.2639-1-sreekuttan2156239@gmail.com>

On Mon, 09 Nov 2026 17:35:31 +0100,
Sreeraj S Kurup wrote:
> 
> parse_uint() passes the remaining input string to kstrtoull().
> 
> When the input contains comma-separated fields, the string
> contains both the numeric value and the following fields.
> 
> For example, with:
> 
> device=1,subdevice=0,name=Master
> 
> kstrtoull() receives "1,subdevice=0,name=Master" and fails
> to parse the numeric value.
> 
> Stop parsing at the next comma and pass only the numeric
> field to kstrtouint().
> 
> Make all parse_*() functions return the end of the current
> substring, leaving delimiter handling to set_led_id().
> Temporarily terminate the numeric substring in parse_uint()
> before calling kstrtouint().
> 
> This allows numeric fields to be parsed correctly in
> comma-separated input.
> 
> Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking layer")
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

Applied to for-next branch now.  Thanks.


Takashi

      reply	other threads:[~2026-11-10 10:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:45 [PATCH] " Sreeraj S Kurup
2026-11-06 16:23 ` [PATCH v2] " Sreeraj S Kurup
2026-11-08  9:54   ` Sreeraj S Kurup
2026-11-08 10:44     ` Takashi Iwai
2026-11-08 11:18       ` Sreeraj S Kurup
2026-11-08 12:06         ` Takashi Iwai
2026-11-08 12:47           ` Sreeraj S Kurup
2026-11-08 12:48           ` [PATCH v3] " Sreeraj S Kurup
2026-11-08 16:48             ` Manuel Ebner
2026-11-09 14:33             ` Takashi Iwai
2026-11-09 15:58               ` Sreeraj S Kurup
2026-11-09 15:59             ` [PATCH v4] " Sreeraj S Kurup
2026-11-09 16:35             ` [PATCH v5] " Sreeraj S Kurup
2026-11-10 10:27               ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871p8tvv4z.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sreekuttan2156239@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®