From: Jonathan Cameron <jic23@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Lee Jones" <lee@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v1 1/4] regulator: dt-bindings: maxim,max8907: Document io-channel-cells property
Date: Sun, 8 Nov 2026 20:46:53 +0000 [thread overview]
Message-ID: <20261108204654.2fe19afb@jic23-hlaptop> (raw)
In-Reply-To: <20261108095634.100517-2-clamor95@gmail.com>
On Sun, 8 Nov 2026 11:56:31 +0200
Svyatoslav Ryhel <clamor95@gmail.com> wrote:
> The Maxim MAX8907 has a built-in 8-channel ADC. It does not require any
> Device Tree (DT) based configuration and is folded into the main PMIC
> node. Document this behavior.
The actual addition here is to allow other devices in DT to consume
the channels. There is nothing stopping you having an ADC driver
without that which would need nothing at all in DT.
So this patch description is not accurate. The actual change is fine.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> Documentation/devicetree/bindings/regulator/maxim,max8907.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> index ee1a305d1c210..ccdeb9ba21e26 100644
> --- a/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8907.yaml
> @@ -27,6 +27,9 @@ properties:
>
> system-power-controller: true
>
> + "#io-channel-cells":
> + const: 1
> +
> mbatt-supply:
> description:
> The input supply for MBATT, BBAT, SDBY, VRTC.
next prev parent reply other threads:[~2026-11-08 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 9:56 [PATCH v1 0/4] iio: adc: Add support for MAX8907 ADC cell Svyatoslav Ryhel
2026-11-08 9:56 ` [PATCH v1 1/4] regulator: dt-bindings: maxim,max8907: Document io-channel-cells property Svyatoslav Ryhel
2026-11-08 10:40 ` Mark Brown
2026-11-08 20:46 ` Jonathan Cameron [this message]
2026-11-08 9:56 ` [PATCH v1 2/4] mfd: max8907: Add ADC client support Svyatoslav Ryhel
2026-11-08 20:51 ` Jonathan Cameron
2026-11-08 9:56 ` [PATCH v1 3/4] iio: adc: Add support for MAX8907 ADC cell Svyatoslav Ryhel
2026-11-08 9:56 ` [PATCH v1 4/4] mfd: max8907: Add " Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108204654.2fe19afb@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®