From: Agustin Santiago Isasmendi <isasmendi.agus@gmail.com>
To: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Stefan Dösinger" <stefandoesinger@gmail.com>,
"Navid Ghahremani" <ghahramani.navid@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: [PATCH 1/2] ARM: l2c: factor out the number of ways
Date: Wed, 11 Nov 2026 14:39:29 +0100 [thread overview]
Message-ID: <20261111133930.3665251-2-isasmendi.agus@gmail.com> (raw)
In-Reply-To: <20261111133930.3665251-1-isasmendi.agus@gmail.com>
__l2c_init() derives the number of ways from the cache ID and the
auxiliary control register. Move that into l2c_num_ways() so that the
next patch can use it before the cache is initialised. No functional
change.
Assisted-by: LLM
Signed-off-by: Agustin Santiago Isasmendi <isasmendi.agus@gmail.com>
---
arch/arm/mm/cache-l2x0.c | 50 +++++++++++++++++++---------------------
1 file changed, 24 insertions(+), 26 deletions(-)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 470867160076..eaa1fb44886e 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -778,6 +778,26 @@ static const struct l2c_init_data l2c310_init_fns __initconst = {
},
};
+/* Number of ways, from the cache ID and the auxiliary control register */
+static unsigned int __init l2c_num_ways(u32 cache_id, u32 aux)
+{
+ switch (cache_id & L2X0_CACHE_ID_PART_MASK) {
+ case L2X0_CACHE_ID_PART_L310:
+ return aux & L310_AUX_CTRL_ASSOCIATIVITY_16 ? 16 : 8;
+
+ case L2X0_CACHE_ID_PART_L210:
+ case L2X0_CACHE_ID_PART_L220:
+ return (aux >> 13) & 0xf;
+
+ case AURORA_CACHE_ID:
+ return 2 << ((((aux >> 13) & 0xf) + 1) >> 2);
+
+ default:
+ /* Assume unknown chips have 8 ways */
+ return 8;
+ }
+}
+
static int __init __l2c_init(const struct l2c_init_data *data,
u32 aux_val, u32 aux_mask, u32 cache_id, bool nosync)
{
@@ -809,33 +829,11 @@ static int __init __l2c_init(const struct l2c_init_data *data,
pr_warn("L2C: DT/platform modifies aux control register: 0x%08x -> 0x%08x\n",
old_aux, aux);
- /* Determine the number of ways */
- switch (cache_id & L2X0_CACHE_ID_PART_MASK) {
- case L2X0_CACHE_ID_PART_L310:
- if ((aux_val | ~aux_mask) & (L2C_AUX_CTRL_WAY_SIZE_MASK | L310_AUX_CTRL_ASSOCIATIVITY_16))
- pr_warn("L2C: DT/platform tries to modify or specify cache size\n");
- if (aux & (1 << 16))
- ways = 16;
- else
- ways = 8;
- break;
-
- case L2X0_CACHE_ID_PART_L210:
- case L2X0_CACHE_ID_PART_L220:
- ways = (aux >> 13) & 0xf;
- break;
-
- case AURORA_CACHE_ID:
- ways = (aux >> 13) & 0xf;
- ways = 2 << ((ways + 1) >> 2);
- break;
-
- default:
- /* Assume unknown chips have 8 ways */
- ways = 8;
- break;
- }
+ if ((cache_id & L2X0_CACHE_ID_PART_MASK) == L2X0_CACHE_ID_PART_L310 &&
+ (aux_val | ~aux_mask) & (L2C_AUX_CTRL_WAY_SIZE_MASK | L310_AUX_CTRL_ASSOCIATIVITY_16))
+ pr_warn("L2C: DT/platform tries to modify or specify cache size\n");
+ ways = l2c_num_ways(cache_id, aux);
l2x0_way_mask = (1 << ways) - 1;
/*
--
2.30.2
next prev parent reply other threads:[~2026-11-11 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 13:39 [PATCH 0/2] ARM: l2c: honour status = "disabled" on the L2 cache node Agustin Santiago Isasmendi
2026-11-11 13:39 ` Agustin Santiago Isasmendi [this message]
2026-11-11 14:24 ` [PATCH 1/2] ARM: l2c: factor out the number of ways Arnd Bergmann
2026-11-11 13:39 ` [PATCH 2/2] ARM: l2c: honour status = "disabled" on the L2 cache node Agustin Santiago Isasmendi
2026-11-11 13:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111133930.3665251-2-isasmendi.agus@gmail.com \
--to=isasmendi.agus@gmail.com \
--cc=arnd@arndb.de \
--cc=ghahramani.navid@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stefandoesinger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®