From: Agustin Santiago Isasmendi <isasmendi.agus@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Stefan Dösinger" <stefandoesinger@gmail.com>,
"Navid Ghahremani" <ghahramani.navid@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: Re: [PATCH 2/2] ARM: l2c: honour status = "disabled" on the L2 cache node
Date: Wed, 11 Nov 2026 16:17:07 +0100 [thread overview]
Message-ID: <20261111151707.2253768-1-isasmendi.agus@gmail.com> (raw)
In-Reply-To: <49846243-34ae-4643-9b39-1537947fbd96@app.fastmail.com>
On Wed, Nov 11, 2026 at 14:56, Arnd Bergmann wrote:
> It is a little strange to use the MMIO registers of a status="disabled"
> device to turn it off, and it would be nice if we could require
> the firmware to leave it in a consistent state instead, but I assume
> you can't do that for the one device you are interested in because
> you don't have the firmware sources, right?
On the H3600 the firmware leaves it off (control register 0 at kernel
entry, cold and warm; the bootloader never touches the controller), so
this board only needs the early return. To be honest I also prefer
the firmware to be responsible for leaving the cache off when the
device tree disables it; I went the conservative way for a firmware I
do not control.
If you agree, v2 drops the disable path and patch 1, keeps just the
early return, and adds a line to the binding saying so. Otherwise I
keep the check and add the comment.
Agustin
next prev parent reply other threads:[~2026-11-11 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 13:39 [PATCH 0/2] " Agustin Santiago Isasmendi
2026-11-11 13:39 ` [PATCH 1/2] ARM: l2c: factor out the number of ways Agustin Santiago Isasmendi
2026-11-11 14:24 ` Arnd Bergmann
2026-11-11 13:39 ` [PATCH 2/2] ARM: l2c: honour status = "disabled" on the L2 cache node Agustin Santiago Isasmendi
2026-11-11 13:56 ` Arnd Bergmann
2026-11-11 15:17 ` Agustin Santiago Isasmendi [this message]
2026-11-11 15:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111151707.2253768-1-isasmendi.agus@gmail.com \
--to=isasmendi.agus@gmail.com \
--cc=arnd@arndb.de \
--cc=ghahramani.navid@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=stefandoesinger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®