* [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches()
@ 2026-11-12 14:46 Sang-Heon Jeon
2026-11-12 15:00 ` Vlastimil Babka (SUSE)
2026-11-12 15:06 ` Harry Yoo (Meta)
0 siblings, 2 replies; 3+ messages in thread
From: Sang-Heon Jeon @ 2026-11-12 14:46 UTC (permalink / raw)
To: Vlastimil Babka, Harry Yoo, Andrew Morton
Cc: Christoph Lameter, David Rientjes, Hao Li, linux-kernel,
linux-mm, Roman Gushchin
Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
So remove the outdated and redundant comment.
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
Changes from v1 [1]
- Remove the whole useless comment
[1] https://lore.kernel.org/all/20261104144753.2266231-1-ekffu200098@gmail.com/
---
mm/slab_common.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 01c64ef661e7..10603b9cbb53 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
}
-/*
- * Create the kmalloc array. Some of the regular kmalloc arrays
- * may already have been created because they were needed to
- * enable allocations for slab creation.
- */
void __init create_kmalloc_caches(void)
{
int i;
base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches()
2026-11-12 14:46 [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches() Sang-Heon Jeon
@ 2026-11-12 15:00 ` Vlastimil Babka (SUSE)
2026-11-12 15:06 ` Harry Yoo (Meta)
1 sibling, 0 replies; 3+ messages in thread
From: Vlastimil Babka (SUSE) @ 2026-11-12 15:00 UTC (permalink / raw)
To: Sang-Heon Jeon, Harry Yoo, Andrew Morton
Cc: Christoph Lameter, David Rientjes, Hao Li, linux-kernel,
linux-mm, Roman Gushchin
On 11/12/26 15:46, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
>
> So remove the outdated and redundant comment.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
> Changes from v1 [1]
> - Remove the whole useless comment
>
> [1] https://lore.kernel.org/all/20261104144753.2266231-1-ekffu200098@gmail.com/
>
> ---
> mm/slab_common.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 01c64ef661e7..10603b9cbb53 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1028,11 +1028,6 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type)
> kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx];
> }
>
> -/*
> - * Create the kmalloc array. Some of the regular kmalloc arrays
> - * may already have been created because they were needed to
> - * enable allocations for slab creation.
> - */
> void __init create_kmalloc_caches(void)
> {
> int i;
>
> base-commit: ce6518e61e3b4bf4f97f7ac6204049b9eba7eb75
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches()
2026-11-12 14:46 [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches() Sang-Heon Jeon
2026-11-12 15:00 ` Vlastimil Babka (SUSE)
@ 2026-11-12 15:06 ` Harry Yoo (Meta)
1 sibling, 0 replies; 3+ messages in thread
From: Harry Yoo (Meta) @ 2026-11-12 15:06 UTC (permalink / raw)
To: Vlastimil Babka, Andrew Morton, Sang-Heon Jeon
Cc: kernel-team, Christoph Lameter, David Rientjes, Hao Li,
linux-kernel, linux-mm, Roman Gushchin
On Thu, 12 Nov 2026 23:46:52 +0900, Sang-Heon Jeon wrote:
> Since commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
> removed SLAB, no kmalloc cache is created before create_kmalloc_caches().
>
> So remove the outdated and redundant comment.
Applied to mm/slab.git slab/for-next, thanks!
[1/1] mm/slab: remove outdated comment in create_kmalloc_caches()
commit: a7cdd0af963a420fc0e6f20b7c8bc8d4784098db
--
Cheers,
Harry / Hyeonggon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-12 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-12 14:46 [PATCH v2] mm/slab: remove outdated comment in create_kmalloc_caches() Sang-Heon Jeon
2026-11-12 15:00 ` Vlastimil Babka (SUSE)
2026-11-12 15:06 ` Harry Yoo (Meta)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®