* [PATCH] drm/panel-edp: add BOE NE160QDM-NX4 (0x0d25)
@ 2026-11-13 21:45 Ingo A. Kubbilun
2026-11-13 22:53 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Ingo A. Kubbilun @ 2026-11-13 21:45 UTC (permalink / raw)
To: Douglas Anderson, Neil Armstrong, Jessica Zhang,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: dri-devel, linux-kernel, Ingo A. Kubbilun
16" panel of the ASUS Vivobook S16 S3607QA. Without the entry the
driver warns "Unknown panel BOE 0x0d25, using conservative timings".
Developed with the help of an AI coding assistant (Anthropic Claude),
which drafted the changes from the Windows ACPI tables, existing device
trees and test logs; reviewed, built and tested on the device by the
submitter.
Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index bc16d6e30a5a..6ead44ca6d7b 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -2078,6 +2078,7 @@ static const struct edp_panel_entry edp_panels[] = {
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cf2, &delay_200_500_e200, "NV156FHM-N4S"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cf6, &delay_200_500_e200_d100, "NV140WUM-N64"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cfa, &delay_200_500_e50, "NV116WHM-A4D"),
+ EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d25, &delay_200_500_e80, "NE160QDM-NX4"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d45, &delay_200_500_e80, "NV116WHM-N4B"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d73, &delay_200_500_e80, "NE140WUM-N6S"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d98, &delay_200_500_e50_po2e200_d100, "NV140FHM-N5B"),
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel-edp: add BOE NE160QDM-NX4 (0x0d25)
2026-11-13 21:45 [PATCH] drm/panel-edp: add BOE NE160QDM-NX4 (0x0d25) Ingo A. Kubbilun
@ 2026-11-13 22:53 ` Doug Anderson
2026-11-14 2:20 ` Ingo A. Kubbilun
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2026-11-13 22:53 UTC (permalink / raw)
To: Ingo A. Kubbilun
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Hi,
On Fri, Nov 13, 2026 at 1:45 PM Ingo A. Kubbilun
<ingo.kubbilun@gmail.com> wrote:
>
> 16" panel of the ASUS Vivobook S16 S3607QA. Without the entry the
> driver warns "Unknown panel BOE 0x0d25, using conservative timings".
>
> Developed with the help of an AI coding assistant (Anthropic Claude),
> which drafted the changes from the Windows ACPI tables, existing device
> trees and test logs; reviewed, built and tested on the device by the
> submitter.
>
> Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 insertion(+)
Please follow conventions from recent changes to this file and include
the EDID in the commit message.
Please also provide more details about how your AI agent analyzed the
ACPI tables. Did it use the ACPI tables to determine the delays to use
here? Can you have it provide a commit message detailed enough for
someone else to duplicate that effort? ...or did the AI agent just
look at the delays of similar panels?
-Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel-edp: add BOE NE160QDM-NX4 (0x0d25)
2026-11-13 22:53 ` Doug Anderson
@ 2026-11-14 2:20 ` Ingo A. Kubbilun
0 siblings, 0 replies; 3+ messages in thread
From: Ingo A. Kubbilun @ 2026-11-14 2:20 UTC (permalink / raw)
To: Doug Anderson
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Hi Doug,
On Fri, Nov 13, 2026 at 1:45 PM Doug Anderson wrote:
> Please follow conventions from recent changes to this file and include
> the EDID in the commit message.
Will do in v2. For your information, the raw EDID is:
00 ff ff ff ff ff ff 00 09 e5 25 0d 00 00 00 00
17 22 01 04 a5 22 16 78 07 ed 85 a3 54 4c 9d 26
0b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 a7 6d 00 a0 a0 40 78 60 30 20
36 00 58 d7 10 00 00 1a 00 00 00 fd 00 30 90 f8
f8 43 01 0a 20 20 20 20 20 20 00 00 00 fe 00 3d
4c 33 30 20 20 20 20 20 20 20 20 ff 00 00 00 fc
00 4e 45 31 36 30 51 44 4d 2d 4e 58 34 0a 01 0c
70 20 79 02 00 21 00 1d 7a 0d 66 08 00 0a 40 06
80 3d 7a 54 cc 24 9d 66 02 0b 02 35 54 40 5e 40
5e 00 44 12 78 22 00 14 99 47 0a 85 ff 09 9f 00
2f 00 1f 00 3f 06 77 00 02 00 05 00 2b 00 0c 27
00 30 8f 00 00 27 00 30 3b 00 00 2e 00 06 00 44
40 5e 40 5e 81 00 1e 72 1a 00 00 03 01 30 90 00
00 60 ff 60 ff 90 00 00 00 00 e3 05 04 00 e6 06
01 01 60 60 ff 00 00 00 00 00 00 00 00 00 2c 90
> Please also provide more details about how your AI agent analyzed the
> ACPI tables. Did it use the ACPI tables to determine the delays to use
> here? […] or did the AI agent just look at the delays of similar panels?
The delays were not derived from the ACPI tables. I wrote this entry
myself and picked delay_200_500_e80 because other BOE NE1xx panels in
panel-edp use it; it has worked reliably across many cold boots.
I'm working with this machine on a daily basis for two weeks now without
any problems.
Only afterwards did the AI check the ACPI tables: their panel
configuration is a generic one ("Panel_Generic_Amoled", backlight PWM
settings only) with no power-sequencing data. There is no datasheet
available to me.
The AI disclosure in the commit message was a generic text applied to
the whole series and overstated its role for this patch. Sorry for
that; v2 will describe it accurately.
Cheers,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-14 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-13 21:45 [PATCH] drm/panel-edp: add BOE NE160QDM-NX4 (0x0d25) Ingo A. Kubbilun
2026-11-13 22:53 ` Doug Anderson
2026-11-14 2:20 ` Ingo A. Kubbilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®