[PATCH 1/3] Input: tsc2007 - drop unnecessary cast in tsc2007_calculate_resistance()

[PATCH 1/3] Input: tsc2007 - drop unnecessary cast in tsc2007_calculate_resistance()

[Dmitry Torokhov]

The resistance value is already bounds-checked against U32_MAX before
returning from a function returning u32, so the explicit cast is
unnecessary. Drop it.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/tsc2007_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index 7660504f58ff..fc707e672424 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -82,7 +82,7 @@ u32 tsc2007_calculate_resistance(struct tsc2007 *tsc, struct ts_event *tc)
 
 	if (rt > U32_MAX)
 		return U32_MAX;
-	return (u32)rt;
+	return rt;
 }
 
 bool tsc2007_is_pen_down(struct tsc2007 *ts)
-- 
2.56.0.679.gc527c65306-goog

[PATCH 2/3] Input: tsc2007 - use scnprintf() when formatting phys string

[Dmitry Torokhov]

Use scnprintf() instead of snprintf() when constructing the physical
device path string to follow kernel string formatting conventions.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/tsc2007_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index fc707e672424..d55034914808 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -252,7 +252,7 @@ static int tsc2007_input_configure(struct tsc2007 *ts)
 
 	ts->input = input_dev;
 
-	snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));
+	scnprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));
 
 	input_dev->name = "TSC2007 Touchscreen";
 	input_dev->phys = ts->phys;
-- 
2.56.0.679.gc527c65306-goog

[PATCH 3/3] Input: tsc2007 - drop redundant error message on IRQ request failure

[Dmitry Torokhov]

devm_request_threaded_irq() already logs an error message when
requesting the interrupt fails, so the additional dev_err() call in
tsc2007_input_configure() is redundant. Remove it.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/tsc2007_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index d55034914808..3597f71f6c33 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -276,10 +276,8 @@ static int tsc2007_input_configure(struct tsc2007 *ts)
 					NULL, tsc2007_soft_irq,
 					IRQF_ONESHOT | IRQF_NO_AUTOEN,
 					dev->driver->name, ts);
-	if (err) {
-		dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);
+	if (err)
 		return err;
-	}
 
 	err = input_register_device(input_dev);
 	if (err) {
-- 
2.56.0.679.gc527c65306-goog

Re: [PATCH 1/3] Input: tsc2007 - drop unnecessary cast in tsc2007_calculate_resistance()

[Andy Shevchenko]

On Sat, Nov 14, 2026 at 2:02 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> The resistance value is already bounds-checked against U32_MAX before
> returning from a function returning u32, so the explicit cast is
> unnecessary. Drop it.

Reviewed-by: Andy Shevchenko <andy@kernel.org>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/3] Input: tsc2007 - use scnprintf() when formatting phys string

[Andy Shevchenko]

On Sat, Nov 14, 2026 at 2:02 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Use scnprintf() instead of snprintf() when constructing the physical
> device path string to follow kernel string formatting conventions.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 3/3] Input: tsc2007 - drop redundant error message on IRQ request failure

[Andy Shevchenko]

On Sat, Nov 14, 2026 at 2:02 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> devm_request_threaded_irq() already logs an error message when
> requesting the interrupt fails, so the additional dev_err() call in
> tsc2007_input_configure() is redundant. Remove it.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko