* [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID
@ 2026-11-15 20:54 Vítor Hugo Silva
2026-11-15 21:29 ` Guenter Roeck
2026-11-15 22:39 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Vítor Hugo Silva @ 2026-11-15 20:54 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck; +Cc: Diogo Ivo, linux-watchdog, linux-kernel
The Lenovo laptops with an Intel Core 7 240H (Raptor Lake)
exposes its OC watchdog as 'INTC109C', leaving the device
unbound, because this ID is not present from the driver's
ACPI intel_oc_wdt_match table.
The firmware selects INTC109C or the already supported
INTC1099 from the same CWDT object's _HID method,
depending on the processor signature. Both paths share a
four-byte I/O resource at PMBS + 0x54.
Add INTC109C to the match table to use the existing implementation.
I have tested as a module on Fedora kernel 7.3.3-300.fc45.x86_64.
I did verify device binding, timeout configuration, start,
keepalive, explicit stop and magic close. Register reads
confirmed the enable and timeout fields. Expiry-triggered
reset was not tested.
AI assistance was used for development of the test harness
and 'peer-review' the patch.
Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
---
drivers/watchdog/intel_oc_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/intel_oc_wdt.c b/drivers/watchdog/intel_oc_wdt.c
index 0b012aeb1..a78fe1e5f 100644
--- a/drivers/watchdog/intel_oc_wdt.c
+++ b/drivers/watchdog/intel_oc_wdt.c
@@ -215,6 +215,7 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
static const struct acpi_device_id intel_oc_wdt_match[] = {
{ "INT3F0D" },
{ "INTC1099" },
+ { "INTC109C" },
{ },
};
MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);
base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
--
2.56.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID
2026-11-15 20:54 [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID Vítor Hugo Silva
@ 2026-11-15 21:29 ` Guenter Roeck
2026-11-15 21:57 ` Vítor Silva
2026-11-15 22:39 ` Guenter Roeck
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2026-11-15 21:29 UTC (permalink / raw)
To: Vítor Hugo Silva, Wim Van Sebroeck
Cc: Diogo Ivo, linux-watchdog, linux-kernel
On 11/15/26 12:54, Vítor Hugo Silva wrote:
> The Lenovo laptops with an Intel Core 7 240H (Raptor Lake)
> exposes its OC watchdog as 'INTC109C', leaving the device
> unbound, because this ID is not present from the driver's
> ACPI intel_oc_wdt_match table.
>
> The firmware selects INTC109C or the already supported
> INTC1099 from the same CWDT object's _HID method,
> depending on the processor signature. Both paths share a
> four-byte I/O resource at PMBS + 0x54.
>
> Add INTC109C to the match table to use the existing implementation.
>
> I have tested as a module on Fedora kernel 7.3.3-300.fc45.x86_64.
> I did verify device binding, timeout configuration, start,
> keepalive, explicit stop and magic close. Register reads
> confirmed the enable and timeout fields. Expiry-triggered
> reset was not tested.
>
Why not ? That means you don't know if the code actually works.
Thanks,
Guenter
> AI assistance was used for development of the test harness
> and 'peer-review' the patch.
>
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
> ---
> drivers/watchdog/intel_oc_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/intel_oc_wdt.c b/drivers/watchdog/intel_oc_wdt.c
> index 0b012aeb1..a78fe1e5f 100644
> --- a/drivers/watchdog/intel_oc_wdt.c
> +++ b/drivers/watchdog/intel_oc_wdt.c
> @@ -215,6 +215,7 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
> static const struct acpi_device_id intel_oc_wdt_match[] = {
> { "INT3F0D" },
> { "INTC1099" },
> + { "INTC109C" },
> { },
> };
> MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);
>
> base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID
2026-11-15 21:29 ` Guenter Roeck
@ 2026-11-15 21:57 ` Vítor Silva
0 siblings, 0 replies; 4+ messages in thread
From: Vítor Silva @ 2026-11-15 21:57 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, Diogo Ivo, linux-watchdog, linux-kernel
You are absolutely right. It made no sense to not test it.
I ran an expiry test and it worked:
I have set up a 60 seconds timeout, kept the watchdog
device open without sending keepalives.
It forced the reset right after it timed out.
Thanks for the quick reply,
Vítor
Guenter Roeck <linux@roeck-us.net> escreveu (domingo, 15/11/2026 à(s) 21:29):
>
> On 11/15/26 12:54, Vítor Hugo Silva wrote:
> > The Lenovo laptops with an Intel Core 7 240H (Raptor Lake)
> > exposes its OC watchdog as 'INTC109C', leaving the device
> > unbound, because this ID is not present from the driver's
> > ACPI intel_oc_wdt_match table.
> >
> > The firmware selects INTC109C or the already supported
> > INTC1099 from the same CWDT object's _HID method,
> > depending on the processor signature. Both paths share a
> > four-byte I/O resource at PMBS + 0x54.
> >
> > Add INTC109C to the match table to use the existing implementation.
> >
> > I have tested as a module on Fedora kernel 7.3.3-300.fc45.x86_64.
> > I did verify device binding, timeout configuration, start,
> > keepalive, explicit stop and magic close. Register reads
> > confirmed the enable and timeout fields. Expiry-triggered
> > reset was not tested.
> >
>
> Why not ? That means you don't know if the code actually works.
>
> Thanks,
> Guenter
>
> > AI assistance was used for development of the test harness
> > and 'peer-review' the patch.
> >
> > Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
> > ---
> > drivers/watchdog/intel_oc_wdt.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/watchdog/intel_oc_wdt.c b/drivers/watchdog/intel_oc_wdt.c
> > index 0b012aeb1..a78fe1e5f 100644
> > --- a/drivers/watchdog/intel_oc_wdt.c
> > +++ b/drivers/watchdog/intel_oc_wdt.c
> > @@ -215,6 +215,7 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
> > static const struct acpi_device_id intel_oc_wdt_match[] = {
> > { "INT3F0D" },
> > { "INTC1099" },
> > + { "INTC109C" },
> > { },
> > };
> > MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);
> >
> > base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID
2026-11-15 20:54 [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID Vítor Hugo Silva
2026-11-15 21:29 ` Guenter Roeck
@ 2026-11-15 22:39 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2026-11-15 22:39 UTC (permalink / raw)
To: Vítor Hugo Silva
Cc: Wim Van Sebroeck, Diogo Ivo, linux-watchdog, linux-kernel
On Sun, Nov 15, 2026 at 08:54:08PM +0000, Vítor Hugo Silva wrote:
> The Lenovo laptops with an Intel Core 7 240H (Raptor Lake)
> exposes its OC watchdog as 'INTC109C', leaving the device
> unbound, because this ID is not present from the driver's
> ACPI intel_oc_wdt_match table.
>
> The firmware selects INTC109C or the already supported
> INTC1099 from the same CWDT object's _HID method,
> depending on the processor signature. Both paths share a
> four-byte I/O resource at PMBS + 0x54.
>
> Add INTC109C to the match table to use the existing implementation.
>
> I have tested as a module on Fedora kernel 7.3.3-300.fc45.x86_64.
> I did verify device binding, timeout configuration, start,
> keepalive, explicit stop and magic close. Register reads
> confirmed the enable and timeout fields. Expiry-triggered
> reset was not tested.
>
> AI assistance was used for development of the test harness
> and 'peer-review' the patch.
>
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/watchdog/intel_oc_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
> base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
>
> diff --git a/drivers/watchdog/intel_oc_wdt.c b/drivers/watchdog/intel_oc_wdt.c
> index 0b012aeb1..a78fe1e5f 100644
> --- a/drivers/watchdog/intel_oc_wdt.c
> +++ b/drivers/watchdog/intel_oc_wdt.c
> @@ -215,6 +215,7 @@ static int intel_oc_wdt_probe(struct platform_device *pdev)
> static const struct acpi_device_id intel_oc_wdt_match[] = {
> { "INT3F0D" },
> { "INTC1099" },
> + { "INTC109C" },
> { },
> };
> MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-15 22:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 20:54 [PATCH] watchdog: intel_oc_wdt: Add INTC109C ACPI ID Vítor Hugo Silva
2026-11-15 21:29 ` Guenter Roeck
2026-11-15 21:57 ` Vítor Silva
2026-11-15 22:39 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®