* [PATCH] printk: Fix skipped entries after index iterator restart
@ 2026-11-16 8:56 Avi Weiss
2026-11-16 9:15 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Avi Weiss @ 2026-11-16 8:56 UTC (permalink / raw)
To: Chris Down, Petr Mladek, John Ogness
Cc: Steven Rostedt, Sergey Senozhatsky, printk, linux-kernel, Avi Weiss
seq_read_iter() can advance the iterator before the next record
fits in the read buffer. When iteration resumes, pi_start() calls
pi_next() at the saved position and advances past the pending printk
index entry. As a result, index reads can silently omit formats.
Return the entry corresponding to the saved position without
advancing the iterator.
Fixes: 337015573718 ("printk: Userspace format indexing support")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
kernel/printk/index.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/printk/index.c b/kernel/printk/index.c
index a6b27526baaf6..642640a36abe1 100644
--- a/kernel/printk/index.c
+++ b/kernel/printk/index.c
@@ -59,7 +59,7 @@ static void *pi_start(struct seq_file *s, loff_t *pos)
if (*pos == 0)
return SEQ_START_TOKEN;
- return pi_next(s, NULL, pos);
+ return pi_get_entry(s->file->f_inode->i_private, *pos - 1);
}
/*
base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] printk: Fix skipped entries after index iterator restart
2026-11-16 8:56 [PATCH] printk: Fix skipped entries after index iterator restart Avi Weiss
@ 2026-11-16 9:15 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-11-16 9:15 UTC (permalink / raw)
To: Avi Weiss
Cc: Chris Down, Petr Mladek, John Ogness, Steven Rostedt,
Sergey Senozhatsky, printk, linux-kernel
On Mon, Nov 16, 2026 at 10:56:10AM +0200, Avi Weiss wrote:
> seq_read_iter() can advance the iterator before the next record
> fits in the read buffer. When iteration resumes, pi_start() calls
> pi_next() at the saved position and advances past the pending printk
> index entry. As a result, index reads can silently omit formats.
>
> Return the entry corresponding to the saved position without
> advancing the iterator.
...
> - return pi_next(s, NULL, pos);
> + return pi_get_entry(s->file->f_inode->i_private, *pos - 1);
Side note (because it seems used more in the same form), we have file_inode()
helper and this should idiomatically look as
return pi_get_entry(file_inode(s->file)->i_private, *pos - 1);
But I haven't checked if the file_inode() is recommended or deprecated API.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 8:56 [PATCH] printk: Fix skipped entries after index iterator restart Avi Weiss
2026-11-16 9:15 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®