mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first
Date: Mon, 16 Nov 2026 09:16:54 +0100	[thread overview]
Message-ID: <20261116091654.26a56120@kemnade.info> (raw)
In-Reply-To: <20261015-tc358762-fixes-v5-4-7cd721a6451b@ideasonboard.com>

On Thu, 15 Oct 2026 14:15:55 +0300
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:

> SYSCTRL affects the DPI output and the clock tree, but we configure it
> late, when the DPI output is already enabled and clocks are running.
> 
> Move the SYSCTRL configuration to the beginning, before anything is
> enabled.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

sounds sane so

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

> ---
>  drivers/gpu/drm/bridge/tc358762.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index 26671dc66874..f5ee781275fc 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -134,6 +134,13 @@ static int tc358762_init(struct tc358762 *ctx)
>  {
>  	u32 lcdctrl;
>  
> +	tc358762_write(ctx, SYSCTRL,
> +		       FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) |
> +		       FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) |
> +		       FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3));
> +
> +	msleep(100);
> +
>  	tc358762_write(ctx, DSI_LANEENABLE,
>  		       DSI_LANEENABLE_L0EN | DSI_LANEENABLE_CLEN);
>  	tc358762_write(ctx, PPI_D0S_CLRSIPOCOUNT, 5);
> @@ -157,13 +164,6 @@ static int tc358762_init(struct tc358762 *ctx)
>  
>  	tc358762_write(ctx, LCDCTRL, lcdctrl);
>  
> -	tc358762_write(ctx, SYSCTRL,
> -		       FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) |
> -		       FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) |
> -		       FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3));
> -
> -	msleep(100);
> -
>  	tc358762_write(ctx, PPI_STARTPPI, PPI_STARTPPI_STARTPPI);
>  	tc358762_write(ctx, DSI_STARTDSI, DSI_STARTDSI_STARTDSI);
>  
> 


  reply	other threads:[~2026-11-16  8:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 11:15 [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 01/13] drm/bridge: tc358762: Clean up register defines Tomi Valkeinen
2026-11-11 10:30   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 02/13] drm/bridge: tc358762: Improve SYSCTRL " Tomi Valkeinen
2026-11-11 10:35   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines Tomi Valkeinen
2026-11-16  8:02   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first Tomi Valkeinen
2026-11-16  8:16   ` Andreas Kemnade [this message]
2026-10-15 11:15 ` [PATCH v5 05/13] drm/bridge: tc358762: Drop SPICMR write Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 06/13] drm/bridge: tc358762: Improve DPI enable handling Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 07/13] drm/bridge: tc358762: Update comment about the number of lanes Tomi Valkeinen
2026-11-16  8:25   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 08/13] drm/bridge: tc358762: Support VTG Tomi Valkeinen
2026-10-15 11:16 ` [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities Tomi Valkeinen
2026-11-16  8:29   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Tomi Valkeinen
2026-11-16  9:05   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Tomi Valkeinen
2026-11-16  9:06   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly Tomi Valkeinen
2026-11-16  9:17   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings Tomi Valkeinen
2026-10-28 11:42 ` [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116091654.26a56120@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®