mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable()
Date: Mon, 16 Nov 2026 10:05:26 +0100	[thread overview]
Message-ID: <20261116100526.3e699f94@kemnade.info> (raw)
In-Reply-To: <20261015-tc358762-fixes-v5-10-7cd721a6451b@ideasonboard.com>

On Thu, 15 Oct 2026 14:16:01 +0300
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:

> The only thing tc358762_enable() does is call tc358762_init(). Inline
> the tc358762_init() into tc358762_enable(), for simplicity and to make
> it easier to improve the tc358762_enable() in the following commits. No
> functional change.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/gpu/drm/bridge/tc358762.c | 104 ++++++++++++++++++--------------------
>  1 file changed, 49 insertions(+), 55 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index 2baacef685a5..a91cf159ba27 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -138,9 +138,56 @@ static inline struct tc358762 *bridge_to_tc358762(struct drm_bridge *bridge)
>  	return container_of(bridge, struct tc358762, bridge);
>  }
>  
> -static int tc358762_init(struct tc358762 *ctx)
> +static void tc358762_post_disable(struct drm_bridge *bridge,
> +				  struct drm_atomic_commit *state)
> +{
> +	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> +	int ret;
> +
> +	/*
> +	 * The post_disable hook might be called multiple times.
> +	 * We want to avoid regulator imbalance below.
> +	 */
> +	if (!ctx->pre_enabled)
> +		return;
> +
> +	ctx->pre_enabled = false;
> +
> +	/* Turn off the DPI output */
> +	tc358762_write(ctx, LCDCTRL, 0);
> +
> +	if (ctx->reset_gpio)
> +		gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> +
> +	ret = regulator_disable(ctx->regulator);
> +	if (ret < 0)
> +		dev_err(ctx->dev, "error disabling regulators (%d)\n", ret);
> +}
> +
> +static void tc358762_pre_enable(struct drm_bridge *bridge,
> +				struct drm_atomic_commit *state)
>  {
> +	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> +	int ret;
> +
> +	ret = regulator_enable(ctx->regulator);
> +	if (ret < 0)
> +		dev_err(ctx->dev, "error enabling regulators (%d)\n", ret);
> +
> +	if (ctx->reset_gpio) {
> +		gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> +		usleep_range(5000, 10000);
> +	}
> +
> +	ctx->pre_enabled = true;
> +}
> +
> +static void tc358762_enable(struct drm_bridge *bridge,
> +			    struct drm_atomic_commit *state)
> +{
> +	struct tc358762 *ctx = bridge_to_tc358762(bridge);
>  	u32 lcdctrl;
> +	int ret;
>  
>  	/*
>  	 * DPIENABLE has reset default of 1. Make sure we don't output on
> @@ -203,60 +250,7 @@ static int tc358762_init(struct tc358762 *ctx)
>  
>  	msleep(100);
>  
> -	return tc358762_clear_error(ctx);
> -}
> -
> -static void tc358762_post_disable(struct drm_bridge *bridge,
> -				  struct drm_atomic_commit *state)
> -{
> -	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> -	int ret;
> -
> -	/*
> -	 * The post_disable hook might be called multiple times.
> -	 * We want to avoid regulator imbalance below.
> -	 */
> -	if (!ctx->pre_enabled)
> -		return;
> -
> -	ctx->pre_enabled = false;
> -
> -	/* Turn off the DPI output */
> -	tc358762_write(ctx, LCDCTRL, 0);
> -
> -	if (ctx->reset_gpio)
> -		gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> -
> -	ret = regulator_disable(ctx->regulator);
> -	if (ret < 0)
> -		dev_err(ctx->dev, "error disabling regulators (%d)\n", ret);
> -}
> -
> -static void tc358762_pre_enable(struct drm_bridge *bridge,
> -				struct drm_atomic_commit *state)
> -{
> -	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> -	int ret;
> -
> -	ret = regulator_enable(ctx->regulator);
> -	if (ret < 0)
> -		dev_err(ctx->dev, "error enabling regulators (%d)\n", ret);
> -
> -	if (ctx->reset_gpio) {
> -		gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> -		usleep_range(5000, 10000);
> -	}
> -
> -	ctx->pre_enabled = true;
> -}
> -
> -static void tc358762_enable(struct drm_bridge *bridge,
> -			    struct drm_atomic_commit *state)
> -{
> -	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> -	int ret;
> -
> -	ret = tc358762_init(ctx);
> +	ret = tc358762_clear_error(ctx);
>  	if (ret < 0)
>  		dev_err(ctx->dev, "error initializing bridge (%d)\n", ret);
>  }
> 


  reply	other threads:[~2026-11-16  9:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 11:15 [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 01/13] drm/bridge: tc358762: Clean up register defines Tomi Valkeinen
2026-11-11 10:30   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 02/13] drm/bridge: tc358762: Improve SYSCTRL " Tomi Valkeinen
2026-11-11 10:35   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines Tomi Valkeinen
2026-11-16  8:02   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first Tomi Valkeinen
2026-11-16  8:16   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 05/13] drm/bridge: tc358762: Drop SPICMR write Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 06/13] drm/bridge: tc358762: Improve DPI enable handling Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 07/13] drm/bridge: tc358762: Update comment about the number of lanes Tomi Valkeinen
2026-11-16  8:25   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 08/13] drm/bridge: tc358762: Support VTG Tomi Valkeinen
2026-10-15 11:16 ` [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities Tomi Valkeinen
2026-11-16  8:29   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Tomi Valkeinen
2026-11-16  9:05   ` Andreas Kemnade [this message]
2026-10-15 11:16 ` [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Tomi Valkeinen
2026-11-16  9:06   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly Tomi Valkeinen
2026-11-16  9:17   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings Tomi Valkeinen
2026-10-28 11:42 ` [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116100526.3e699f94@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®