From: Francesco Dolcini <francesco@dolcini.it>
To: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Alexander Stein <alexander.stein@ew.tq-group.com>
Subject: [PATCH v1] Revert "phy: freescale: fsl-samsung-hdmi: initialize default rate"
Date: Mon, 16 Nov 2026 17:24:08 +0100 [thread overview]
Message-ID: <20261116162409.218059-1-francesco@dolcini.it> (raw)
From: Francesco Dolcini <francesco.dolcini@toradex.com>
This reverts commit c01ccf91b257741e9edc374a465126bae9ae4711.
Programming the 74.25 MHz configuration at probe fails on i.MX8MP boards,
the PHY probe aborts and HDMI is no longer available:
fsl-samsung-hdmi-phy 32fdff00.phy: PLL failed to lock
fsl-samsung-hdmi-phy 32fdff00.phy: error -ETIMEDOUT: failed to configure default rate
fsl-samsung-hdmi-phy 32fdff00.phy: probe with driver fsl-samsung-hdmi-phy failed with error -110
Reported-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Closes: https://lore.kernel.org/all/13219248.O9o76ZdvQC@steina-w/
Fixes: c01ccf91b257 ("phy: freescale: fsl-samsung-hdmi: initialize default rate")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 59 +++++---------------
1 file changed, 15 insertions(+), 44 deletions(-)
diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c
index aaa651abcbc6..d7418c2197c9 100644
--- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c
+++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c
@@ -44,8 +44,6 @@
#define MHZ (1000UL * 1000UL)
#endif
-#define PHY_DEFAULT_RATE 74250000
-
#define PHY_PLL_DIV_REGS_NUM 7
struct phy_config {
@@ -491,6 +489,17 @@ static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy,
return ret;
}
+static unsigned long phy_clk_recalc_rate(struct clk_hw *hw,
+ unsigned long parent_rate)
+{
+ struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw);
+
+ if (!phy->cur_cfg)
+ return 74250000;
+
+ return phy->cur_cfg->pixclk;
+}
+
/* Helper function to lookup the available fractional-divider rate */
static const struct phy_config *fsl_samsung_hdmi_phy_lookup_rate(unsigned long rate)
{
@@ -511,14 +520,6 @@ static const struct phy_config *fsl_samsung_hdmi_phy_lookup_rate(unsigned long r
&phy_pll_cfg[i] : &phy_pll_cfg[i+1]);
}
-static unsigned long phy_clk_recalc_rate(struct clk_hw *hw,
- unsigned long parent_rate)
-{
- struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw);
-
- return phy->cur_cfg->pixclk;
-}
-
static void fsl_samsung_hdmi_calculate_phy(struct phy_config *cal_phy, unsigned long rate,
u8 p, u16 m, u8 s)
{
@@ -639,7 +640,6 @@ static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy)
static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev)
{
- const struct phy_config *default_cfg;
struct fsl_samsung_hdmi_phy *phy;
int ret;
@@ -664,23 +664,6 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev)
return dev_err_probe(phy->dev, PTR_ERR(phy->refclk),
"failed to get ref clk\n");
- /*
- * Establish the rate reported by recalc_rate() before registering the
- * clock. Otherwise CCF may skip the first set_rate() when it requests
- * the assumed default rate, leaving the PHY unconfigured.
- */
- ret = clk_prepare_enable(phy->refclk);
- if (ret)
- return dev_err_probe(phy->dev, ret,
- "failed to enable ref clk\n");
-
- default_cfg = fsl_samsung_hdmi_phy_lookup_rate(PHY_DEFAULT_RATE);
- ret = fsl_samsung_hdmi_phy_configure(phy, default_cfg);
- clk_disable_unprepare(phy->refclk);
- if (ret)
- return dev_err_probe(phy->dev, ret,
- "failed to configure default rate\n");
-
pm_runtime_get_noresume(phy->dev);
pm_runtime_set_active(phy->dev);
pm_runtime_enable(phy->dev);
@@ -719,7 +702,7 @@ static int __maybe_unused fsl_samsung_hdmi_phy_suspend(struct device *dev)
static int __maybe_unused fsl_samsung_hdmi_phy_resume(struct device *dev)
{
struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev);
- int ret;
+ int ret = 0;
ret = clk_prepare_enable(phy->apbclk);
if (ret) {
@@ -727,23 +710,11 @@ static int __maybe_unused fsl_samsung_hdmi_phy_resume(struct device *dev)
return ret;
}
- if (!phy->cur_cfg)
- return 0;
-
- ret = clk_prepare_enable(phy->refclk);
- if (ret) {
- dev_err(phy->dev, "failed to enable ref clk\n");
- goto disable_apbclk;
- }
-
- ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg);
- clk_disable_unprepare(phy->refclk);
- if (!ret)
- return 0;
+ if (phy->cur_cfg)
+ ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg);
-disable_apbclk:
- clk_disable_unprepare(phy->apbclk);
return ret;
+
}
static DEFINE_RUNTIME_DEV_PM_OPS(fsl_samsung_hdmi_phy_pm_ops,
--
2.47.3
next reply other threads:[~2026-11-16 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:24 Francesco Dolcini [this message]
2026-11-17 7:38 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116162409.218059-1-francesco@dolcini.it \
--to=francesco@dolcini.it \
--cc=alexander.stein@ew.tq-group.com \
--cc=francesco.dolcini@toradex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®