From: Chrispine Tinega <dev@chrispinetinega.com>
To: francesco@valla.it
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Chrispine Tinega <dev@chrispinetinega.com>
Subject: Re: [PATCH 0/2] remoteproc: k3: Recover a crashed remote core
Date: Mon, 16 Nov 2026 21:50:00 +0300 [thread overview]
Message-ID: <20261116185000.1900725-1-dev@chrispinetinega.com> (raw)
In-Reply-To: <avoem-QRseasexkV@bywater>
Hi Francesco,
On Sun, Nov 15, 2026 at 10:11:01PM +0100, Francesco Valla wrote:
> An update on this. Recovery is definitley _not_ working on R5F remote
> cores in case of crash, because the reset action that is required from
> them to re-start correctly is in do_unprepare(), which the recovery
> action does not call (while sysfs does). This is of course out of the
> scope of your patch set, but has to be considered (maybe deserves a
> note in the commit message?).
Thank you for tracking that down. I agree it deserves a note. In v2
the commit message of patch 1 says that recovery cannot yet restart an
R5F, because the reset it needs is applied in unprepare(), which sysfs
stop calls and recovery does not. The R5F driver keeps recovery
disabled, so the series does not change what happens there: the core
moves to "crashed" and can be restarted through sysfs.
Making recovery work on the R5F, by doing that reset on the recovery
path too, seems like a separate series. I am happy to look at it after
this one.
v2 also drops the duplicate crash print, as you suggested. I have just
sent it:
https://lore.kernel.org/all/20261116184146.1897281-1-dev@chrispinetinega.com/
A Tested-by on v2 for patch 1 on the R5F would be very welcome.
Thanks,
Chrispine
prev parent reply other threads:[~2026-11-16 18:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 5:48 Chrispine Tinega
2026-11-09 5:48 ` [PATCH 1/2] remoteproc: k3: Report a remote crash to the remoteproc core Chrispine Tinega
2026-11-11 22:21 ` Francesco Valla
2026-11-12 12:39 ` Chrispine Tinega
2026-11-09 5:48 ` [PATCH 2/2] remoteproc: k3-m4: Leave crash recovery enabled Chrispine Tinega
2026-11-15 21:04 ` Francesco Valla
2026-11-16 18:49 ` Chrispine Tinega
2026-11-09 6:59 ` [PATCH 0/2] remoteproc: k3: Recover a crashed remote core Francesco Valla
2026-11-09 16:04 ` Chrispine Tinega
2026-11-09 23:55 ` Francesco Valla
2026-11-15 21:11 ` Francesco Valla
2026-11-16 18:50 ` Chrispine Tinega [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116185000.1900725-1-dev@chrispinetinega.com \
--to=dev@chrispinetinega.com \
--cc=andersson@kernel.org \
--cc=francesco@valla.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®