mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: jstultz@google.com, peterz@infradead.org, mingo@redhat.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	kprateek.nayak@amd.com, connoro@google.com, arighi@nvidia.com,
	akpm@linux-foundation.org, shuah@kernel.org,
	linux-kselftest@vger.kernel.org
Subject: [RFC PATCH v1 1/8] sched/proxy: Reschedule when a blocked task is woken under a proxy
Date: Mon, 16 Nov 2026 14:26:31 -0500	[thread overview]
Message-ID: <20261116192638.233125-2-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20261116192638.233125-1-mathieu.desnoyers@efficios.com>

With proxy execution, a task blocked on a mutex stays on its runqueue.
The scheduler can pick it as the donor and run the mutex owner in its
place. When the donor is woken, the CPU must stop running the owner on
the donor's context.

Commit 7918cf369361 ("sched/proxy: Only return migrate when needed")
wakes a blocked task in place when it is still on its original CPU.
ttwu_runnable() then relies on wakeup_preempt() to preempt the running
task. But every class compares the woken task with rq->donor. When the
woken task is the donor, it compares the task with itself, and no
reschedule is requested. Only sched_ext handles this, with WF_TTWU_RQ.

So the old owner keeps the donor's context after the mutex hand-off or
after a signal. With a SCHED_FIFO donor nothing bounds this: the owner
runs at the donor's priority until it blocks. With a SCHED_DEADLINE
donor the owner consumes the donor's runtime.

In a test on one CPU, a SCHED_OTHER owner kept spinning in user space
after it released the mutex. A SCHED_FIFO waiter then ran 800ms late. A
SCHED_DEADLINE waiter ran one period late.

The same would happen when a task in the middle of a chain is woken.
proxy_needs_return() resets the donor only when the woken task is the
donor.

Fix this in ttwu_runnable(). When a blocked task is woken on a runqueue
that runs a proxy, reschedule. The next pick walks the chain again. A
blocked task outside the donor's chain causes a harmless reschedule
too.

Fixes: 7918cf369361 ("sched/proxy: Only return migrate when needed")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 kernel/sched/core.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index dc270a23179d..326026ba0b2b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4057,9 +4057,20 @@ static int ttwu_runnable(struct task_struct *p, int wake_flags)
 
 	update_rq_clock(rq);
 	if (p->is_blocked) {
+		bool returned;
+
 		if (p->se.sched_delayed)
 			enqueue_task(rq, p, ENQUEUE_NOCLOCK | ENQUEUE_DELAYED);
-		if (proxy_needs_return(rq, p))
+		returned = proxy_needs_return(rq, p);
+		/*
+		 * @p was blocked and this CPU runs a proxy. If @p is the donor
+		 * or a task of its chain, the donor no longer waits for the
+		 * task that runs. wakeup_preempt() compares @p with the donor,
+		 * so it does not see this. Pick again.
+		 */
+		if (rq->donor != rq->curr)
+			resched_curr(rq);
+		if (returned)
 			return 0;
 	}
 	if (!task_on_cpu(rq, p)) {
-- 
2.47.3


  reply	other threads:[~2026-11-16 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:26 [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests Mathieu Desnoyers
2026-11-16 19:26 ` Mathieu Desnoyers [this message]
2026-11-16 21:12   ` [RFC PATCH v1 1/8] sched/proxy: Reschedule when a blocked task is woken under a proxy John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 2/8] sched/proxy: Wake blocked RT and deadline tasks through the full path Mathieu Desnoyers
2026-11-16 21:35   ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 3/8] sched/proxy: Stop the chain walk when the blocked_on chain is a cycle Mathieu Desnoyers
2026-11-16 20:36   ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 4/8] sched/proxy: Tell the class about a proxy migration Mathieu Desnoyers
2026-11-16 20:42   ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 5/8] sched/proxy: Clear blocked_donor when the donor stops donating Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 6/8] sched/deadline: Use the root domain a proxy-migrated task runs in Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 7/8] lib: Add test_proxy_exec, kernel mutexes that user space can hold Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 8/8] selftests/sched: Add tests of proxy execution Mathieu Desnoyers
2026-11-16 20:27 ` [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116192638.233125-2-mathieu.desnoyers@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=akpm@linux-foundation.org \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=connoro@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®