mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: jstultz@google.com, peterz@infradead.org, mingo@redhat.com,
	juri.lelli@redhat.com, vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	kprateek.nayak@amd.com, connoro@google.com, arighi@nvidia.com,
	akpm@linux-foundation.org, shuah@kernel.org,
	linux-kselftest@vger.kernel.org
Subject: [RFC PATCH v1 4/8] sched/proxy: Tell the class about a proxy migration
Date: Mon, 16 Nov 2026 14:26:34 -0500	[thread overview]
Message-ID: <20261116192638.233125-5-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20261116192638.233125-1-mathieu.desnoyers@efficios.com>

find_proxy_task() moves a blocked donor to the runqueue of the mutex
owner. proxy_set_task_cpu() does this with __set_task_cpu(), so that it
can keep p->wake_cpu, the CPU the donor returns to.

But __set_task_cpu() skips what set_task_cpu() does around it:
- the migrate_task_rq() method of the class;
- the migration count and the perf event;
- the sched_migrate_task tracepoint.

For a fair task, the dequeue on the old runqueue detaches its load.
migrate_task_rq_fair() would then reset last_update_time, which makes
the enqueue on the new runqueue attach the load. Without that call, the
load is attached nowhere. When the donor is woken, the return migration
goes through set_task_cpu(). It removes that load from the owner's
runqueue, which never got it.

So each round trip of a donor lowers the load and the utilization of
the owner's runqueue. In a test, a CPU with two tasks that never sleep
showed a mean util_avg of 195, where 1024 is expected. schedutil would
then pick a low frequency for a CPU that is fully busy, and the load
balancer would see that CPU as nearly idle.

Fix this by doing in proxy_set_task_cpu() what set_task_cpu() does
around __set_task_cpu(). Tracers and perf now see a proxy migration as
a migration, and nr_migrations counts it.

migrate_task_rq_dl() moves the bandwidth of a task that migrates to
another root domain. "sched/deadline: Move a task's bandwidth to the
root domain it runs in" added that. A proxy migration must not do it:
the task does not run where it is queued. So make migrate_task_rq_dl()
leave the bandwidth of such a task in its root domain. If its wake-up
then picks a CPU of another root domain, the bandwidth moves at that
time.

Fixes: b049b81bdff6 ("sched: Handle blocked-waiter migration (and return migration)")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 kernel/sched/core.c     | 13 +++++++++++++
 kernel/sched/deadline.c |  8 +++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 24105eeeb3c7..5d82c343662f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6967,6 +6967,19 @@ static inline void proxy_set_task_cpu(struct task_struct *p, int cpu)
 	 * was previously runnable.
 	 */
 	wake_cpu = p->wake_cpu;
+	/*
+	 * Tell the class and the tracers about the migration, as
+	 * set_task_cpu() does. The fair class then attaches the load of @p
+	 * to the new runqueue. Without that, the return migration removes
+	 * load that the runqueue never got.
+	 */
+	trace_sched_migrate_task(p, cpu);
+	if (task_cpu(p) != cpu) {
+		if (p->sched_class->migrate_task_rq)
+			p->sched_class->migrate_task_rq(p, cpu);
+		p->se.nr_migrations++;
+		perf_event_task_migrate(p);
+	}
 	__set_task_cpu(p, cpu);
 	p->wake_cpu = wake_cpu;
 }
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 3b62ee43c209..d14ce3615ba6 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -3030,8 +3030,14 @@ static void migrate_task_rq_dl(struct task_struct *p, int new_cpu)
 	 * the bandwidth. A mask can hold CPUs of two root domains, and
 	 * select_fallback_rq() can widen it. Move the bandwidth there, as
 	 * dl_task_offline_migration() does for a throttled task.
+	 *
+	 * Not for a task that is blocked on a mutex and only queued for
+	 * proxy execution. It does not run on the new CPU, so its bandwidth
+	 * stays in its root domain. If its wake-up then picks a CPU of another
+	 * root domain, the bandwidth moves at that time.
 	 */
-	if (unlikely(dl_task_bw_elsewhere(p, new_cpu)))
+	if (unlikely(dl_task_bw_elsewhere(p, new_cpu)) &&
+	    !(p->is_blocked && task_on_rq_migrating(p)))
 		dl_task_move_bw(p, new_cpu);
 
 	if (READ_ONCE(p->__state) != TASK_WAKING)
-- 
2.47.3


  parent reply	other threads:[~2026-11-16 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:26 [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 1/8] sched/proxy: Reschedule when a blocked task is woken under a proxy Mathieu Desnoyers
2026-11-16 21:12   ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 2/8] sched/proxy: Wake blocked RT and deadline tasks through the full path Mathieu Desnoyers
2026-11-16 21:35   ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 3/8] sched/proxy: Stop the chain walk when the blocked_on chain is a cycle Mathieu Desnoyers
2026-11-16 20:36   ` John Stultz
2026-11-16 19:26 ` Mathieu Desnoyers [this message]
2026-11-16 20:42   ` [RFC PATCH v1 4/8] sched/proxy: Tell the class about a proxy migration John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 5/8] sched/proxy: Clear blocked_donor when the donor stops donating Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 6/8] sched/deadline: Use the root domain a proxy-migrated task runs in Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 7/8] lib: Add test_proxy_exec, kernel mutexes that user space can hold Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 8/8] selftests/sched: Add tests of proxy execution Mathieu Desnoyers
2026-11-16 20:27 ` [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116192638.233125-5-mathieu.desnoyers@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=akpm@linux-foundation.org \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=connoro@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®