From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: jstultz@google.com, peterz@infradead.org, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, connoro@google.com, arighi@nvidia.com,
akpm@linux-foundation.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: [RFC PATCH v1 2/8] sched/proxy: Wake blocked RT and deadline tasks through the full path
Date: Mon, 16 Nov 2026 14:26:32 -0500 [thread overview]
Message-ID: <20261116192638.233125-3-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <20261116192638.233125-1-mathieu.desnoyers@efficios.com>
With proxy execution, a task blocked on a mutex stays on its runqueue.
The RT and deadline classes do not put such a task on their pushable
lists. enqueue_task_rt() and put_prev_task_rt() skip a blocked task.
enqueue_task_dl() and put_prev_task_dl() do the same. find_proxy_task()
migrates it instead.
Commit 7918cf369361 ("sched/proxy: Only return migrate when needed")
wakes a blocked task in place when it is still on its original CPU.
That wake-up does no enqueue. It also skips select_task_rq() and the
task_woken() method of the class. So the woken task is runnable, but it
is not pushable, and no other CPU can pull it.
A SCHED_FIFO task woken this way waits behind a higher priority task
while another CPU is idle. In a test on two CPUs, it ran 500ms after
the mutex was released, when the higher priority task stopped. Without
proxy execution it ran at once on the idle CPU. The test uses
SCHED_FIFO. The deadline class has the same code path.
Fix this in proxy_needs_return(). An RT or deadline task takes the full
wake-up path, as a task that was proxy-migrated does. The other classes
keep the in-place wake-up.
Fixes: 7918cf369361 ("sched/proxy: Only return migrate when needed")
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
kernel/sched/core.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 326026ba0b2b..cededdcfd5a3 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3953,8 +3953,15 @@ static inline bool proxy_needs_return(struct rq *rq, struct task_struct *p)
* only set p->wake_cpu when !p->on_rq, and since here p->on_rq, this
* will not apply. But if it did, this check is the safe way around
* and would migrate.
- */
- if (task_cpu(p) == p->wake_cpu)
+ *
+ * The RT and deadline classes place a task at wake-up:
+ * select_task_rq(), the pushable list, a push to another CPU. An
+ * in-place wake-up skips all of that. So their tasks take the full
+ * wake-up path too.
+ */
+ if (task_cpu(p) == p->wake_cpu &&
+ p->sched_class != &rt_sched_class &&
+ p->sched_class != &dl_sched_class)
return false;
scoped_guard(raw_spinlock, &p->blocked_lock) {
--
2.47.3
next prev parent reply other threads:[~2026-11-16 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:26 [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 1/8] sched/proxy: Reschedule when a blocked task is woken under a proxy Mathieu Desnoyers
2026-11-16 21:12 ` John Stultz
2026-11-16 19:26 ` Mathieu Desnoyers [this message]
2026-11-16 21:35 ` [RFC PATCH v1 2/8] sched/proxy: Wake blocked RT and deadline tasks through the full path John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 3/8] sched/proxy: Stop the chain walk when the blocked_on chain is a cycle Mathieu Desnoyers
2026-11-16 20:36 ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 4/8] sched/proxy: Tell the class about a proxy migration Mathieu Desnoyers
2026-11-16 20:42 ` John Stultz
2026-11-16 19:26 ` [RFC PATCH v1 5/8] sched/proxy: Clear blocked_donor when the donor stops donating Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 6/8] sched/deadline: Use the root domain a proxy-migrated task runs in Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 7/8] lib: Add test_proxy_exec, kernel mutexes that user space can hold Mathieu Desnoyers
2026-11-16 19:26 ` [RFC PATCH v1 8/8] selftests/sched: Add tests of proxy execution Mathieu Desnoyers
2026-11-16 20:27 ` [RFC PATCH v1 0/8] sched/proxy: fixes for proxy execution, with selftests John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116192638.233125-3-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=connoro@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®