mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Hao Yao <hao.yao@intel.com>
Cc: "Fernando Rimoli" <fernandorimoli11@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Daniel Scally" <dan.scally@ideasonboard.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for DSM method
Date: Tue, 17 Nov 2026 09:42:22 +0000	[thread overview]
Message-ID: <20261117094217.83041-1-lsa.uz@pm.me> (raw)
In-Reply-To: <20261026111012.33347-1-fernandorimoli11@gmail.com>

Hi Hao,

Following up on my offer of 16 October: unless you would rather send it
yourself, I will send v3 after 24 November, based on media-committers
next, with you as the author.

Fernando's results change it a little. The value for 24 MHz depends on
the generation, and coreboot's camera_clock_ctl.asl shows the same split:

  Tiger Lake, Jasper Lake, Alder Lake   one bit, 0 = 24 MHz, 1 = 19.2 MHz
  Meteor Lake, Panther Lake, Nova Lake  two bits, 3 = 24 MHz

The Surface Pro 11 (Lunar Lake) has the second layout, the Surface Pro 9
(Alder Lake) the first. On the first, 3 also sets the enable bit again
when the clock is turned off. So v3 would pick the 24 MHz value by CPU
generation and keep 1 for 19.2 MHz, which is right on both. It would
also have the Fixes tag and your note on 0 and 2 that Ilpo asked for. If
Intel's _DSM documentation says otherwise, I will follow it.

Sergey


  reply	other threads:[~2026-11-17  9:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  3:51 Hao Yao
2025-12-08  7:48 ` Dan Scally
2025-12-08  9:31 ` johannes.goede
2025-12-08 11:27 ` Sakari Ailus
2025-12-29 12:06 ` Ilpo Järvinen
2026-04-02  6:56   ` Hao Yao
2026-10-25 15:50 ` Fernando Rimoli
2026-10-25 16:26   ` Sergey Lebedev
2026-10-26 11:10     ` Fernando Rimoli
2026-11-17  9:42       ` Sergey Lebedev [this message]
2026-10-16 11:28 Sergey Lebedev
2026-10-16 14:22 ` Hans de Goede
2026-10-16 14:29   ` Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117094217.83041-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=dan.scally@ideasonboard.com \
    --cc=fernandorimoli11@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®