From: Majid Hajiheidari <majidhhdri@gmail.com>
To: barnabas.czeman@mainlining.org
Cc: andersson@kernel.org, konradybcio@kernel.org, rafael@kernel.org,
viresh.kumar@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, abelvesa@kernel.org, mani@kernel.org,
admin@mswin.me, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm6125: Add cpufreq-hw node
Date: Tue, 17 Nov 2026 18:35:44 +0100 [thread overview]
Message-ID: <20261117173547.1656090-1-majidhhdri@gmail.com> (raw)
In-Reply-To: <a3cbbfa897e960db0d671098be710032@mainlining.org>
Hi Barnabás,
thanks for the review, and for your answer on the cover letter. Both
mails reached me but neither shows up on lore, so I am answering both
here and quoting the relevant parts.
On 2026-11-16 14:41, Barnabás Czémán wrote:
>> + reg = <0x0 0x0f521000 0x0 0x1000>,
>> + <0x0 0x0f523000 0x0 0x1000>;
> If you check the available sources SM6125 is different from SM6115 the
> size is 0x1400 instead of 0x1000.
You are right. The downstream trinket device tree has 0x1400 for both
regions; I took 0x1000 over from sm6115.dtsi. I will fix that in v2.
>> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, <&gcc GPLL0_OUT_EARLY>;
> There is no proof GPLL0_OUT_EARLY is related to cpufreq, the driver
> using the clocks for getting the initial rate from them, it is working
> because this clock have similar rate but i am not sure it is logically
> correct to bind a clock without proof it is related. That is why i
> have made changes in the driver to make the clocks optional.
Agreed that downstream does not tell us where the 300 MHz row comes
from; it has OSM_INIT_RATE and XO_RATE as constants. But that is the
same file and the same constants for every SoC it serves, and the
mainline binding still requires both clocks ("XO Clock", "GPLL0 Clock")
for all of them, SM6115 included. I followed that:
- SM6115 uses <&gcc GPLL0>, which in gcc-sm6115 is the alpha PLL
itself. gcc-sm6125 has no index with that name; the PLL is
GPLL0_OUT_EARLY, with OUT_MAIN and OUT_AUX2 as its /2 outputs. On my
phone it runs at 600 MHz, so the driver's /2 gives the 300 MHz row.
- The mainline driver uses "xo" for every PLL row (xo_rate * lval), not
only for the initial rate, so I think at least that one should stay a
real clock rather than a constant in the driver.
So with the binding as it is today the DT in this series is what the
schema asks for, and a node without clocks would need a binding change
first. Whether the clocks should become optional for these SoCs is
something I would leave to Viresh, Konrad and Krzysztof.
From your mail on the cover letter (2026-11-15):
> Also i have added a new SoC data because SM6125 and SM6115 have less
> LUT entries (12) [2] and there are no throttling IRQs there.
That part I agree with, the trinket fixup in downstream is clear. On
laurel the generic data happens to stop at the repeated row before it
gets that far, but nothing guarantees that. Would you send your soc
data with lut_max_entries = 12 as a driver patch? It does not depend on
the clock question. Your branch as a whole already ran fine on laurel
(see my mail of 15 November), and once the patch is on the list I will
boot it on top of this series and reply with a Tested-by. If the
maintainers prefer that to go in first, or prefer your DT, I am fine
with either and will rebase or drop my cpufreq patch accordingly.
Thanks,
Majid
next parent reply other threads:[~2026-11-17 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a3cbbfa897e960db0d671098be710032@mainlining.org>
2026-11-17 17:35 ` Majid Hajiheidari [this message]
2026-11-15 0:31 [PATCH 0/3] arm64: dts: qcom: sm6125: Add cpufreq-hw and CPU idle states Majid Hajiheidari
2026-11-15 0:31 ` [PATCH 2/3] arm64: dts: qcom: sm6125: Add cpufreq-hw node Majid Hajiheidari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117173547.1656090-1-majidhhdri@gmail.com \
--to=majidhhdri@gmail.com \
--cc=abelvesa@kernel.org \
--cc=admin@mswin.me \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®