* [PATCH v3 0/2] arm64: dts: qcom: sa8255p: add ethernet nodes
@ 2026-11-18 10:05 Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 1/2] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add " Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-18 10:05 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo, Andrew Halaney, Richard Cochran
Cc: linux-arm-msm, devicetree, linux-kernel, netdev,
Bartosz Golaszewski, Konrad Dybcio
This series adds the ethernet nodes for the gearvm variant of lemans and
enables them on the ride development board.
The first patch is a fix to the iommu SID mask - it was wrong all along
but only triggered a crash with recent firmware. This should be queued
for v7.4 and backported to stable branches.
The second adds the ethernet nodes for the sa8255p SoC and enables them
for the Ride platform.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v3:
- Move power-domains and power-domain-names properties for ethernet
nodes into the gearvm variant .dtsi
- Fix sort order for nodes
- Fix PHY label naming for ethernet nodes
- Rebase on top of current linux-next where all dependencies are already
available
- Link to v2: https://patch.msgid.link/20261103-sa8255p-emac-dts-v2-0-05f9355df966@oss.qualcomm.com
Changes in v2:
- Fix node extension ordering
- Move hard-wired serdes phy references to the gearvm .dtsi
- Rebase on top of v7.4-rc1 and v3 of Shawn's series reworking the dts
layout for lemans
- Adjust dt nodes for dropped power-domain-names property
- Drop patch 2/3 in favor of overwriting the compatible property for
the sa8255p variant
- Link to v1: https://patch.msgid.link/20261023-sa8255p-emac-dts-v1-0-a34d778ce9ac@oss.qualcomm.com
---
Bartosz Golaszewski (2):
arm64: dts: qcom: lemans: fix iommus SID mask for ethernet nodes
arm64: dts: qcom: lemans-sa8255p: add ethernet nodes
arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi | 34 ++++
arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts | 201 +++++++++++++++++++++++
arch/arm64/boot/dts/qcom/lemans.dtsi | 4 +-
3 files changed, 237 insertions(+), 2 deletions(-)
---
base-commit: 7cfbf79c66c63e807ea452abf0546e6f6d6833a6
change-id: 20261022-sa8255p-emac-dts-dbc521421276
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] arm64: dts: qcom: lemans: fix iommus SID mask for ethernet nodes
2026-11-18 10:05 [PATCH v3 0/2] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
@ 2026-11-18 10:05 ` Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add " Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-18 10:05 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo, Andrew Halaney, Richard Cochran
Cc: linux-arm-msm, devicetree, linux-kernel, netdev,
Bartosz Golaszewski, Konrad Dybcio
The iommus mask for ethernet nodes is wrong, it makes the SMMU mask 16
stream IDs per MAC. We should actually only use 8 SIDs. This has
triggered a crash on sa8255p after a boot firmware update. Use the
correct value of 0x7.
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index e298747c06bc4519d10f3f0765d0d6a54aac19b3..4e1755a7f2cdce07c454329760cf9a1a2b6b3977 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -4401,7 +4401,7 @@ ethernet1: ethernet@23000000 {
<GIC_SPI 781 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq", "sfty";
- iommus = <&apps_smmu 0x140 0xf>;
+ iommus = <&apps_smmu 0x140 0x7>;
dma-coherent;
snps,tso;
@@ -4422,7 +4422,7 @@ ethernet0: ethernet@23040000 {
<GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq", "sfty";
- iommus = <&apps_smmu 0x120 0xf>;
+ iommus = <&apps_smmu 0x120 0x7>;
dma-coherent;
snps,tso;
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add ethernet nodes
2026-11-18 10:05 [PATCH v3 0/2] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 1/2] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
@ 2026-11-18 10:05 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-18 10:05 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Shawn Guo, Andrew Halaney, Richard Cochran
Cc: linux-arm-msm, devicetree, linux-kernel, netdev, Bartosz Golaszewski
Add the ethernet nodes along with their serdes PHY nodes for the gearvm
variant of the lemans ride board. Enable scmi7 and scmi8 to serve the
EMACs.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi | 34 ++++
arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts | 201 +++++++++++++++++++++++
2 files changed, 235 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
index 91c97a55f2787406b104650956b9a511a6a34c23..aaa8d96dfa61984afaeb13d7543140dd1724979d 100644
--- a/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-gearvm.dtsi
@@ -58,6 +58,22 @@ &cpufreq_hw {
clock-names = "xo", "alternate";
};
+ðernet0 {
+ compatible = "qcom,sa8255p-ethqos";
+ phys = <&serdes0>;
+ phy-names = "serdes";
+ power-domains = <&scmi7_pd 0>, <&scmi7_pd 1>;
+ power-domain-names = "core", "mdio";
+};
+
+ðernet1 {
+ compatible = "qcom,sa8255p-ethqos";
+ phys = <&serdes1>;
+ phy-names = "serdes";
+ power-domains = <&scmi8_pd 0>, <&scmi8_pd 1>;
+ power-domain-names = "core", "mdio";
+};
+
&firmware {
scmi0: scmi-0 {
compatible = "qcom,scmi-smc";
@@ -2898,6 +2914,24 @@ &scm {
memory-region = <&tz_ffi_mem>;
};
+&soc {
+ serdes0: phy@8901000 {
+ compatible = "qcom,sa8255p-dwmac-sgmii-phy";
+ reg = <0x0 0x08901000 0x0 0xe10>;
+ #phy-cells = <0>;
+ power-domains = <&scmi7_dvfs 0>;
+ status = "disabled";
+ };
+
+ serdes1: phy@8902000 {
+ compatible = "qcom,sa8255p-dwmac-sgmii-phy";
+ reg = <0x0 0x08902000 0x0 0xe10>;
+ #phy-cells = <0>;
+ power-domains = <&scmi8_dvfs 0>;
+ status = "disabled";
+ };
+};
+
&spi0 {
compatible = "qcom,sa8255p-geni-spi";
power-domains = <&scmi10_pd 0>,
diff --git a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
index 6f19064997a4b50525fdf630307b843604368645..991626589cc34112df6e024d988bf87e6f520017 100644
--- a/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/lemans-sa8255p-ride.dts
@@ -14,6 +14,8 @@ / {
compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
aliases {
+ ethernet0 = ðernet0;
+ ethernet1 = ðernet1;
serial0 = &uart10;
serial1 = &uart4;
};
@@ -101,6 +103,173 @@ trip1 {
};
};
+ðernet0 {
+ phy-handle = <&hsgmii_phy0>;
+ phy-mode = "2500base-x";
+
+ pinctrl-0 = <ðernet0_default>;
+ pinctrl-names = "default";
+
+ snps,mtl-rx-config = <&mtl_rx_setup>;
+ snps,mtl-tx-config = <&mtl_tx_setup>;
+ snps,ps-speed = <2500>;
+
+ status = "okay";
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hsgmii_phy0: phy@8 {
+ compatible = "ethernet-phy-id31c3.1c33";
+ reg = <0x8>;
+ device_type = "ethernet-phy";
+ resets = <&scmi7_rst 0>;
+ reset-names = "phy";
+ reset-assert-us = <11000>;
+ reset-deassert-us = <70000>;
+ };
+
+ hsgmii_phy1: phy@0 {
+ compatible = "ethernet-phy-id31c3.1c33";
+ reg = <0x0>;
+ device_type = "ethernet-phy";
+ resets = <&scmi8_rst 0>;
+ reset-names = "phy";
+ reset-assert-us = <11000>;
+ reset-deassert-us = <70000>;
+ };
+ };
+
+ mtl_rx_setup: rx-queues-config {
+ snps,rx-queues-to-use = <4>;
+ snps,rx-sched-sp;
+
+ queue0 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x0>;
+ snps,route-up;
+ snps,priority = <0x1>;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x1>;
+ snps,route-ptp;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x2>;
+ snps,route-avcp;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x3>;
+ snps,priority = <0xc>;
+ };
+ };
+
+ mtl_tx_setup: tx-queues-config {
+ snps,tx-queues-to-use = <4>;
+
+ queue0 {
+ snps,dcb-algorithm;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+ };
+};
+
+ðernet1 {
+ phy-mode = "2500base-x";
+ phy-handle = <&hsgmii_phy1>;
+
+ snps,mtl-rx-config = <&mtl_rx_setup1>;
+ snps,mtl-tx-config = <&mtl_tx_setup1>;
+ snps,ps-speed = <2500>;
+
+ status = "okay";
+
+ mtl_rx_setup1: rx-queues-config {
+ snps,rx-queues-to-use = <4>;
+ snps,rx-sched-sp;
+
+ queue0 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x0>;
+ snps,route-up;
+ snps,priority = <0x1>;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ snps,map-to-dma-channel = <0x1>;
+ snps,route-ptp;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x2>;
+ snps,route-avcp;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,map-to-dma-channel = <0x3>;
+ snps,priority = <0xc>;
+ };
+ };
+
+ mtl_tx_setup1: tx-queues-config {
+ snps,tx-queues-to-use = <4>;
+
+ queue0 {
+ snps,dcb-algorithm;
+ };
+
+ queue1 {
+ snps,dcb-algorithm;
+ };
+
+ queue2 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+
+ queue3 {
+ snps,avb-algorithm;
+ snps,send_slope = <0x1000>;
+ snps,idle_slope = <0x1000>;
+ snps,high_credit = <0x3e800>;
+ snps,low_credit = <0xffc18000>;
+ };
+ };
+};
+
&gpll0_board_clk {
clock-frequency = <300000000>;
};
@@ -145,6 +314,14 @@ &scmi6 {
status = "okay";
};
+&scmi7 {
+ status = "okay";
+};
+
+&scmi8 {
+ status = "okay";
+};
+
&scmi11 {
status = "okay";
};
@@ -162,6 +339,22 @@ &sleep_clk {
};
&tlmm {
+ ethernet0_default: ethernet0-default-state {
+ ethernet0_mdc: ethernet0-mdc-pins {
+ pins = "gpio8";
+ function = "emac0_mdc";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+
+ ethernet0_mdio: ethernet0-mdio-pins {
+ pins = "gpio9";
+ function = "emac0_mdio";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+ };
+
pcie0_ep_clkreq_default: pcie0-ep-clkreq-default-state {
pins = "gpio1";
function = "pcie0_clkreq";
@@ -205,6 +398,14 @@ pcie1_ep_wake_default: pcie1-ep-wake-default-state {
};
};
+&serdes0 {
+ status = "okay";
+};
+
+&serdes1 {
+ status = "okay";
+};
+
&uart4 {
status = "okay";
};
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 10:05 [PATCH v3 0/2] arm64: dts: qcom: sa8255p: add ethernet nodes Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 1/2] arm64: dts: qcom: lemans: fix iommus SID mask for " Bartosz Golaszewski
2026-11-18 10:05 ` [PATCH v3 2/2] arm64: dts: qcom: lemans-sa8255p: add " Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®