mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2
@ 2026-11-18 15:17 Olivier Moysan
  2026-11-18 15:17 ` [PATCH v2 01/11] dt-bindings: iio: adc: add stm32mp2 mdf filter Olivier Moysan
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: Olivier Moysan @ 2026-11-18 15:17 UTC (permalink / raw)
  To: Jonathan Cameron, David Lechner, Nuno Sá,
	Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Maxime Coquelin, Alexandre Torgue, Philipp Zabel, Sumit Semwal,
	Christian König, Philipp Stanner, Arnaud Pouliquen,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Fabrice Gasnier
  Cc: linux-iio, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel, linux-media, dri-devel, linaro-mm-sig, linux-sound,
	Olivier Moysan

This series adds support for the STM32 Multi-function Digital Filter
(MDF) found on STM32MP2 SoCs. MDF converts bitstreams from external
sigma-delta modulators and PDM microphones into samples for IIO and
ASoC consumers.

The drivers support direct IIO conversions, cyclic DMA acquisition,
CIC configuration and scaling, synchronized and interleaved filters,
and external timer triggers. An ASoC DAI provides PDM microphone capture.

This revision addresses the v1 review comments listed below and splits
the driver patch into smaller functional patches for readability.
It retains the existing IIO backend interface for external sigma-delta
modulators, pending agreement on the preferred abstraction.

These changes do not resolve all v1 review comments. In particular, the
frontend/backend architecture, DT child-node model and complete clock
topology remain open discussion points.

* Open questions: MDF topology (backend/frontend)

In Analog Devices use of the IIO backend framework, the AXI ADC is a
hardware backend, while the AD9467 is a hardware frontend. The external
sigma-delta modulator is actually a hardware frontend in the MDF signal
chain. The difference from the AD9467 use case is which driver owns the
aggregate IIO device.

Option 1:
One option would be to generalize the existing backend abstraction to
represent components contributing to an aggregate IIO device,
independently of their position in the signal chain.

The existing framework appears to provide the required mechanisms. None
of these mechanisms inherently requires the provider to be a hardware backend.
A generic component/provider model would support both topologies without
duplicating interfaces or requiring reciprocal dependencies. The key
point here is to preserve the compatibility of APIs and DT bindings.

Option 2:
Alternatively, if the backend abstraction should retain its hardware
meaning, we could introduce an explicit frontend-provider abstraction
sharing the existing infrastructure. Frontend operations would cover
analog-side control and conversion parameters.

Would generalizing the existing abstraction be acceptable, or would a
separate frontend interface built on shared infrastructure be preferred?

Option 3:
An aggregate IIO device based on the component framework, as discussed
in previous threads, could also be considered. I currently regard this
as a fallback solution:
https://lore.kernel.org/all/ec411432-4b77-4410-b0aa-b29f73b82c84@foss.st.com/

* Driver implementation

Serial interfaces (SITF) are shared resources managed directly by the
MDF core and no longer have separate platform devices. This revision
retains their DT nodes to describe configuration and clock connections,
and to allow filters to reference their input bitstreams without
duplicating shared settings.

This revision also retains a platform device for each MDF filter, as
each filter manages its own registers, interrupt, DMA channel and IIO
acquisition state, with a separate suspend/resume lifecycle.

* Clock management

Several clock-management review comments are addressed in this revision:
- The provider-side clock-frequency property has been removed. Consumers
  request CCK rates through assigned-clocks and assigned-clock-rates.
- The clock-names property has been removed. The core acquires its single
  input clock by index, and CCK gating uses regmap-based clock operations.
- Remove the unused clock-ranges property, as the core now explicitly
  shares the kernel clock with the serial interfaces and filters instead
  of relying on parent clock lookup.

Clock topology point remains open, awaiting clarification of the MDF topology.

Changes since v1:
- Split the large IIO driver patch into smaller functional patches.
- Replace provider-side clock-frequency with consumer-assigned CCK rates
  through the common clock framework.
- Remove the platform devices for serial interfaces.
- Replace the interleave phandle list with a filter count, covering
  consecutive filters starting at filter 0.
- Simplify clock-output-names, remove clock-names, reset-names and
  filter-level clock properties, and move mdf-dai into an explicit
  property outside the conditional schema.
- Rename the binding to match the STM32MP25 compatible, sort compatible
  entries, and simplify the binding patch subject.
- Use unsigned long for match data, improve probe error reporting and
  wrapping, remove a probe-success debug message, and add kernel-doc for
  exported core functions.
- Use scoped spinlock guards.
- Remove empty serial-interface runtime-PM callbacks.
- Remove the redundant ASoC platform module alias.

Additional fixes since v1 (following Sashiko review):
- Compute the settling-time discard count with 64-bit arithmetic.
- Size cyclic DMA periods in complete scans and validate buffer and
  period alignment before starting DMA.
- Fix backend-enable rollback so backend zero is disabled as well.
- Use managed allocation for the conversion buffer and managed IIO
  triggered-buffer setup.
- Release temporary synchronization and serial-interface firmware-node
  references. Replacing interleave phandles also removes the associated
  stored node references.
- Avoid unregistering secondary interleaved filters that were never
  registered as IIO devices.
- Use managed acquisition of the optional serial clock.
- Replace the GCD-based CCK divider selection with a search for the
  largest valid divisor, allowing non-power-of-two divider values.
- Remove the selection of the undefined COMMON_CLK_REGMAP symbol.

Previous discussion:
https://lore.kernel.org/all/20261001145702.2628429-1-olivier.moysan@foss.st.com/

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
Olivier Moysan (11):
      dt-bindings: iio: adc: add stm32mp2 mdf filter
      iio: adc: stm32-mdf: add core registration
      iio: adc: stm32-mdf: add cck clocks provider
      iio: adc: stm32-mdf: add serial interfaces support
      iio: adc: stm32-mdf: add digital filter device support
      iio: adc: stm32-mdf: configure cic filters and sample rates
      iio: adc: stm32-mdf: add direct iio conversion support
      iio: adc: stm32-mdf: add dma buffered acquisition support
      iio: adc: stm32-mdf: add external timer trigger support
      iio: adc: stm32-mdf: add dmic audio filter support
      ASoC: stm32: add mdf dai support

 .../bindings/iio/adc/st,stm32mp25-mdf.yaml         |  341 ++++
 drivers/iio/adc/Kconfig                            |   29 +
 drivers/iio/adc/Makefile                           |    3 +
 drivers/iio/adc/stm32-mdf-adc.c                    | 2080 ++++++++++++++++++++
 drivers/iio/adc/stm32-mdf-core.c                   |  899 +++++++++
 drivers/iio/adc/stm32-mdf-serial.c                 |  223 +++
 drivers/iio/adc/stm32-mdf.h                        |  275 +++
 include/linux/iio/adc/stm32-mdf-adc.h              |   19 +
 sound/soc/stm/Kconfig                              |   15 +
 sound/soc/stm/Makefile                             |    3 +
 sound/soc/stm/stm32_amdf.c                         |  375 ++++
 11 files changed, 4262 insertions(+)
---
base-commit: d922ed738439e1d5b4701df7f4cdd49a09925624
change-id: 20261112-upstream_mdf_v2-76040d99138e

Best regards,
--  
Olivier Moysan <olivier.moysan@foss.st.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-11-18 15:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 15:17 [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2 Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 01/11] dt-bindings: iio: adc: add stm32mp2 mdf filter Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 02/11] iio: adc: stm32-mdf: add core registration Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 03/11] iio: adc: stm32-mdf: add cck clocks provider Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 04/11] iio: adc: stm32-mdf: add serial interfaces support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 05/11] iio: adc: stm32-mdf: add digital filter device support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 06/11] iio: adc: stm32-mdf: configure cic filters and sample rates Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 07/11] iio: adc: stm32-mdf: add direct iio conversion support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 08/11] iio: adc: stm32-mdf: add dma buffered acquisition support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 09/11] iio: adc: stm32-mdf: add external timer trigger support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 10/11] iio: adc: stm32-mdf: add dmic audio filter support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 11/11] ASoC: stm32: add mdf dai support Olivier Moysan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®