* [PATCH] fs/resctrl: Report unknown schemata domains
@ 2026-11-18 20:58 Nirmoy Das
2026-11-18 23:08 ` Fenghua Yu
0 siblings, 1 reply; 2+ messages in thread
From: Nirmoy Das @ 2026-11-18 20:58 UTC (permalink / raw)
To: Tony Luck, Reinette Chatre, x86
Cc: Fenghua Yu, Dave Martin, James Morse, Babu Moger, Ben Horgan,
Drew Fustini, Thomas Gleixner, linux-kernel
A schemata write to an unknown domain returns -EINVAL without setting
last_cmd_status. The status buffer is cleared before parsing, so reading
last_cmd_status after the failed write incorrectly reports "ok".
Report the invalid domain before returning -EINVAL, matching the existing
I/O allocation parser diagnostic.
Fixes: c377dcfbee80 ("x86/intel_rdt: Add diagnostics when writing the schemata file")
Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
---
fs/resctrl/ctrlmondata.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c
index 69123b2a3274804a..2f7db6c669214c3a 100644
--- a/fs/resctrl/ctrlmondata.c
+++ b/fs/resctrl/ctrlmondata.c
@@ -279,6 +279,7 @@ static int parse_line(char *line, struct resctrl_schema *s,
goto next;
}
}
+ rdt_last_cmd_printf("Invalid domain %lu\n", dom_id);
return -EINVAL;
}
base-commit: 2a93af75384b7e95d62c5a9a39e13573e2170ec5
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs/resctrl: Report unknown schemata domains
2026-11-18 20:58 [PATCH] fs/resctrl: Report unknown schemata domains Nirmoy Das
@ 2026-11-18 23:08 ` Fenghua Yu
0 siblings, 0 replies; 2+ messages in thread
From: Fenghua Yu @ 2026-11-18 23:08 UTC (permalink / raw)
To: Nirmoy Das, Tony Luck, Reinette Chatre, x86
Cc: Dave Martin, James Morse, Babu Moger, Ben Horgan, Drew Fustini,
Thomas Gleixner, linux-kernel
On 11/18/26 12:58, Nirmoy Das wrote:
> A schemata write to an unknown domain returns -EINVAL without setting
> last_cmd_status. The status buffer is cleared before parsing, so reading
> last_cmd_status after the failed write incorrectly reports "ok".
>
> Report the invalid domain before returning -EINVAL, matching the existing
> I/O allocation parser diagnostic.
>
> Fixes: c377dcfbee80 ("x86/intel_rdt: Add diagnostics when writing the schemata file")
> Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
> ---
> fs/resctrl/ctrlmondata.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Thanks.
-Fenghua
> diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c
> index 69123b2a3274804a..2f7db6c669214c3a 100644
> --- a/fs/resctrl/ctrlmondata.c
> +++ b/fs/resctrl/ctrlmondata.c
> @@ -279,6 +279,7 @@ static int parse_line(char *line, struct resctrl_schema *s,
> goto next;
> }
> }
> + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id);
> return -EINVAL;
> }
>
>
> base-commit: 2a93af75384b7e95d62c5a9a39e13573e2170ec5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 20:58 [PATCH] fs/resctrl: Report unknown schemata domains Nirmoy Das
2026-11-18 23:08 ` Fenghua Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®