mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Huang <wei.huang2@amd.com>
To: <dmaengine@vger.kernel.org>
Cc: <vkoul@kernel.org>, <Frank.Li@kernel.org>, <shuah@kernel.org>,
	<nathan.lynch@amd.com>, <wei.huang2@amd.com>,
	<mario.limonciello@amd.com>, <Stephen.Bates@amd.com>,
	<tycho@kernel.org>, <suravee.suthikulpanit@amd.com>,
	<rientjes@google.com>, <John.Kariuki@amd.com>, <jic23@kernel.org>,
	<weixugc@google.com>, <bhelgaas@google.com>,
	<Shyam.Iyer@dell.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: [PATCH v1 29/44] dmaengine: sdxi: amd: add QoS validation scaffolding
Date: Thu, 19 Nov 2026 14:23:05 -0600	[thread overview]
Message-ID: <20261119202321.1734355-30-wei.huang2@amd.com> (raw)
In-Reply-To: <20261119202321.1734355-1-wei.huang2@amd.com>

Create the AMD QoS handler source with common user-buffer helpers,
GUID discovery, and request validators. The added validators check
bandwidth alignment, device and pool updates, function assignments
and telemetry selectors.

Signed-off-by: Wei Huang <wei.huang2@amd.com>
---
 drivers/dma/sdxi/amd/qos.c | 266 +++++++++++++++++++++++++++++++++++++
 drivers/dma/sdxi/amd/qos.h |   4 +-
 2 files changed, 268 insertions(+), 2 deletions(-)
 create mode 100644 drivers/dma/sdxi/amd/qos.c

diff --git a/drivers/dma/sdxi/amd/qos.c b/drivers/dma/sdxi/amd/qos.c
new file mode 100644
index 000000000000..b18ed727aee9
--- /dev/null
+++ b/drivers/dma/sdxi/amd/qos.c
@@ -0,0 +1,266 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * AMD SDXI QoS vendor-command handling.
+ *
+ * Copyright (C) 2026 Advanced Micro Devices, Inc.
+ */
+
+#include <linux/capability.h>
+#include <linux/dma-mapping.h>
+#include <linux/export.h>
+#include <kunit/visibility.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/sizes.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/unaligned.h>
+#include <linux/uaccess.h>
+#include <uapi/linux/sdxi.h>
+
+#include "../admin.h"
+#include "../sdxi.h"
+#include "../vendor.h"
+#include "qos.h"
+
+#define SDXI_AMD_QOS_CAP_BYTES			48U
+#define SDXI_AMD_QOS_TEL_FIXED_BYTES		48U
+#define SDXI_AMD_QOS_TEL_HDR_BYTES		48U
+#define SDXI_AMD_QOS_POOL_REPORT_ENTRY_BYTES	132U
+#define SDXI_AMD_QOS_MAX_TEL_BYTES		SZ_1M
+
+struct sdxi_amd_qos_cap_info {
+	u16 feature_flags;
+	u16 max_pools;
+	u32 device_maxbw_cap;
+	u32 granularity_bw;
+};
+
+struct sdxi_amd_qos_dev_info {
+	u32 device_maxbw;
+	u32 total_allocated_bw;
+};
+
+struct sdxi_amd_qos_pool_info {
+	u32 pool_minbw;
+	u32 pool_maxbw;
+	u16 assigned_functions;
+	u16 assigned_contexts;
+};
+
+/*
+ * SDXI DSC_DISC uses RFC4122-like GUIDs, but with time_low/time_mid/time_hi
+ * stored in little-endian order.
+ */
+static const u8 sdxi_amd_guid_qos[16] = {
+	0x0b, 0x61, 0xb7, 0xf5, 0xc6, 0x0d, 0x03, 0x4c,
+	0xab, 0x79, 0x65, 0xf1, 0xf4, 0xef, 0xcf, 0x4c,
+};
+
+static int
+sdxi_amd_qos_copy_input(const struct sdxi_admin_vendor_args *args,
+			void *dst, size_t size)
+{
+	void __user *ubuf;
+
+	if (!size) {
+		if (args->in_size || args->in_uptr)
+			return -EINVAL;
+		return 0;
+	}
+
+	if (args->in_size != size || !args->in_uptr)
+		return -EINVAL;
+
+	ubuf = u64_to_user_ptr(args->in_uptr);
+	if (!access_ok(ubuf, size))
+		return -EFAULT;
+	if (copy_from_user(dst, ubuf, size))
+		return -EFAULT;
+	if (args->op == SDXI_AMD_QOS_ADMIN_OP_FNUPD &&
+	    size == sizeof(struct sdxi_amd_qos_fnupd_req)) {
+		struct sdxi_amd_qos_fnupd_req *req = dst;
+
+		if (!(req->flags & SDXI_AMD_QOS_TARGET_F_VF))
+			req->vf_num = 0;
+		if (!(req->flags & SDXI_AMD_QOS_TARGET_F_CXT)) {
+			req->cxt_start = 0;
+			req->cxt_end = 0;
+		}
+	}
+
+	return 0;
+}
+
+static int
+sdxi_amd_qos_require_no_output(struct sdxi_admin_vendor_args *args)
+{
+	if (args->out_size || args->out_uptr)
+		return -EINVAL;
+
+	args->out_size = 0;
+
+	return 0;
+}
+
+static int
+sdxi_amd_qos_prepare_output(struct sdxi_admin_vendor_args *args,
+			    size_t required, void __user **ubuf)
+{
+	u32 available = args->out_size;
+
+	if (required > U32_MAX)
+		return -EOVERFLOW;
+
+	args->out_size = (u32)required;
+	if (available < required)
+		return -ENOSPC;
+	if (!args->out_uptr)
+		return -EINVAL;
+
+	*ubuf = u64_to_user_ptr(args->out_uptr);
+	if (!access_ok(*ubuf, required))
+		return -EFAULT;
+
+	return 0;
+}
+
+static int sdxi_amd_qos_admin_ready(const struct sdxi_cxt *adm)
+{
+	if (!adm || !adm->sq || !adm->ring_state || !adm->sq->cxt_sts)
+		return -ENODEV;
+	if (sdxi_cxt_sts_state(adm->sq->cxt_sts) != CXTV_RUN)
+		return -EIO;
+
+	return 0;
+}
+
+u64 sdxi_amd_qos_query_selector(u16 cxt_num, u8 query_type)
+{
+	return FIELD_PREP(GENMASK_ULL(15, 0), cxt_num) |
+	       FIELD_PREP(GENMASK_ULL(18, 16), query_type);
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_query_selector);
+
+u32 sdxi_amd_qos_align_bw(u32 bw, u32 granularity)
+{
+	if (!granularity)
+		return bw;
+
+	return (bw / granularity) * granularity;
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_align_bw);
+
+int sdxi_amd_qos_validate_devupd_req(u32 device_maxbw, u32 device_maxbw_cap,
+				     u32 total_allocated_bw, u32 granularity_bw)
+{
+	if (device_maxbw > device_maxbw_cap)
+		return -EINVAL;
+
+	if (sdxi_amd_qos_align_bw(device_maxbw, granularity_bw) <
+	    total_allocated_bw)
+		return -EINVAL;
+
+	return 0;
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_validate_devupd_req);
+
+int sdxi_amd_qos_validate_poolupd_req(const struct sdxi_amd_qos_poolupd_req *req,
+				      u16 max_pools, u32 granularity_bw)
+{
+	u32 min_bw;
+	u32 max_bw;
+
+	if (!req || !max_pools)
+		return -EINVAL;
+	if (req->rsvd0)
+		return -EINVAL;
+	if (req->pool_num >= max_pools)
+		return -EINVAL;
+	if (req->pool_operation > SDXI_AMD_QOS_POOL_OP_DESTROY)
+		return -EINVAL;
+	if ((req->pool_operation == SDXI_AMD_QOS_POOL_OP_CREATE ||
+	     req->pool_operation == SDXI_AMD_QOS_POOL_OP_DESTROY) &&
+	    !req->pool_num)
+		return -EINVAL;
+	if (req->pool_operation == SDXI_AMD_QOS_POOL_OP_DESTROY)
+		return 0;
+	if (req->pool_minbw > req->pool_maxbw)
+		return -EINVAL;
+
+	min_bw = sdxi_amd_qos_align_bw(req->pool_minbw, granularity_bw);
+	max_bw = sdxi_amd_qos_align_bw(req->pool_maxbw, granularity_bw);
+	if (min_bw > max_bw)
+		return -EINVAL;
+
+	return 0;
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_validate_poolupd_req);
+
+int sdxi_amd_qos_validate_fnupd_req(const struct sdxi_amd_qos_fnupd_req *req,
+				    u16 max_pools, u16 max_vfs, u32 max_cxts,
+				    u16 feature_flags)
+{
+	if (!req || !max_pools)
+		return -EINVAL;
+	if (req->rsvd0)
+		return -EINVAL;
+	if (req->pool_num >= max_pools)
+		return -EINVAL;
+	if (req->flags & ~(SDXI_AMD_QOS_TARGET_F_CXT |
+			   SDXI_AMD_QOS_TARGET_F_VF))
+		return -EINVAL;
+	if (req->flags & SDXI_AMD_QOS_TARGET_F_VF) {
+		if (!max_vfs || req->vf_num >= max_vfs)
+			return -EINVAL;
+	}
+
+	if (!(req->flags & SDXI_AMD_QOS_TARGET_F_CXT))
+		return 0;
+
+	(void)feature_flags;
+	if (req->cxt_start > req->cxt_end)
+		return -EINVAL;
+	if (req->cxt_start >= max_cxts || req->cxt_end >= max_cxts)
+		return -EINVAL;
+
+	return 0;
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_validate_fnupd_req);
+
+int sdxi_amd_qos_validate_tel_req(const struct sdxi_amd_qos_tel_req *req,
+				  u16 max_pools, u16 max_vfs, u32 max_cxts,
+				  u16 feature_flags)
+{
+	if (!req)
+		return -EINVAL;
+	if (req->rsvd0[0] || req->rsvd0[1] || req->rsvd0[2])
+		return -EINVAL;
+
+	switch (req->query_type) {
+	case SDXI_AMD_QOS_TEL_QTYPE_DEVICE:
+	case SDXI_AMD_QOS_TEL_QTYPE_ACTIVE_POOLS:
+		return 0;
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_CONFIG:
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_REPORT:
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_VARIANCE:
+		if (!max_pools || req->pool_num >= max_pools)
+			return -EINVAL;
+		return 0;
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_ASSIGN:
+		if (req->flags & SDXI_AMD_QOS_TARGET_F_VF) {
+			if (!max_vfs || req->vf_num >= max_vfs)
+				return -EINVAL;
+		}
+		if (!(req->flags & SDXI_AMD_QOS_TARGET_F_CXT))
+			return 0;
+		if (!(feature_flags & SDXI_AMD_QOS_FEATURE_FLEXIBLE_POOL_SCOPE))
+			return -EOPNOTSUPP;
+		if (req->cxt_num >= max_cxts)
+			return -EINVAL;
+		return 0;
+	default:
+		return -EINVAL;
+	}
+}
+EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_validate_tel_req);
diff --git a/drivers/dma/sdxi/amd/qos.h b/drivers/dma/sdxi/amd/qos.h
index e5e3e5cf9a50..09c5ee417d9c 100644
--- a/drivers/dma/sdxi/amd/qos.h
+++ b/drivers/dma/sdxi/amd/qos.h
@@ -81,8 +81,8 @@ struct sdxi_amd_qos_tel_req {
 
 u64 sdxi_amd_qos_query_selector(u16 cxt_num, u8 query_type);
 u32 sdxi_amd_qos_align_bw(u32 bw, u32 granularity);
-int sdxi_amd_qos_validate_devupd_req(u32 device_maxbw, u32 total_allocated_bw,
-				     u32 granularity_bw);
+int sdxi_amd_qos_validate_devupd_req(u32 device_maxbw, u32 device_maxbw_cap,
+				     u32 total_allocated_bw, u32 granularity_bw);
 int sdxi_amd_qos_validate_poolupd_req(const struct sdxi_amd_qos_poolupd_req *req,
 				      u16 max_pools, u32 granularity_bw);
 int sdxi_amd_qos_validate_fnupd_req(const struct sdxi_amd_qos_fnupd_req *req,
-- 
2.56.1


  parent reply	other threads:[~2026-11-19 20:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 20:22 [PATCH v1 00/44] dmaengine: sdxi: add userspace control and management support Wei Huang
2026-11-19 20:22 ` [PATCH v1 01/44] dmaengine: sdxi: cache hardware version for feature gating Wei Huang
2026-11-19 20:22 ` [PATCH v1 02/44] dmaengine: sdxi: define key and error MMIO registers Wei Huang
2026-11-19 20:22 ` [PATCH v1 03/44] dmaengine: sdxi: define SDXI hardware layouts Wei Huang
2026-11-19 20:22 ` [PATCH v1 04/44] dmaengine: sdxi: encode admin descriptors Wei Huang
2026-11-19 20:22 ` [PATCH v1 05/44] dmaengine: sdxi: support timeout-aware completion waits Wei Huang
2026-11-19 20:22 ` [PATCH v1 06/44] dmaengine: sdxi: support the full context table hierarchy Wei Huang
2026-11-19 20:22 ` [PATCH v1 07/44] dmaengine: sdxi: implement synchronous admin operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 08/44] dmaengine: sdxi: add core RKey table management Wei Huang
2026-11-19 20:22 ` [PATCH v1 09/44] dmaengine: sdxi: handle hardware error logs Wei Huang
2026-11-19 20:22 ` [PATCH v1 10/44] dmaengine: sdxi: separate context and submission resources Wei Huang
2026-11-19 20:22 ` [PATCH v1 11/44] dmaengine: sdxi: support userspace context lifetimes Wei Huang
2026-11-19 20:22 ` [PATCH v1 12/44] dmaengine: sdxi: route context interrupts to eventfd Wei Huang
2026-11-19 20:22 ` [PATCH v1 13/44] dmaengine: sdxi: kill user contexts on fatal errors Wei Huang
2026-11-19 20:22 ` [PATCH v1 14/44] dmaengine: sdxi: define the ioctl UAPI surface Wei Huang
2026-11-19 20:22 ` [PATCH v1 15/44] dmaengine: sdxi: add internal ioctl definitions Wei Huang
2026-11-19 20:22 ` [PATCH v1 16/44] dmaengine: sdxi: register core character devices Wei Huang
2026-11-19 20:22 ` [PATCH v1 17/44] dmaengine: sdxi: implement fixed-size ioctl dispatch Wei Huang
2026-11-19 20:22 ` [PATCH v1 18/44] dmaengine: sdxi: implement userspace context file operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 19/44] dmaengine: sdxi: validate and copy key ioctl payloads Wei Huang
2026-11-19 20:22 ` [PATCH v1 20/44] dmaengine: sdxi: implement RKey management ioctls Wei Huang
2026-11-19 20:22 ` [PATCH v1 21/44] dmaengine: sdxi: implement AKey " Wei Huang
2026-11-19 20:22 ` [PATCH v1 22/44] dmaengine: sdxi: expose operation-group discovery Wei Huang
2026-11-19 20:22 ` [PATCH v1 23/44] dmaengine: sdxi: implement typed vendor admin transport Wei Huang
2026-11-19 20:23 ` [PATCH v1 24/44] dmaengine: sdxi: expose character device attributes Wei Huang
2026-11-19 20:23 ` [PATCH v1 25/44] dmaengine: sdxi: add PF and VF device naming Wei Huang
2026-11-19 20:23 ` [PATCH v1 26/44] dmaengine: sdxi: add SDXI trace events Wei Huang
2026-11-19 20:23 ` [PATCH v1 27/44] dmaengine: sdxi: support suspend and resume Wei Huang
2026-11-19 20:23 ` [PATCH v1 28/44] dmaengine: sdxi: amd: define QoS request formats Wei Huang
2026-11-19 20:23 ` Wei Huang [this message]
2026-11-19 20:23 ` [PATCH v1 30/44] dmaengine: sdxi: amd: build QoS admin descriptors Wei Huang
2026-11-19 20:23 ` [PATCH v1 31/44] dmaengine: sdxi: amd: prevalidate QoS operations Wei Huang
2026-11-19 20:23 ` [PATCH v1 32/44] dmaengine: sdxi: amd: execute QoS vendor operations Wei Huang
2026-11-19 20:23 ` [PATCH v1 33/44] dmaengine: sdxi: amd: register QoS vendor handler Wei Huang
2026-11-19 20:23 ` [PATCH v1 34/44] dmaengine: sdxi: amd: test QoS validation with KUnit Wei Huang
2026-11-19 20:23 ` [PATCH v1 35/44] selftests: sdxi: add build scaffold Wei Huang
2026-11-19 20:23 ` [PATCH v1 36/44] selftests: sdxi: add shared descriptor and context helpers Wei Huang
2026-11-19 20:23 ` [PATCH v1 37/44] selftests: sdxi: test context creation Wei Huang
2026-11-19 20:23 ` [PATCH v1 38/44] selftests: sdxi: test NOP descriptor submission Wei Huang
2026-11-19 20:23 ` [PATCH v1 39/44] selftests: sdxi: test copy submission and ring wrap Wei Huang
2026-11-19 20:23 ` [PATCH v1 40/44] selftests: sdxi: exercise dataplane error paths Wei Huang
2026-11-19 20:23 ` [PATCH v1 41/44] selftests: sdxi: test device ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 42/44] selftests: sdxi: test vendor admin ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 43/44] selftests: sdxi: test RKey ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 44/44] MAINTAINERS: cover SDXI UAPI, vendor files, and selftests Wei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119202321.1734355-30-wei.huang2@amd.com \
    --to=wei.huang2@amd.com \
    --cc=Frank.Li@kernel.org \
    --cc=John.Kariuki@amd.com \
    --cc=Shyam.Iyer@dell.com \
    --cc=Stephen.Bates@amd.com \
    --cc=bhelgaas@google.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nathan.lynch@amd.com \
    --cc=rientjes@google.com \
    --cc=shuah@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tycho@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=weixugc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®