mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Huang <wei.huang2@amd.com>
To: <dmaengine@vger.kernel.org>
Cc: <vkoul@kernel.org>, <Frank.Li@kernel.org>, <shuah@kernel.org>,
	<nathan.lynch@amd.com>, <wei.huang2@amd.com>,
	<mario.limonciello@amd.com>, <Stephen.Bates@amd.com>,
	<tycho@kernel.org>, <suravee.suthikulpanit@amd.com>,
	<rientjes@google.com>, <John.Kariuki@amd.com>, <jic23@kernel.org>,
	<weixugc@google.com>, <bhelgaas@google.com>,
	<Shyam.Iyer@dell.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: [PATCH v1 31/44] dmaengine: sdxi: amd: prevalidate QoS operations
Date: Thu, 19 Nov 2026 14:23:07 -0600	[thread overview]
Message-ID: <20261119202321.1734355-32-wei.huang2@amd.com> (raw)
In-Reply-To: <20261119202321.1734355-1-wei.huang2@amd.com>

Add software prevalidation for QoS pool updates, function assignments
and telemetry requests so predictable admin faults are rejected early.
These helpers will be used by code introduced later.

Signed-off-by: Wei Huang <wei.huang2@amd.com>
---
 drivers/dma/sdxi/amd/qos.c | 174 +++++++++++++++++++++++++++++++++++++
 1 file changed, 174 insertions(+)

diff --git a/drivers/dma/sdxi/amd/qos.c b/drivers/dma/sdxi/amd/qos.c
index 1899f89bcb90..746e4c8b11e7 100644
--- a/drivers/dma/sdxi/amd/qos.c
+++ b/drivers/dma/sdxi/amd/qos.c
@@ -590,3 +590,177 @@ static int sdxi_amd_qos_get_assigned_functions(struct sdxi_dev *sdxi,
 			  buf, dma);
 	return err;
 }
+
+static int sdxi_amd_qos_prevalidate_poolupd(struct sdxi_dev *sdxi,
+					    struct sdxi_cxt *adm,
+					    u16 opcode_type,
+					    unsigned int timeout_ms,
+					    const struct sdxi_amd_qos_cap_info *cap,
+					    const struct sdxi_amd_qos_poolupd_req *req)
+{
+	struct sdxi_amd_qos_dev_info dev_info;
+	struct sdxi_amd_qos_pool_info pool_info;
+	u32 new_minbw;
+	u32 total_minbw;
+	size_t bytes;
+	u8 *bitmap;
+	bool pool_known;
+	int err;
+
+	err = sdxi_amd_qos_validate_poolupd_req(req, cap->max_pools,
+						cap->granularity_bw);
+	if (err)
+		return err;
+
+	err = sdxi_amd_qos_get_dev_info(sdxi, adm, opcode_type, timeout_ms,
+					&dev_info);
+	if (err)
+		return err;
+
+	bytes = (size_t)(cap->max_pools + 7U) / 8U;
+	bitmap = kcalloc(bytes, sizeof(*bitmap), GFP_KERNEL);
+	if (!bitmap)
+		return -ENOMEM;
+
+	err = sdxi_amd_qos_get_active_pools(sdxi, adm, opcode_type,
+					    timeout_ms, cap->max_pools,
+					    bitmap);
+	if (err) {
+		kfree(bitmap);
+		return err;
+	}
+
+	pool_known = !req->pool_num ||
+		     sdxi_amd_qos_pool_active(bitmap, req->pool_num);
+
+	switch (req->pool_operation) {
+	case SDXI_AMD_QOS_POOL_OP_CREATE:
+		if (sdxi_amd_qos_pool_active(bitmap, req->pool_num))
+			err = -EEXIST;
+		kfree(bitmap);
+		if (err)
+			return err;
+
+		new_minbw = sdxi_amd_qos_align_bw(req->pool_minbw,
+						  cap->granularity_bw);
+		if (dev_info.total_allocated_bw > dev_info.device_maxbw)
+			return -EIO;
+		if (new_minbw > dev_info.device_maxbw - dev_info.total_allocated_bw)
+			return -EINVAL;
+		return 0;
+	case SDXI_AMD_QOS_POOL_OP_UPDATE:
+		kfree(bitmap);
+		if (!pool_known)
+			return -ENOENT;
+		err = sdxi_amd_qos_get_pool_info(sdxi, adm, opcode_type,
+						 req->pool_num, timeout_ms,
+						 &pool_info);
+		if (err)
+			return err;
+
+		if (pool_info.pool_minbw > dev_info.total_allocated_bw)
+			return -EIO;
+		if (dev_info.total_allocated_bw > dev_info.device_maxbw)
+			return -EIO;
+
+		new_minbw = sdxi_amd_qos_align_bw(req->pool_minbw,
+						  cap->granularity_bw);
+		total_minbw = dev_info.total_allocated_bw - pool_info.pool_minbw;
+		if (new_minbw > dev_info.device_maxbw - total_minbw)
+			return -EINVAL;
+		return 0;
+	case SDXI_AMD_QOS_POOL_OP_DESTROY:
+		kfree(bitmap);
+		if (!pool_known)
+			return -ENOENT;
+		err = sdxi_amd_qos_get_pool_info(sdxi, adm, opcode_type,
+						 req->pool_num, timeout_ms,
+						 &pool_info);
+		if (err)
+			return err;
+
+		return 0;
+	default:
+		kfree(bitmap);
+		return -EINVAL;
+	}
+}
+
+static int sdxi_amd_qos_prevalidate_fnupd(struct sdxi_dev *sdxi,
+					  struct sdxi_cxt *adm,
+					  u16 opcode_type,
+					  unsigned int timeout_ms,
+					  const struct sdxi_amd_qos_cap_info *cap,
+					  const struct sdxi_amd_qos_fnupd_req *req)
+{
+	size_t bytes;
+	u8 *bitmap;
+	int err;
+
+	err = sdxi_amd_qos_validate_fnupd_req(req, cap->max_pools,
+					      sdxi_amd_qos_max_vfs(sdxi),
+					      sdxi->max_cxts,
+					      cap->feature_flags);
+	if (err)
+		return err;
+
+	if (!req->pool_num)
+		return 0;
+
+	bytes = (size_t)(cap->max_pools + 7U) / 8U;
+	bitmap = kcalloc(bytes, sizeof(*bitmap), GFP_KERNEL);
+	if (!bitmap)
+		return -ENOMEM;
+
+	err = sdxi_amd_qos_get_active_pools(sdxi, adm, opcode_type, timeout_ms,
+					    cap->max_pools, bitmap);
+	if (!err && !sdxi_amd_qos_pool_active(bitmap, req->pool_num))
+		err = -ENOENT;
+	kfree(bitmap);
+	if (err)
+		return err;
+
+	return 0;
+}
+
+static int sdxi_amd_qos_prevalidate_tel(struct sdxi_dev *sdxi,
+					struct sdxi_cxt *adm,
+					u16 opcode_type,
+					unsigned int timeout_ms,
+					const struct sdxi_amd_qos_cap_info *cap,
+					const struct sdxi_amd_qos_tel_req *req)
+{
+	size_t bytes;
+	u8 *bitmap;
+	int err;
+
+	err = sdxi_amd_qos_validate_tel_req(req, cap->max_pools,
+					    sdxi_amd_qos_max_vfs(sdxi),
+					    sdxi->max_cxts,
+					    cap->feature_flags);
+	if (err)
+		return err;
+
+	switch (req->query_type) {
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_CONFIG:
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_REPORT:
+	case SDXI_AMD_QOS_TEL_QTYPE_POOL_VARIANCE:
+		if (!req->pool_num)
+			return 0;
+
+		bytes = (size_t)(cap->max_pools + 7U) / 8U;
+		bitmap = kcalloc(bytes, sizeof(*bitmap), GFP_KERNEL);
+		if (!bitmap)
+			return -ENOMEM;
+
+		err = sdxi_amd_qos_get_active_pools(sdxi, adm, opcode_type,
+						    timeout_ms, cap->max_pools,
+						    bitmap);
+		if (!err && !sdxi_amd_qos_pool_active(bitmap, req->pool_num))
+			err = -ENOENT;
+		kfree(bitmap);
+		return err;
+	default:
+		return 0;
+	}
+}
-- 
2.56.1


  parent reply	other threads:[~2026-11-19 20:30 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 20:22 [PATCH v1 00/44] dmaengine: sdxi: add userspace control and management support Wei Huang
2026-11-19 20:22 ` [PATCH v1 01/44] dmaengine: sdxi: cache hardware version for feature gating Wei Huang
2026-11-19 20:22 ` [PATCH v1 02/44] dmaengine: sdxi: define key and error MMIO registers Wei Huang
2026-11-19 20:22 ` [PATCH v1 03/44] dmaengine: sdxi: define SDXI hardware layouts Wei Huang
2026-11-19 20:22 ` [PATCH v1 04/44] dmaengine: sdxi: encode admin descriptors Wei Huang
2026-11-19 20:22 ` [PATCH v1 05/44] dmaengine: sdxi: support timeout-aware completion waits Wei Huang
2026-11-19 20:22 ` [PATCH v1 06/44] dmaengine: sdxi: support the full context table hierarchy Wei Huang
2026-11-19 20:22 ` [PATCH v1 07/44] dmaengine: sdxi: implement synchronous admin operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 08/44] dmaengine: sdxi: add core RKey table management Wei Huang
2026-11-19 20:22 ` [PATCH v1 09/44] dmaengine: sdxi: handle hardware error logs Wei Huang
2026-11-19 20:22 ` [PATCH v1 10/44] dmaengine: sdxi: separate context and submission resources Wei Huang
2026-11-19 20:22 ` [PATCH v1 11/44] dmaengine: sdxi: support userspace context lifetimes Wei Huang
2026-11-19 20:22 ` [PATCH v1 12/44] dmaengine: sdxi: route context interrupts to eventfd Wei Huang
2026-11-19 20:22 ` [PATCH v1 13/44] dmaengine: sdxi: kill user contexts on fatal errors Wei Huang
2026-11-19 20:22 ` [PATCH v1 14/44] dmaengine: sdxi: define the ioctl UAPI surface Wei Huang
2026-11-19 20:22 ` [PATCH v1 15/44] dmaengine: sdxi: add internal ioctl definitions Wei Huang
2026-11-19 20:22 ` [PATCH v1 16/44] dmaengine: sdxi: register core character devices Wei Huang
2026-11-19 20:22 ` [PATCH v1 17/44] dmaengine: sdxi: implement fixed-size ioctl dispatch Wei Huang
2026-11-19 20:22 ` [PATCH v1 18/44] dmaengine: sdxi: implement userspace context file operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 19/44] dmaengine: sdxi: validate and copy key ioctl payloads Wei Huang
2026-11-19 20:22 ` [PATCH v1 20/44] dmaengine: sdxi: implement RKey management ioctls Wei Huang
2026-11-19 20:22 ` [PATCH v1 21/44] dmaengine: sdxi: implement AKey " Wei Huang
2026-11-19 20:22 ` [PATCH v1 22/44] dmaengine: sdxi: expose operation-group discovery Wei Huang
2026-11-19 20:22 ` [PATCH v1 23/44] dmaengine: sdxi: implement typed vendor admin transport Wei Huang
2026-11-19 20:23 ` [PATCH v1 24/44] dmaengine: sdxi: expose character device attributes Wei Huang
2026-11-19 20:23 ` [PATCH v1 25/44] dmaengine: sdxi: add PF and VF device naming Wei Huang
2026-11-19 20:23 ` [PATCH v1 26/44] dmaengine: sdxi: add SDXI trace events Wei Huang
2026-11-19 20:23 ` [PATCH v1 27/44] dmaengine: sdxi: support suspend and resume Wei Huang
2026-11-19 20:23 ` [PATCH v1 28/44] dmaengine: sdxi: amd: define QoS request formats Wei Huang
2026-11-19 20:23 ` [PATCH v1 29/44] dmaengine: sdxi: amd: add QoS validation scaffolding Wei Huang
2026-11-19 20:23 ` [PATCH v1 30/44] dmaengine: sdxi: amd: build QoS admin descriptors Wei Huang
2026-11-19 20:23 ` Wei Huang [this message]
2026-11-19 20:23 ` [PATCH v1 32/44] dmaengine: sdxi: amd: execute QoS vendor operations Wei Huang
2026-11-19 20:23 ` [PATCH v1 33/44] dmaengine: sdxi: amd: register QoS vendor handler Wei Huang
2026-11-19 20:23 ` [PATCH v1 34/44] dmaengine: sdxi: amd: test QoS validation with KUnit Wei Huang
2026-11-19 20:23 ` [PATCH v1 35/44] selftests: sdxi: add build scaffold Wei Huang
2026-11-19 20:23 ` [PATCH v1 36/44] selftests: sdxi: add shared descriptor and context helpers Wei Huang
2026-11-19 20:23 ` [PATCH v1 37/44] selftests: sdxi: test context creation Wei Huang
2026-11-19 20:23 ` [PATCH v1 38/44] selftests: sdxi: test NOP descriptor submission Wei Huang
2026-11-19 20:23 ` [PATCH v1 39/44] selftests: sdxi: test copy submission and ring wrap Wei Huang
2026-11-19 20:23 ` [PATCH v1 40/44] selftests: sdxi: exercise dataplane error paths Wei Huang
2026-11-19 20:23 ` [PATCH v1 41/44] selftests: sdxi: test device ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 42/44] selftests: sdxi: test vendor admin ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 43/44] selftests: sdxi: test RKey ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 44/44] MAINTAINERS: cover SDXI UAPI, vendor files, and selftests Wei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119202321.1734355-32-wei.huang2@amd.com \
    --to=wei.huang2@amd.com \
    --cc=Frank.Li@kernel.org \
    --cc=John.Kariuki@amd.com \
    --cc=Shyam.Iyer@dell.com \
    --cc=Stephen.Bates@amd.com \
    --cc=bhelgaas@google.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nathan.lynch@amd.com \
    --cc=rientjes@google.com \
    --cc=shuah@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tycho@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=weixugc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®