From: Wei Huang <wei.huang2@amd.com>
To: <dmaengine@vger.kernel.org>
Cc: <vkoul@kernel.org>, <Frank.Li@kernel.org>, <shuah@kernel.org>,
<nathan.lynch@amd.com>, <wei.huang2@amd.com>,
<mario.limonciello@amd.com>, <Stephen.Bates@amd.com>,
<tycho@kernel.org>, <suravee.suthikulpanit@amd.com>,
<rientjes@google.com>, <John.Kariuki@amd.com>, <jic23@kernel.org>,
<weixugc@google.com>, <bhelgaas@google.com>,
<Shyam.Iyer@dell.com>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: [PATCH v1 30/44] dmaengine: sdxi: amd: build QoS admin descriptors
Date: Thu, 19 Nov 2026 14:23:06 -0600 [thread overview]
Message-ID: <20261119202321.1734355-31-wei.huang2@amd.com> (raw)
In-Reply-To: <20261119202321.1734355-1-wei.huang2@amd.com>
Add AMD QoS descriptor setup, capability reads, telemetry reads and
helper queries that will be used by execution code paths introduced
later.
Signed-off-by: Wei Huang <wei.huang2@amd.com>
---
drivers/dma/sdxi/amd/qos.c | 326 +++++++++++++++++++++++++++++++++++++
1 file changed, 326 insertions(+)
diff --git a/drivers/dma/sdxi/amd/qos.c b/drivers/dma/sdxi/amd/qos.c
index b18ed727aee9..1899f89bcb90 100644
--- a/drivers/dma/sdxi/amd/qos.c
+++ b/drivers/dma/sdxi/amd/qos.c
@@ -264,3 +264,329 @@ int sdxi_amd_qos_validate_tel_req(const struct sdxi_amd_qos_tel_req *req,
}
}
EXPORT_SYMBOL_IF_KUNIT(sdxi_amd_qos_validate_tel_req);
+
+static void sdxi_amd_qos_desc_init(struct sdxi_desc *desc, u16 opcode_type,
+ u8 subtype)
+{
+ memset(desc, 0, sizeof(*desc));
+ desc->opcode = cpu_to_le32(FIELD_PREP(SDXI_DSC_SUBTYPE, subtype) |
+ FIELD_PREP(SDXI_DSC_TYPE, opcode_type));
+ desc->csb_ptr = cpu_to_le64(FIELD_PREP(SDXI_DSC_NP, 1));
+}
+
+static int sdxi_amd_qos_target_scope(u16 pool_num, u16 flags, u16 vf_num,
+ u32 *target_scope)
+{
+ u32 value;
+
+ if (pool_num > 0x0fff)
+ return -EINVAL;
+ if (flags & ~(SDXI_AMD_QOS_TARGET_F_CXT | SDXI_AMD_QOS_TARGET_F_VF))
+ return -EINVAL;
+ if (!(flags & SDXI_AMD_QOS_TARGET_F_VF) && vf_num)
+ return -EINVAL;
+
+ value = pool_num;
+ if (flags & SDXI_AMD_QOS_TARGET_F_CXT)
+ value |= BIT(12);
+ if (flags & SDXI_AMD_QOS_TARGET_F_VF)
+ value |= BIT(15);
+ value |= (u32)vf_num << 16;
+
+ *target_scope = value;
+ return 0;
+}
+
+static u16 sdxi_amd_qos_max_vfs(struct sdxi_dev *sdxi)
+{
+ struct pci_dev *pdev;
+ unsigned int totalvfs;
+
+ if (!sdxi || sdxi_fn_reports_vf(sdxi))
+ return 0;
+
+ pdev = to_pci_dev(sdxi_to_dev(sdxi));
+ totalvfs = pci_sriov_get_totalvfs(pdev);
+ if (totalvfs > U16_MAX)
+ return U16_MAX;
+
+ return (u16)totalvfs;
+}
+
+static bool sdxi_amd_qos_pool_active(const u8 *bitmap, u16 pool_num)
+{
+ if (!bitmap)
+ return false;
+
+ return bitmap[pool_num / 8] & BIT(pool_num % 8);
+}
+
+static int sdxi_amd_qos_get_cap_info(struct sdxi_dev *sdxi,
+ struct sdxi_cxt *adm,
+ u16 opcode_type,
+ unsigned int timeout_ms,
+ struct sdxi_amd_qos_cap_info *cap)
+{
+ struct sdxi_desc desc = {};
+ dma_addr_t dma;
+ u8 *buf;
+ int err;
+
+ if (!cap)
+ return -EINVAL;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_CAP_BYTES, &dma,
+ GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, SDXI_AMD_QOS_CAP_BYTES);
+
+ if (!IS_ALIGNED(dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free;
+ }
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_CAP);
+
+ /* capability_ptr is descriptor bits[127:64], starting at byte offset 8. */
+ put_unaligned_le64(dma, &desc.generic.operation[4]);
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, NULL);
+ if (err)
+ goto out_free;
+
+ dma_rmb();
+ cap->feature_flags = get_unaligned_le16(buf + 2);
+ cap->device_maxbw_cap = get_unaligned_le32(buf + 4);
+ cap->max_pools = (u16)(get_unaligned_le32(buf + 8) & 0x0fff);
+ cap->granularity_bw = get_unaligned_le32(buf + 12);
+ if (!cap->max_pools)
+ err = -EIO;
+
+out_free:
+ dma_free_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_CAP_BYTES, buf, dma);
+ return err;
+}
+
+static int sdxi_amd_qos_get_dev_info(struct sdxi_dev *sdxi,
+ struct sdxi_cxt *adm,
+ u16 opcode_type,
+ unsigned int timeout_ms,
+ struct sdxi_amd_qos_dev_info *info)
+{
+ struct sdxi_desc desc = {};
+ dma_addr_t dma;
+ u8 *buf;
+ int err;
+
+ if (!info)
+ return -EINVAL;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ &dma, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, SDXI_AMD_QOS_TEL_FIXED_BYTES);
+
+ if (!IS_ALIGNED(dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free_dev;
+ }
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_TEL);
+ put_unaligned_le64(sdxi_amd_qos_query_selector(0,
+ SDXI_AMD_QOS_TEL_QTYPE_DEVICE),
+ &desc.generic.operation[4]);
+ put_unaligned_le64(dma, &desc.generic.operation[12]);
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, NULL);
+ if (err)
+ goto out_free_dev;
+
+ dma_rmb();
+ info->device_maxbw = get_unaligned_le32(buf + 4);
+ info->total_allocated_bw = get_unaligned_le32(buf + 12);
+
+out_free_dev:
+ dma_free_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ buf, dma);
+ return err;
+}
+
+static int sdxi_amd_qos_get_pool_info(struct sdxi_dev *sdxi,
+ struct sdxi_cxt *adm,
+ u16 opcode_type, u16 pool_num,
+ unsigned int timeout_ms,
+ struct sdxi_amd_qos_pool_info *info)
+{
+ struct sdxi_desc desc = {};
+ dma_addr_t dma;
+ u8 *buf;
+ u32 target_scope;
+ int err;
+
+ if (!info)
+ return -EINVAL;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ &dma, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, SDXI_AMD_QOS_TEL_FIXED_BYTES);
+
+ if (!IS_ALIGNED(dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free_pool;
+ }
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_TEL);
+ target_scope = FIELD_PREP(GENMASK(11, 0), pool_num);
+ put_unaligned_le32(target_scope, &desc.generic.operation[0]);
+ put_unaligned_le64(sdxi_amd_qos_query_selector(0,
+ SDXI_AMD_QOS_TEL_QTYPE_POOL_CONFIG),
+ &desc.generic.operation[4]);
+ put_unaligned_le64(dma, &desc.generic.operation[12]);
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, NULL);
+ if (err)
+ goto out_free_pool;
+
+ dma_rmb();
+ info->pool_minbw = get_unaligned_le32(buf + 8);
+ info->pool_maxbw = get_unaligned_le32(buf + 12);
+ info->assigned_functions = get_unaligned_le16(buf + 16);
+ info->assigned_contexts = get_unaligned_le16(buf + 18);
+
+out_free_pool:
+ dma_free_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ buf, dma);
+ return err;
+}
+
+static int sdxi_amd_qos_get_active_pools(struct sdxi_dev *sdxi,
+ struct sdxi_cxt *adm,
+ u16 opcode_type,
+ unsigned int timeout_ms,
+ u16 max_pools, u8 *bitmap)
+{
+ struct sdxi_desc desc = {};
+ dma_addr_t dma;
+ u8 *buf;
+ size_t bytes;
+ int err;
+
+ if (!bitmap || !max_pools)
+ return -EINVAL;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ bytes = (size_t)(max_pools + 7U) / 8U;
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_HDR_BYTES + bytes,
+ &dma, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, SDXI_AMD_QOS_TEL_HDR_BYTES + bytes);
+
+ if (!IS_ALIGNED(dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free_active;
+ }
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_TEL);
+ put_unaligned_le64(sdxi_amd_qos_query_selector(0,
+ SDXI_AMD_QOS_TEL_QTYPE_ACTIVE_POOLS),
+ &desc.generic.operation[4]);
+ put_unaligned_le64(dma, &desc.generic.operation[12]);
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, NULL);
+ if (err)
+ goto out_free_active;
+
+ dma_rmb();
+ memcpy(bitmap, buf + SDXI_AMD_QOS_TEL_HDR_BYTES, bytes);
+
+out_free_active:
+ dma_free_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_HDR_BYTES + bytes,
+ buf, dma);
+ return err;
+}
+
+static int sdxi_amd_qos_get_assigned_functions(struct sdxi_dev *sdxi,
+ struct sdxi_cxt *adm,
+ u16 opcode_type, u16 pool_num,
+ unsigned int timeout_ms,
+ u16 *assigned_functions)
+{
+ struct sdxi_desc desc = {};
+ dma_addr_t dma;
+ u8 *buf;
+ u32 counts;
+ u32 target_scope;
+ int err;
+
+ if (!assigned_functions)
+ return -EINVAL;
+
+ err = sdxi_amd_qos_admin_ready(adm);
+ if (err)
+ return err;
+
+ buf = dma_alloc_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ &dma, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ memset(buf, 0, SDXI_AMD_QOS_TEL_FIXED_BYTES);
+
+ if (!IS_ALIGNED(dma, SZ_4K)) {
+ err = -EIO;
+ goto out_free;
+ }
+
+ sdxi_amd_qos_desc_init(&desc, opcode_type,
+ SDXI_AMD_QOS_DSC_SUBTYPE_TEL);
+
+ target_scope = FIELD_PREP(GENMASK(11, 0), pool_num);
+ put_unaligned_le32(target_scope, &desc.generic.operation[0]);
+ put_unaligned_le64(sdxi_amd_qos_query_selector(0,
+ SDXI_AMD_QOS_TEL_QTYPE_POOL_CONFIG),
+ &desc.generic.operation[4]);
+
+ /* telemetry_ptr is descriptor bits[191:128], starting at byte offset 16. */
+ put_unaligned_le64(dma, &desc.generic.operation[12]);
+
+ err = sdxi_adm_submit_desc(adm, &desc, timeout_ms, NULL);
+ if (err)
+ goto out_free;
+
+ dma_rmb();
+ counts = get_unaligned_le32(buf + 16);
+ *assigned_functions = (u16)(counts & 0xffff);
+
+out_free:
+ dma_free_coherent(sdxi_to_dev(sdxi), SDXI_AMD_QOS_TEL_FIXED_BYTES,
+ buf, dma);
+ return err;
+}
--
2.56.1
next prev parent reply other threads:[~2026-11-19 20:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 20:22 [PATCH v1 00/44] dmaengine: sdxi: add userspace control and management support Wei Huang
2026-11-19 20:22 ` [PATCH v1 01/44] dmaengine: sdxi: cache hardware version for feature gating Wei Huang
2026-11-19 20:22 ` [PATCH v1 02/44] dmaengine: sdxi: define key and error MMIO registers Wei Huang
2026-11-19 20:22 ` [PATCH v1 03/44] dmaengine: sdxi: define SDXI hardware layouts Wei Huang
2026-11-19 20:22 ` [PATCH v1 04/44] dmaengine: sdxi: encode admin descriptors Wei Huang
2026-11-19 20:22 ` [PATCH v1 05/44] dmaengine: sdxi: support timeout-aware completion waits Wei Huang
2026-11-19 20:22 ` [PATCH v1 06/44] dmaengine: sdxi: support the full context table hierarchy Wei Huang
2026-11-19 20:22 ` [PATCH v1 07/44] dmaengine: sdxi: implement synchronous admin operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 08/44] dmaengine: sdxi: add core RKey table management Wei Huang
2026-11-19 20:22 ` [PATCH v1 09/44] dmaengine: sdxi: handle hardware error logs Wei Huang
2026-11-19 20:22 ` [PATCH v1 10/44] dmaengine: sdxi: separate context and submission resources Wei Huang
2026-11-19 20:22 ` [PATCH v1 11/44] dmaengine: sdxi: support userspace context lifetimes Wei Huang
2026-11-19 20:22 ` [PATCH v1 12/44] dmaengine: sdxi: route context interrupts to eventfd Wei Huang
2026-11-19 20:22 ` [PATCH v1 13/44] dmaengine: sdxi: kill user contexts on fatal errors Wei Huang
2026-11-19 20:22 ` [PATCH v1 14/44] dmaengine: sdxi: define the ioctl UAPI surface Wei Huang
2026-11-19 20:22 ` [PATCH v1 15/44] dmaengine: sdxi: add internal ioctl definitions Wei Huang
2026-11-19 20:22 ` [PATCH v1 16/44] dmaengine: sdxi: register core character devices Wei Huang
2026-11-19 20:22 ` [PATCH v1 17/44] dmaengine: sdxi: implement fixed-size ioctl dispatch Wei Huang
2026-11-19 20:22 ` [PATCH v1 18/44] dmaengine: sdxi: implement userspace context file operations Wei Huang
2026-11-19 20:22 ` [PATCH v1 19/44] dmaengine: sdxi: validate and copy key ioctl payloads Wei Huang
2026-11-19 20:22 ` [PATCH v1 20/44] dmaengine: sdxi: implement RKey management ioctls Wei Huang
2026-11-19 20:22 ` [PATCH v1 21/44] dmaengine: sdxi: implement AKey " Wei Huang
2026-11-19 20:22 ` [PATCH v1 22/44] dmaengine: sdxi: expose operation-group discovery Wei Huang
2026-11-19 20:22 ` [PATCH v1 23/44] dmaengine: sdxi: implement typed vendor admin transport Wei Huang
2026-11-19 20:23 ` [PATCH v1 24/44] dmaengine: sdxi: expose character device attributes Wei Huang
2026-11-19 20:23 ` [PATCH v1 25/44] dmaengine: sdxi: add PF and VF device naming Wei Huang
2026-11-19 20:23 ` [PATCH v1 26/44] dmaengine: sdxi: add SDXI trace events Wei Huang
2026-11-19 20:23 ` [PATCH v1 27/44] dmaengine: sdxi: support suspend and resume Wei Huang
2026-11-19 20:23 ` [PATCH v1 28/44] dmaengine: sdxi: amd: define QoS request formats Wei Huang
2026-11-19 20:23 ` [PATCH v1 29/44] dmaengine: sdxi: amd: add QoS validation scaffolding Wei Huang
2026-11-19 20:23 ` Wei Huang [this message]
2026-11-19 20:23 ` [PATCH v1 31/44] dmaengine: sdxi: amd: prevalidate QoS operations Wei Huang
2026-11-19 20:23 ` [PATCH v1 32/44] dmaengine: sdxi: amd: execute QoS vendor operations Wei Huang
2026-11-19 20:23 ` [PATCH v1 33/44] dmaengine: sdxi: amd: register QoS vendor handler Wei Huang
2026-11-19 20:23 ` [PATCH v1 34/44] dmaengine: sdxi: amd: test QoS validation with KUnit Wei Huang
2026-11-19 20:23 ` [PATCH v1 35/44] selftests: sdxi: add build scaffold Wei Huang
2026-11-19 20:23 ` [PATCH v1 36/44] selftests: sdxi: add shared descriptor and context helpers Wei Huang
2026-11-19 20:23 ` [PATCH v1 37/44] selftests: sdxi: test context creation Wei Huang
2026-11-19 20:23 ` [PATCH v1 38/44] selftests: sdxi: test NOP descriptor submission Wei Huang
2026-11-19 20:23 ` [PATCH v1 39/44] selftests: sdxi: test copy submission and ring wrap Wei Huang
2026-11-19 20:23 ` [PATCH v1 40/44] selftests: sdxi: exercise dataplane error paths Wei Huang
2026-11-19 20:23 ` [PATCH v1 41/44] selftests: sdxi: test device ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 42/44] selftests: sdxi: test vendor admin ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 43/44] selftests: sdxi: test RKey ioctls Wei Huang
2026-11-19 20:23 ` [PATCH v1 44/44] MAINTAINERS: cover SDXI UAPI, vendor files, and selftests Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119202321.1734355-31-wei.huang2@amd.com \
--to=wei.huang2@amd.com \
--cc=Frank.Li@kernel.org \
--cc=John.Kariuki@amd.com \
--cc=Shyam.Iyer@dell.com \
--cc=Stephen.Bates@amd.com \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.lynch@amd.com \
--cc=rientjes@google.com \
--cc=shuah@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tycho@kernel.org \
--cc=vkoul@kernel.org \
--cc=weixugc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®