* [PATCH] fscrypt: Don't set a policy on immutable or append-only directories
@ 2026-11-19 12:57 Suyuan Wang via B4 Relay
2026-11-19 22:08 ` Eric Biggers
0 siblings, 1 reply; 2+ messages in thread
From: Suyuan Wang via B4 Relay @ 2026-11-19 12:57 UTC (permalink / raw)
To: ebiggers; +Cc: jaegeuk, tytso, linux-kernel, linux-fscrypt
From: Suyuan Wang <stevewong@hust.edu.cn>
FS_IOC_SET_ENCRYPTION_POLICY stores an encryption context in the
directory (an xattr on ext4 and f2fs) and marks the inode as encrypted.
fscrypt_ioctl_set_policy() checks inode_owner_or_capable(), but not the
immutable or append-only inode flags, so the ioctl also succeeds on a
directory with one of those flags set. Setting any other xattr on the
same directory fails with -EPERM in may_write_xattr(), and
FS_IOC_ENABLE_VERITY refuses such files as well.
For example, on ext4 with the encrypt feature:
mkdir d && chattr +i d
setfattr -n user.x -v 1 d -> Operation not permitted
FS_IOC_SET_ENCRYPTION_POLICY on d -> succeeds, d now has a policy
Return -EPERM for an immutable or append-only directory before setting
the policy, as may_write_xattr() does. Calls that find the same policy
already set still return 0, since they don't change the inode.
Found with a static analysis tool and checked by hand.
Fixes: 0b81d0779072 ("fs crypto: move per-file encryption from f2fs tree to fs/crypto")
Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
---
Tested in QEMU (x86_64, ext4 with -O encrypt, v1 policy). Before the
patch the ioctl succeeds on both immutable and append-only empty
directories; with it both get -EPERM, and an ordinary empty directory
still gets its policy.
The Fixes: tag points to the commit that created fs/crypto/policy.c; the
ext4 and f2fs encryption policy code before it lacked these checks too.
I left out Cc: stable, as I'm not sure you'd want this backported.
---
fs/crypto/policy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
index 6dd510f93e6d..86a8254bc3a8 100644
--- a/fs/crypto/policy.c
+++ b/fs/crypto/policy.c
@@ -553,6 +553,8 @@ int fscrypt_ioctl_set_policy(struct file *filp, const void __user *arg)
ret = -ENOTDIR;
else if (IS_DEADDIR(inode))
ret = -ENOENT;
+ else if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
+ ret = -EPERM;
else if (!inode->i_sb->s_cop->empty_dir(inode))
ret = -ENOTEMPTY;
else
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fscrypt: Don't set a policy on immutable or append-only directories
2026-11-19 12:57 [PATCH] fscrypt: Don't set a policy on immutable or append-only directories Suyuan Wang via B4 Relay
@ 2026-11-19 22:08 ` Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2026-11-19 22:08 UTC (permalink / raw)
To: shyckless; +Cc: jaegeuk, tytso, linux-kernel, linux-fscrypt
On Thu, Nov 19, 2026 at 12:57:20PM +0000, Suyuan Wang via B4 Relay wrote:
> From: Suyuan Wang <stevewong@hust.edu.cn>
>
> FS_IOC_SET_ENCRYPTION_POLICY stores an encryption context in the
> directory (an xattr on ext4 and f2fs) and marks the inode as encrypted.
> fscrypt_ioctl_set_policy() checks inode_owner_or_capable(), but not the
> immutable or append-only inode flags, so the ioctl also succeeds on a
> directory with one of those flags set. Setting any other xattr on the
> same directory fails with -EPERM in may_write_xattr(), and
> FS_IOC_ENABLE_VERITY refuses such files as well.
>
> For example, on ext4 with the encrypt feature:
>
> mkdir d && chattr +i d
> setfattr -n user.x -v 1 d -> Operation not permitted
> FS_IOC_SET_ENCRYPTION_POLICY on d -> succeeds, d now has a policy
>
> Return -EPERM for an immutable or append-only directory before setting
> the policy, as may_write_xattr() does. Calls that find the same policy
> already set still return 0, since they don't change the inode.
>
> Found with a static analysis tool and checked by hand.
>
> Fixes: 0b81d0779072 ("fs crypto: move per-file encryption from f2fs tree to fs/crypto")
> Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
I guess so. Could you correct the Fixes tag and add 'Cc stable'? It
should be:
Fixes: 9bd8212f981e ("ext4 crypto: add encryption policy and password salt support")
Fixes: f424f664f0e8 ("f2fs crypto: add encryption policy and password salt support")
Cc: stable@vger.kernel.org
Also, the documentation should be updated too, e.g.:
diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst
index 6e2e511a70bb5..188295f09b213 100644
--- a/Documentation/filesystems/fscrypt.rst
+++ b/Documentation/filesystems/fscrypt.rst
@@ -736,7 +736,7 @@ FS_IOC_SET_ENCRYPTION_POLICY can fail with the following errors:
feature flag enabled using ``tune2fs -O encrypt`` or ``mkfs.ext4 -O
encrypt``.)
- ``EPERM``: this directory may not be encrypted, e.g. because it is
- the root directory of an ext4 filesystem
+ the root directory of an ext4 filesystem or is immutable or append-only
- ``EROFS``: the filesystem is readonly
Getting an encryption policy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 12:57 [PATCH] fscrypt: Don't set a policy on immutable or append-only directories Suyuan Wang via B4 Relay
2026-11-19 22:08 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®