mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RFC PATCH 0/2] ASoC: atmel: mchp-spdifrx: Fix format handling and MR configuration
@ 2026-11-20  3:59 phucduc.bui
  2026-11-20  3:59 ` [RFC PATCH 1/2] ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check phucduc.bui
  2026-11-20  3:59 ` [RFC PATCH 2/2] ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params phucduc.bui
  0 siblings, 2 replies; 3+ messages in thread
From: phucduc.bui @ 2026-11-20  3:59 UTC (permalink / raw)
  To: Mark Brown, Claudiu Beznea, Andrei Simion, Nicolas Ferre,
	Alexandre Belloni
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-sound,
	linux-arm-kernel, linux-kernel, bui duc phuc

From: bui duc phuc <phucduc.bui@gmail.com>

Hi all,

This series addresses two issues in the mchp-spdifrx driver: inconsistent 
handling of the 16-bit big-endian format and MR register updates 
in hw_params().

This series was developed on top of the previous series:
https://lore.kernel.org/all/20261119103413.31729-1-phucduc.bui@gmail.com/

Since this is an RFC series, I have kept it separate rather than including 
these changes in the previous series. The previous series should be 
applied first to avoid conflicts when applying these patches.

The changes are not hardware-tested, and I would appreciate feedback from 
someone with access to the hardware.

In particular, the MR register change needs verification. If the current 
code works as expected, the existing full-register write in hw_params() 
may be intentional, and the actual issue could instead be the default 
configuration in dai_probe().

For the 16-bit big-endian format, the current format check is clearly 
inconsistent with MCHP_SPDIF_FORMATS. However, it is also possible that 
the advertised format should be corrected instead of changing the check 
in hw_params(). Furthermore, I could not find datasheet documentation 
confirming support for big-endian 16-bit and 20-bit formats.

Therefore, hardware testing is needed to determine whether these changes 
are correct.

Compile-tested only.

Best regards,
Phuc

bui duc phuc (2):
  ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check
  ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params

 sound/soc/atmel/mchp-spdifrx.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20  4:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  3:59 [RFC PATCH 0/2] ASoC: atmel: mchp-spdifrx: Fix format handling and MR configuration phucduc.bui
2026-11-20  3:59 ` [RFC PATCH 1/2] ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check phucduc.bui
2026-11-20  3:59 ` [RFC PATCH 2/2] ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params phucduc.bui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®