* [PATCH] usb: gadget: udc: handle NULL request in tracepoint
@ 2026-11-11 6:28 Liu Junyuan
2026-11-20 14:39 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Liu Junyuan @ 2026-11-11 6:28 UTC (permalink / raw)
To: nkapron
Cc: gregkh, linux-usb, linux-kernel, syzbot+2a7ce560c30c4ca3bc22,
Liu Junyuan
usb_ep_alloc_request() passes a NULL request to
trace_usb_ep_alloc_request() when ep->ops->alloc_request() fails.
The udc_log_req tracepoint assumes req is non-NULL and dereferences
req->length, causing a NULL pointer dereference.
Make the tracepoint handle req == NULL so allocation failures can still
be recorded safely.
Reported-by: syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2a7ce560c30c4ca3bc22
Fixes: 5e42d710a108 ("usb: gadget: add tracepoints to the gadget API")
Signed-off-by: Liu Junyuan <2058432396@qq.com>
---
drivers/usb/gadget/udc/trace.h | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/udc/trace.h b/drivers/usb/gadget/udc/trace.h
index fa3e6ddf0a12..bcf89b5693db 100644
--- a/drivers/usb/gadget/udc/trace.h
+++ b/drivers/usb/gadget/udc/trace.h
@@ -239,15 +239,27 @@ DECLARE_EVENT_CLASS(udc_log_req,
),
TP_fast_assign(
__assign_str(name);
- __entry->length = req->length;
- __entry->actual = req->actual;
- __entry->num_sgs = req->num_sgs;
- __entry->num_mapped_sgs = req->num_mapped_sgs;
- __entry->stream_id = req->stream_id;
- __entry->no_interrupt = req->no_interrupt;
- __entry->zero = req->zero;
- __entry->short_not_ok = req->short_not_ok;
- __entry->status = req->status;
+ if (req) {
+ __entry->length = req->length;
+ __entry->actual = req->actual;
+ __entry->num_sgs = req->num_sgs;
+ __entry->num_mapped_sgs = req->num_mapped_sgs;
+ __entry->stream_id = req->stream_id;
+ __entry->no_interrupt = req->no_interrupt;
+ __entry->zero = req->zero;
+ __entry->short_not_ok = req->short_not_ok;
+ __entry->status = req->status;
+ } else {
+ __entry->length = 0;
+ __entry->actual = 0;
+ __entry->num_sgs = 0;
+ __entry->num_mapped_sgs = 0;
+ __entry->stream_id = 0;
+ __entry->no_interrupt = 0;
+ __entry->zero = 0;
+ __entry->short_not_ok = 0;
+ __entry->status = 0;
+ }
__entry->ret = ret;
__entry->req = req;
),
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: udc: handle NULL request in tracepoint
2026-11-11 6:28 [PATCH] usb: gadget: udc: handle NULL request in tracepoint Liu Junyuan
@ 2026-11-20 14:39 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-11-20 14:39 UTC (permalink / raw)
To: Liu Junyuan; +Cc: nkapron, linux-usb, linux-kernel, syzbot+2a7ce560c30c4ca3bc22
On Wed, Nov 11, 2026 at 02:28:01PM +0800, Liu Junyuan wrote:
> usb_ep_alloc_request() passes a NULL request to
> trace_usb_ep_alloc_request() when ep->ops->alloc_request() fails.
> The udc_log_req tracepoint assumes req is non-NULL and dereferences
> req->length, causing a NULL pointer dereference.
>
> Make the tracepoint handle req == NULL so allocation failures can still
> be recorded safely.
>
> Reported-by: syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=2a7ce560c30c4ca3bc22
> Fixes: 5e42d710a108 ("usb: gadget: add tracepoints to the gadget API")
> Signed-off-by: Liu Junyuan <2058432396@qq.com>
> ---
> drivers/usb/gadget/udc/trace.h | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] usb: gadget: udc: handle NULL request in tracepoint
@ 2026-11-11 4:50 LiuJunyuan
0 siblings, 0 replies; 3+ messages in thread
From: LiuJunyuan @ 2026-11-11 4:50 UTC (permalink / raw)
To: nkapron
Cc: gregkh, linux-usb, linux-kernel, syzbot+2a7ce560c30c4ca3bc22, LiuJunyuan
usb_ep_alloc_request() passes a NULL request to
trace_usb_ep_alloc_request() when ep->ops->alloc_request() fails.
The udc_log_req tracepoint assumes req is non-NULL and dereferences
req->length, causing a NULL pointer dereference.
Make the tracepoint handle req == NULL so allocation failures can still
be recorded safely.
Reported-by: syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2a7ce560c30c4ca3bc22
Fixes: 5e42d710a108 ("usb: gadget: add tracepoints to the gadget API")
Signed-off-by: LiuJunyuan <2058432396@qq.com>
---
drivers/usb/gadget/udc/trace.h | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/udc/trace.h b/drivers/usb/gadget/udc/trace.h
index fa3e6ddf0a12..bcf89b5693db 100644
--- a/drivers/usb/gadget/udc/trace.h
+++ b/drivers/usb/gadget/udc/trace.h
@@ -239,15 +239,27 @@ DECLARE_EVENT_CLASS(udc_log_req,
),
TP_fast_assign(
__assign_str(name);
- __entry->length = req->length;
- __entry->actual = req->actual;
- __entry->num_sgs = req->num_sgs;
- __entry->num_mapped_sgs = req->num_mapped_sgs;
- __entry->stream_id = req->stream_id;
- __entry->no_interrupt = req->no_interrupt;
- __entry->zero = req->zero;
- __entry->short_not_ok = req->short_not_ok;
- __entry->status = req->status;
+ if (req) {
+ __entry->length = req->length;
+ __entry->actual = req->actual;
+ __entry->num_sgs = req->num_sgs;
+ __entry->num_mapped_sgs = req->num_mapped_sgs;
+ __entry->stream_id = req->stream_id;
+ __entry->no_interrupt = req->no_interrupt;
+ __entry->zero = req->zero;
+ __entry->short_not_ok = req->short_not_ok;
+ __entry->status = req->status;
+ } else {
+ __entry->length = 0;
+ __entry->actual = 0;
+ __entry->num_sgs = 0;
+ __entry->num_mapped_sgs = 0;
+ __entry->stream_id = 0;
+ __entry->no_interrupt = 0;
+ __entry->zero = 0;
+ __entry->short_not_ok = 0;
+ __entry->status = 0;
+ }
__entry->ret = ret;
__entry->req = req;
),
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 6:28 [PATCH] usb: gadget: udc: handle NULL request in tracepoint Liu Junyuan
2026-11-20 14:39 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 4:50 LiuJunyuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®