mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] drm/imagination: Fix leaks in HWRT data set handling
@ 2026-11-21 15:47 Suyuan Wang via B4 Relay
  2026-11-21 15:47 ` [PATCH v2 1/2] drm/imagination: Destroy the common FW object when HWRT data setup fails Suyuan Wang via B4 Relay
  2026-11-21 15:47 ` [PATCH v2 2/2] drm/imagination: Don't truncate the layer count in max_rts Suyuan Wang via B4 Relay
  0 siblings, 2 replies; 3+ messages in thread
From: Suyuan Wang via B4 Relay @ 2026-11-21 15:47 UTC (permalink / raw)
  To: alessio.belle, luigi.santivetti
  Cc: donald.robson, mripard, dri-devel, maarten.lankhorst, airlied,
	simona, tzimmermann, linux-kernel, imagination

Patch 1 is v1 with the Fixes tag corrected: the error path that skips
hwrt_fini_common_fw_structure() came with f1f55ed3ffe4, not with the
commit that added the ioctl (thanks to the Sashiko review).

Patch 2 fixes the other leak that review pointed out: the 32-bit layer
count is truncated into the 16-bit max_rts, so the SRTC and RAA objects
allocated for layers > 1 can be skipped on destroy.

Found with a static analysis tool and checked by hand. Compile tested on
arm64 (W=1, all files that include pvr_hwrt.h); I don't have the
hardware.

Changes in v2:
- 1/2: Fixes tag now points to f1f55ed3ffe4. No code change.
- 2/2: new.

v1: https://lore.kernel.org/all/20261121-pvr-hwrt-common-v1-1-784ce45b782a@gmail.com/
---
Suyuan Wang (2):
      drm/imagination: Destroy the common FW object when HWRT data setup fails
      drm/imagination: Don't truncate the layer count in max_rts

 drivers/gpu/drm/imagination/pvr_hwrt.c | 2 ++
 drivers/gpu/drm/imagination/pvr_hwrt.h | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-21 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 15:47 [PATCH v2 0/2] drm/imagination: Fix leaks in HWRT data set handling Suyuan Wang via B4 Relay
2026-11-21 15:47 ` [PATCH v2 1/2] drm/imagination: Destroy the common FW object when HWRT data setup fails Suyuan Wang via B4 Relay
2026-11-21 15:47 ` [PATCH v2 2/2] drm/imagination: Don't truncate the layer count in max_rts Suyuan Wang via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®