mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH rtw-next v4 0/4] wifi: rtw88: fixes around the firmware recovery
@ 2026-11-21 19:15 Mehmet Fide
  2026-11-21 19:15 ` [PATCH rtw-next v4 1/4] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Mehmet Fide @ 2026-11-21 19:15 UTC (permalink / raw)
  To: Ping-Ke Shih
  Cc: Luka Gejak, Sascha Hauer, Zong-Zhe Yang, Tzu-En Huang,
	Yan-Hsuan Chuang, Kalle Valo, Stanislaw Gruszka, Brian Norris,
	linux-wireless, linux-kernel, mehmet.fide

From: Mehmet Fide <mehmet.fide@screeningeagle.com>

Fixes for what a firmware crash test showed on an RTL8822CE, and for
what Luka found in v2 and v3. Patch 5 of v3 is dropped, commit
3f2238709f5d ("wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start
failure") does the same.

Tested on rtw-next 0bdc579dbfc2 on an i.MX8MP board with lockdep and
kmemleak, with firmware crashes triggered from debugfs on the RTL8822CE:

- patch 1: no reserved page leaked after crashes with an AP or a
  station interface, where rtw-next leaked pages on each crash. The
  beacon update work and a WoWLAN suspend between the crash and the
  reconfiguration found the pages
- patch 2: with the firmware TX reports dropped in a test build, hostapd
  got a purged client probe as not acknowledged, with no ACK signal or
  link ID
- patch 3: with the collection held back in a test build, a client
  moved back to AUTH and deleted in that window was skipped
- patch 4: no "sleeping function called from invalid context" on a
  crash with an associated station interface

The regression tests on an RTL8822CE, an RTL8822BU, an RTL8822CU and
two RTL8821CU on both bands passed, except the 2.4 GHz beacon test of
the RTL8822CE. A neighbour AP's beacons pass our TBTT on that channel
every 157 s, and the beacon loss over 330 to 400 s is in the same
range with and without the series.

v4:
- patch 1: the pages are kept through the recovery and freed when the
  interface is added again; no port checks (Zong-Zhe Yang, Luka Gejak)
- patch 2: the TX status is cleared when a frame is queued (Luka Gejak);
  Reviewed-by dropped
- patch 3: stations without si->vif are skipped (Luka Gejak)
- patch 4: no change
- patch 5 of v3 dropped for commit 3f2238709f5d

v3:
- patch 1: no RTW_FLAG_RESTARTING test in the beacon update work; the
  page download and the page location H2C do nothing while no port is
  in use (Luka Gejak)
- patch 3: new, rtw_iterate_stas() cannot skip a station (Luka Gejak)
- patch 5: new, RTW_FLAG_RESTARTING is cleared when the device stops
  (Luka Gejak)
- patches 2 and 4: no change
- rebased on rtw-next

v2:
- patch 1: the beacon update work does nothing while
  RTW_FLAG_RESTARTING is set (Luka Gejak)
- patches 2 and 3: Reviewed-by Luka Gejak, no change
- rebased on rtw-next

v3: https://lore.kernel.org/linux-wireless/20261117171003.1840491-1-mehmet.fide@gmail.com/
v2: https://lore.kernel.org/linux-wireless/20261116072014.1142494-1-mehmet.fide@gmail.com/
v1: https://lore.kernel.org/linux-wireless/20261111213239.569224-1-mehmet.fide@gmail.com/

Mehmet Fide (4):
  wifi: rtw88: free the reserved pages of an interface on firmware
    recovery
  wifi: rtw88: report the frames purged from the TX report queue
  wifi: rtw88: do not drop stations when collecting them for an
    iteration
  wifi: rtw88: reset the stations outside of RCU on firmware recovery

 drivers/net/wireless/realtek/rtw88/mac80211.c |  8 +++++-
 drivers/net/wireless/realtek/rtw88/main.c     |  7 ++----
 drivers/net/wireless/realtek/rtw88/main.h     |  2 ++
 drivers/net/wireless/realtek/rtw88/tx.c       | 25 +++++++++++++++----
 drivers/net/wireless/realtek/rtw88/tx.h       |  1 +
 drivers/net/wireless/realtek/rtw88/util.c     | 23 ++++++-----------
 6 files changed, 39 insertions(+), 27 deletions(-)


base-commit: 0bdc579dbfc251a6b6838ee9459b6771b948c617
-- 
2.56.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-21 19:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 19:15 [PATCH rtw-next v4 0/4] wifi: rtw88: fixes around the firmware recovery Mehmet Fide
2026-11-21 19:15 ` [PATCH rtw-next v4 1/4] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-21 19:15 ` [PATCH rtw-next v4 2/4] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-21 19:15 ` [PATCH rtw-next v4 3/4] wifi: rtw88: do not drop stations when collecting them for an iteration Mehmet Fide
2026-11-21 19:15 ` [PATCH rtw-next v4 4/4] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®