mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	linux-iio@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 05/10] iio: adc: stm32-adc: Detach chained IRQ handler before removing domain
Date: Sun, 22 Nov 2026 21:40:57 +0000	[thread overview]
Message-ID: <20261122214057.GE70182@joneslee-macbookpro.roam.internal> (raw)
In-Reply-To: <20261121225114.41f87da3@jic23-hlaptop>

On Sat, 21 Nov 2026, Jonathan Cameron wrote:

> On Fri, 20 Nov 2026 18:23:19 +0100
> Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> 
> > On 11/19/26 16:30, Lee Jones wrote:
> > > stm32_adc_irq_remove() disposes of the child IRQ mappings and removes
> > > priv->domain before clearing the parent chained IRQ handlers.  Because
> > > the parent hardware interrupt lines remain unmasked while child devices
> > > use dummy_irq_chip, an interrupt arriving during teardown invokes
> > > stm32_adc_irq_handler() after irq_domain_remove() has freed
> > > priv->domain, and irq_set_chained_handler() also leaves handler_data
> > > dangling.
> > > 
> > > Detach the chained handlers and clear handler_data with
> > > irq_set_chained_handler_and_data() before tearing down the mappings and
> > > removing the domain.
> > > 
> > > Fixes: 1add69880240 ("iio: adc: Add support for STM32 ADC core")
> > > Closes: https://sashiko.dev/#/bug/linux-27c38690-bc20-43aa-a3fc-1ddd6f1bb74e
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee@kernel.org>
> > > ---  
> > 
> > Hi Lee,
> > 
> > Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> This one seems a little more likely to be hit in practice, but
> it doesn't apply to the fixes tree due to some other recent changes and
> I'm lazy.
> 
> Hence applied to the testing branch of iio.git to line it up for next
> merge cycle. We are getting late enough I should be keeping fixes to critical
> stuff only and I'm going to assume this one isn't.

My preference for all of these sets is for them to be applied for -next
rather than -fixes, if it's all the same to you.

And yes, v2s are no issue (replying to your other comments here).

Bear with.

-- 
Lee Jones

  reply	other threads:[~2026-11-22 21:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:30 [PATCH 00/10] iio: Fix memory corruption, teardown races and bounds checks Lee Jones
2026-11-19 15:30 ` [PATCH 01/10] iio: imu: adis: Clear pointers after freeing in adis_update_scan_mode() Lee Jones
2026-11-21 22:27   ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 02/10] iio: accel: adxl313: Prevent FIFO buffer overflow in adxl313_fifo_transfer() Lee Jones
2026-11-19 17:22   ` Andy Shevchenko
2026-11-21 22:32     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 03/10] iio: accel: adxl313: Reject sub-base ODR codes in adxl313_read_raw() Lee Jones
2026-11-19 17:23   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 04/10] iio: adc: stm32-adc: Validate channel index before writing chan_name Lee Jones
2026-11-19 17:24   ` Andy Shevchenko
2026-11-20 17:22     ` Fabrice Gasnier
2026-11-21 22:45       ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 05/10] iio: adc: stm32-adc: Detach chained IRQ handler before removing domain Lee Jones
2026-11-20 17:23   ` Fabrice Gasnier
2026-11-21 22:51     ` Jonathan Cameron
2026-11-22 21:40       ` Lee Jones [this message]
2026-11-19 15:30 ` [PATCH 06/10] iio: adc: pac1934: Fix custom attribute allocation and channel bounds Lee Jones
2026-11-19 17:27   ` Andy Shevchenko
2026-11-21 22:54     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 07/10] iio: adc: qcom-spmi-adc5-gen3: Free TM auxiliary device wrapper in release callback Lee Jones
2026-11-19 17:30   ` Andy Shevchenko
2026-11-21 23:08     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 08/10] iio: adc: qcom-spmi-adc5-gen3: Reject empty reg property in probe Lee Jones
2026-11-19 17:31   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 09/10] iio: proximity: isl29501: Fix division by zero and overflow in isl29501_set_freq() Lee Jones
2026-11-19 17:34   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 10/10] iio: light: tsl2591: Prevent infinite recursion on threshold boundaries Lee Jones
2026-11-21 23:13   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122214057.GE70182@joneslee-macbookpro.roam.internal \
    --to=lee@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®